[INFO] crate rft 0.1.0 is already in cache [INFO] extracting crate rft 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rft/0.1.0 [INFO] extracting crate rft 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rft/0.1.0 [INFO] validating manifest of rft-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rft-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rft-0.1.0 [INFO] finished frobbing rft-0.1.0 [INFO] frobbed toml for rft-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rft/0.1.0/Cargo.toml [INFO] started frobbing rft-0.1.0 [INFO] finished frobbing rft-0.1.0 [INFO] frobbed toml for rft-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rft/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rft-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rft/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1eec59aa854b84ff23d7f438bf60761ff4087183752517d246973da63690163 [INFO] running `"docker" "start" "-a" "d1eec59aa854b84ff23d7f438bf60761ff4087183752517d246973da63690163"` [INFO] [stderr] Checking strided v0.2.9 [INFO] [stderr] Checking rft v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/window/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod window; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | const ALPHA0: Precision = 0.355768; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.355_768` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | const ALPHA1: Precision = 0.487396; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.487_396` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | const ALPHA2: Precision = 0.144232; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.144_232` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | const ALPHA3: Precision = 0.012604; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.012_604` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/spectrum/average/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | mut output: MutStride); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/window/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod window; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | const ALPHA0: Precision = 0.355768; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.355_768` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | const ALPHA1: Precision = 0.487396; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.487_396` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | const ALPHA2: Precision = 0.144232; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.144_232` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/window/nuttall.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | const ALPHA3: Precision = 0.012604; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.012_604` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/spectrum/average/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | mut output: MutStride); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/spectrum/mod.rs:98:45 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(super::bandwidth(1024, 44100), 43.066406); [INFO] [stderr] | ^^^^^^^^^ help: consider: `43.066_406` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::Zero` [INFO] [stderr] --> src/window/window.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num::Zero; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::Zero` [INFO] [stderr] --> src/window/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | use num::Zero; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:20:6 [INFO] [stderr] | [INFO] [stderr] 20 | -((*self as Precision - i8::MAX as Precision) / i8::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(*self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | -((*self as Precision - i8::MAX as Precision) / i8::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:20:51 [INFO] [stderr] | [INFO] [stderr] 20 | -((*self as Precision - i8::MAX as Precision) / i8::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | *self as Precision / -(i16::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | *self as Precision / -(i16::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | *self = (value as f64 * i16::MAX as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | *self = (value as f64 * i16::MAX as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | *self = -(value as f64 * i16::MIN as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | *self = -(value as f64 * i16::MIN as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | *self = (value as f64 * i32::MAX as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | *self = (value as f64 * i32::MAX as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | *self = -(value as f64 * i32::MIN as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | *self = -(value as f64 * i32::MIN as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:98:11 [INFO] [stderr] | [INFO] [stderr] 98 | *self = value as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/complex.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | self.re = value as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/complex.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | self.im = value as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/transform/cooley_tukey.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | factor = factor * twiddle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `factor *= twiddle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/spectrum/average/logarithmic.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | for i in low .. hig { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for in input.iter().take(hig).skip(low) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::Zero` [INFO] [stderr] --> src/window/window.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num::Zero; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::Zero` [INFO] [stderr] --> src/window/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | use num::Zero; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:20:6 [INFO] [stderr] | [INFO] [stderr] 20 | -((*self as Precision - i8::MAX as Precision) / i8::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(*self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | -((*self as Precision - i8::MAX as Precision) / i8::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:20:51 [INFO] [stderr] | [INFO] [stderr] 20 | -((*self as Precision - i8::MAX as Precision) / i8::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | *self as Precision / -(i16::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | *self as Precision / -(i16::MIN as Precision) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | *self = (value as f64 * i16::MAX as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | *self = (value as f64 * i16::MAX as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | *self = -(value as f64 * i16::MIN as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | *self = -(value as f64 * i16::MIN as f64) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | *self = (value as f64 * i32::MAX as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | *self = (value as f64 * i32::MAX as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | *self = -(value as f64 * i32::MIN as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | *self = -(value as f64 * i32::MIN as f64) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:98:11 [INFO] [stderr] | [INFO] [stderr] 98 | *self = value as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/complex.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | self.re = value as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/complex.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | self.im = value as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/transform/cooley_tukey.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | factor = factor * twiddle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `factor *= twiddle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/transform/cooley_tukey.rs:115:2 [INFO] [stderr] | [INFO] [stderr] 115 | fn inverse() { [INFO] [stderr] | _____^ [INFO] [stderr] 116 | | let mut output = vec![Complex::new(0.0, 0.0); 4]; [INFO] [stderr] 117 | | super::inverse(Stride::new(&[1.0, 1.0, 0.0, 0.0]), output.as_stride_mut()); [INFO] [stderr] 118 | | [INFO] [stderr] ... | [INFO] [stderr] 126 | | assert_approx_eq!(output[3], Complex::new(0.25, -0.25)); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/transform/bluestein.rs:122:2 [INFO] [stderr] | [INFO] [stderr] 122 | fn forward() { [INFO] [stderr] | _____^ [INFO] [stderr] 123 | | let mut output = vec![Complex::new(0.0, 0.0); 5]; [INFO] [stderr] 124 | | super::forward(Stride::new(&[1.0, 1.0, 0.0, 0.0, 0.5]), output.as_stride_mut()); [INFO] [stderr] 125 | | [INFO] [stderr] ... | [INFO] [stderr] 130 | | assert_approx_eq!(output[4], Complex::new( 1.46, 0.48)); [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/transform/bluestein.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | fn inverse() { [INFO] [stderr] | _____^ [INFO] [stderr] 135 | | let mut output = vec![Complex::new(0.0, 0.0); 5]; [INFO] [stderr] 136 | | super::inverse(Stride::new(&[1.0, 1.0, 0.0, 0.0, 0.5]), output.as_stride_mut()); [INFO] [stderr] 137 | | [INFO] [stderr] ... | [INFO] [stderr] 146 | | assert_approx_eq!(output[4], Complex::new( 0.29, -0.10)); [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/spectrum/average/logarithmic.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | for i in low .. hig { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for in input.iter().take(hig).skip(low) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/spectrum/mod.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(super::bandwidth(1024, 44100), 43.066406); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/spectrum/mod.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(super::bandwidth(1024, 44100), 43.066406); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rft`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d1eec59aa854b84ff23d7f438bf60761ff4087183752517d246973da63690163"` [INFO] running `"docker" "rm" "-f" "d1eec59aa854b84ff23d7f438bf60761ff4087183752517d246973da63690163"` [INFO] [stdout] d1eec59aa854b84ff23d7f438bf60761ff4087183752517d246973da63690163