[INFO] crate rexpaint 0.1.0 is already in cache [INFO] extracting crate rexpaint 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rexpaint/0.1.0 [INFO] extracting crate rexpaint 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rexpaint/0.1.0 [INFO] validating manifest of rexpaint-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rexpaint-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rexpaint-0.1.0 [INFO] finished frobbing rexpaint-0.1.0 [INFO] frobbed toml for rexpaint-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rexpaint/0.1.0/Cargo.toml [INFO] started frobbing rexpaint-0.1.0 [INFO] finished frobbing rexpaint-0.1.0 [INFO] frobbed toml for rexpaint-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rexpaint/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rexpaint-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rexpaint/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4e3a4cdabb30775955ea7755d546c157081355f991e714c947b028032570095 [INFO] running `"docker" "start" "-a" "c4e3a4cdabb30775955ea7755d546c157081355f991e714c947b028032570095"` [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Checking rexpaint v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking noise v0.5.1 [INFO] [stderr] Compiling csv-core v0.1.5 [INFO] [stderr] Compiling csv v1.0.5 [INFO] [stderr] Compiling codepage-437 v0.1.0 [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> examples/noise.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> examples/noise.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/noise.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | const CMAP_FIRE: &'static [XpColor] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[XpColor]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/noise.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | const CMAP_NEBULA: &'static [XpColor] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[XpColor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/noise.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | ((a.r as f32) * (1.0 - i) + (b.r as f32) * i) as u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(a.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/noise.rs:33:41 [INFO] [stderr] | [INFO] [stderr] 33 | ((a.r as f32) * (1.0 - i) + (b.r as f32) * i) as u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(b.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/noise.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | ((a.g as f32) * (1.0 - i) + (b.g as f32) * i) as u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(a.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/noise.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | ((a.g as f32) * (1.0 - i) + (b.g as f32) * i) as u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(b.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/noise.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | ((a.b as f32) * (1.0 - i) + (b.b as f32) * i) as u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(a.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/noise.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | ((a.b as f32) * (1.0 - i) + (b.b as f32) * i) as u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(b.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/noise.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | let cmap_name = args.get(3).cloned().unwrap_or("fire".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "fire".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.67s [INFO] running `"docker" "inspect" "c4e3a4cdabb30775955ea7755d546c157081355f991e714c947b028032570095"` [INFO] running `"docker" "rm" "-f" "c4e3a4cdabb30775955ea7755d546c157081355f991e714c947b028032570095"` [INFO] [stdout] c4e3a4cdabb30775955ea7755d546c157081355f991e714c947b028032570095