[INFO] crate revmenu 0.1.2 is already in cache [INFO] extracting crate revmenu 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/revmenu/0.1.2 [INFO] extracting crate revmenu 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/revmenu/0.1.2 [INFO] validating manifest of revmenu-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of revmenu-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing revmenu-0.1.2 [INFO] finished frobbing revmenu-0.1.2 [INFO] frobbed toml for revmenu-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/revmenu/0.1.2/Cargo.toml [INFO] started frobbing revmenu-0.1.2 [INFO] finished frobbing revmenu-0.1.2 [INFO] frobbed toml for revmenu-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/revmenu/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting revmenu-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/revmenu/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1691ef1bf567a9f909c80980123c2ef44e91d2b48c04c944408ca7c985ad68e0 [INFO] running `"docker" "start" "-a" "1691ef1bf567a9f909c80980123c2ef44e91d2b48c04c944408ca7c985ad68e0"` [INFO] [stderr] Checking exitcode v1.1.2 [INFO] [stderr] Compiling im v9.0.0 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking revmenu v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/highlight.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/highlight.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/git.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(root: &Path) -> Option> { [INFO] [stderr] 17 | | if root.join(".git").exists() { [INFO] [stderr] 18 | | Some(Box::new(Git { [INFO] [stderr] 19 | | root: root.to_path_buf(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/hg.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(root: &Path) -> Option> { [INFO] [stderr] 17 | | if root.join(".hg").exists() { [INFO] [stderr] 18 | | Some(Box::new(Hg { [INFO] [stderr] 19 | | root: root.to_path_buf(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/vcs/mod.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | static SUPPORTED_VCS: [fn(&Path) -> Option>; 2] = [Git::new, Hg::new]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/highlight.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | selected: &Option<&parser::Located>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&parser::Located>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/highlight.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | selected: &Option<&RevLocation>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&RevLocation>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/git.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(root: &Path) -> Option> { [INFO] [stderr] 17 | | if root.join(".git").exists() { [INFO] [stderr] 18 | | Some(Box::new(Git { [INFO] [stderr] 19 | | root: root.to_path_buf(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/hg.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(root: &Path) -> Option> { [INFO] [stderr] 17 | | if root.join(".hg").exists() { [INFO] [stderr] 18 | | Some(Box::new(Hg { [INFO] [stderr] 19 | | root: root.to_path_buf(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/vcs/mod.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | static SUPPORTED_VCS: [fn(&Path) -> Option>; 2] = [Git::new, Hg::new]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/highlight.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | selected: &Option<&parser::Located>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&parser::Located>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/highlight.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | selected: &Option<&RevLocation>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&RevLocation>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.89s [INFO] running `"docker" "inspect" "1691ef1bf567a9f909c80980123c2ef44e91d2b48c04c944408ca7c985ad68e0"` [INFO] running `"docker" "rm" "-f" "1691ef1bf567a9f909c80980123c2ef44e91d2b48c04c944408ca7c985ad68e0"` [INFO] [stdout] 1691ef1bf567a9f909c80980123c2ef44e91d2b48c04c944408ca7c985ad68e0