[INFO] crate return_if_ok 0.1.0 is already in cache [INFO] extracting crate return_if_ok 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/return_if_ok/0.1.0 [INFO] extracting crate return_if_ok 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/return_if_ok/0.1.0 [INFO] validating manifest of return_if_ok-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of return_if_ok-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing return_if_ok-0.1.0 [INFO] finished frobbing return_if_ok-0.1.0 [INFO] frobbed toml for return_if_ok-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/return_if_ok/0.1.0/Cargo.toml [INFO] started frobbing return_if_ok-0.1.0 [INFO] finished frobbing return_if_ok-0.1.0 [INFO] frobbed toml for return_if_ok-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/return_if_ok/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting return_if_ok-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/return_if_ok/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf964c10ea94f4dd6493aaa9bcea0e4164821414356044413b6a5c313feac7d9 [INFO] running `"docker" "start" "-a" "bf964c10ea94f4dd6493aaa9bcea0e4164821414356044413b6a5c313feac7d9"` [INFO] [stderr] Checking return_if_ok v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> lib.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | / match $expression { [INFO] [stderr] 5 | | ::std::result::Result::Ok(value) => { [INFO] [stderr] 6 | | return ::std::result::Result::Ok(value) [INFO] [stderr] 7 | | } [INFO] [stderr] 8 | | ::std::result::Result::Err(error) => error [INFO] [stderr] 9 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 17 | Err(return_if_ok!(Ok(4))) [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 4 | () [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> lib.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | / match $expression { [INFO] [stderr] 5 | | ::std::result::Result::Ok(value) => { [INFO] [stderr] 6 | | return ::std::result::Result::Ok(value) [INFO] [stderr] 7 | | } [INFO] [stderr] 8 | | ::std::result::Result::Err(error) => error [INFO] [stderr] 9 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 22 | Err(return_if_ok!(Err(()))) [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 4 | () [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "bf964c10ea94f4dd6493aaa9bcea0e4164821414356044413b6a5c313feac7d9"` [INFO] running `"docker" "rm" "-f" "bf964c10ea94f4dd6493aaa9bcea0e4164821414356044413b6a5c313feac7d9"` [INFO] [stdout] bf964c10ea94f4dd6493aaa9bcea0e4164821414356044413b6a5c313feac7d9