[INFO] crate retest 0.2.3 is already in cache [INFO] extracting crate retest 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/retest/0.2.3 [INFO] extracting crate retest 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/retest/0.2.3 [INFO] validating manifest of retest-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of retest-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing retest-0.2.3 [INFO] finished frobbing retest-0.2.3 [INFO] frobbed toml for retest-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/retest/0.2.3/Cargo.toml [INFO] started frobbing retest-0.2.3 [INFO] finished frobbing retest-0.2.3 [INFO] frobbed toml for retest-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/retest/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting retest-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/retest/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 820b285b2c83b3d132ff2ffbe71ab87e91be962791c7f918123e6008b272945b [INFO] running `"docker" "start" "-a" "820b285b2c83b3d132ff2ffbe71ab87e91be962791c7f918123e6008b272945b"` [INFO] [stderr] Checking retest v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/retest.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/retest.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/retest.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/retest.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | const VERSION: &'static str = "0.2.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 110 | | if let Err(e) = retest::print_subject_highlighted(&subject, &matches) { [INFO] [stderr] 111 | | eprintln!("ERROR: {}", e); [INFO] [stderr] 112 | | process::exit(1); [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 109 | } else if let Err(e) = retest::print_subject_highlighted(&subject, &matches) { [INFO] [stderr] 110 | eprintln!("ERROR: {}", e); [INFO] [stderr] 111 | process::exit(1); [INFO] [stderr] 112 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | const VERSION: &'static str = "0.2.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 110 | | if let Err(e) = retest::print_subject_highlighted(&subject, &matches) { [INFO] [stderr] 111 | | eprintln!("ERROR: {}", e); [INFO] [stderr] 112 | | process::exit(1); [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 109 | } else if let Err(e) = retest::print_subject_highlighted(&subject, &matches) { [INFO] [stderr] 110 | eprintln!("ERROR: {}", e); [INFO] [stderr] 111 | process::exit(1); [INFO] [stderr] 112 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/retest.rs:63:62 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn print_subject_highlighted<'t>(subject: &str, matches: &Vec>) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Captures<'t>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/retest.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn print_match_list<'t>(subject: &str, matches: &Vec>) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Captures<'t>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/retest.rs:63:62 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn print_subject_highlighted<'t>(subject: &str, matches: &Vec>) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Captures<'t>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/retest.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn print_match_list<'t>(subject: &str, matches: &Vec>) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Captures<'t>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "820b285b2c83b3d132ff2ffbe71ab87e91be962791c7f918123e6008b272945b"` [INFO] running `"docker" "rm" "-f" "820b285b2c83b3d132ff2ffbe71ab87e91be962791c7f918123e6008b272945b"` [INFO] [stdout] 820b285b2c83b3d132ff2ffbe71ab87e91be962791c7f918123e6008b272945b