[INFO] crate resty 0.1.0 is already in cache [INFO] extracting crate resty 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/resty/0.1.0 [INFO] extracting crate resty 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/resty/0.1.0 [INFO] validating manifest of resty-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of resty-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing resty-0.1.0 [INFO] finished frobbing resty-0.1.0 [INFO] frobbed toml for resty-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/resty/0.1.0/Cargo.toml [INFO] started frobbing resty-0.1.0 [INFO] finished frobbing resty-0.1.0 [INFO] frobbed toml for resty-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/resty/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting resty-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/resty/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d76e955d602fe5cadaeea90c6a265d3adc929bfc8c3ffbcfa88dca2fc5ff1d0 [INFO] running `"docker" "start" "-a" "7d76e955d602fe5cadaeea90c6a265d3adc929bfc8c3ffbcfa88dca2fc5ff1d0"` [INFO] [stderr] Checking resty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prefix_tree.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return best_result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/prefix_tree.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | Ok(s) => format!("{}", s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/prefix_tree.rs:50:62 [INFO] [stderr] | [INFO] [stderr] 50 | (Node::Data(a), Node::Tree(b, next)) => Node::Tree(b.or(Some(a)), next), [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(a))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/prefix_tree.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn iter<'a>(&'a self) -> TreeIterator<'a, T> { [INFO] [stderr] 73 | | TreeIterator { [INFO] [stderr] 74 | | stack: vec![(vec![], 0, &self)], [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/request/params.rs:108:33 [INFO] [stderr] | [INFO] [stderr] 108 | while let Some(param) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for param in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/request/params.rs:169:34 [INFO] [stderr] | [INFO] [stderr] 169 | Some(seg) if seg == &segment => {}, [INFO] [stderr] | ^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `segment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prefix_tree.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return best_result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/router.rs:197:43 [INFO] [stderr] | [INFO] [stderr] 197 | while let Some((prefix, route)) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for (prefix, route) in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/prefix_tree.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | Ok(s) => format!("{}", s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/prefix_tree.rs:50:62 [INFO] [stderr] | [INFO] [stderr] 50 | (Node::Data(a), Node::Tree(b, next)) => Node::Tree(b.or(Some(a)), next), [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(a))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/prefix_tree.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn iter<'a>(&'a self) -> TreeIterator<'a, T> { [INFO] [stderr] 73 | | TreeIterator { [INFO] [stderr] 74 | | stack: vec![(vec![], 0, &self)], [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/request/params.rs:108:33 [INFO] [stderr] | [INFO] [stderr] 108 | while let Some(param) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for param in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/request/params.rs:169:34 [INFO] [stderr] | [INFO] [stderr] 169 | Some(seg) if seg == &segment => {}, [INFO] [stderr] | ^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `segment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/router.rs:197:43 [INFO] [stderr] | [INFO] [stderr] 197 | while let Some((prefix, route)) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for (prefix, route) in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.13s [INFO] running `"docker" "inspect" "7d76e955d602fe5cadaeea90c6a265d3adc929bfc8c3ffbcfa88dca2fc5ff1d0"` [INFO] running `"docker" "rm" "-f" "7d76e955d602fe5cadaeea90c6a265d3adc929bfc8c3ffbcfa88dca2fc5ff1d0"` [INFO] [stdout] 7d76e955d602fe5cadaeea90c6a265d3adc929bfc8c3ffbcfa88dca2fc5ff1d0