[INFO] crate resol-vbus 0.1.1 is already in cache [INFO] extracting crate resol-vbus 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/resol-vbus/0.1.1 [INFO] extracting crate resol-vbus 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/resol-vbus/0.1.1 [INFO] validating manifest of resol-vbus-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of resol-vbus-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing resol-vbus-0.1.1 [INFO] finished frobbing resol-vbus-0.1.1 [INFO] frobbed toml for resol-vbus-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/resol-vbus/0.1.1/Cargo.toml [INFO] started frobbing resol-vbus-0.1.1 [INFO] finished frobbing resol-vbus-0.1.1 [INFO] frobbed toml for resol-vbus-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/resol-vbus/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting resol-vbus-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/resol-vbus/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9dc80b47751560e70233b31776787f64e9720cceb74227d2c07f6b26e96e20f5 [INFO] running `"docker" "start" "-a" "9dc80b47751560e70233b31776787f64e9720cceb74227d2c07f6b26e96e20f5"` [INFO] [stderr] Checking resol-vbus v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blob_reader.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_reader.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_writer.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | frame_count: frame_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | protocol_version: protocol_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | texts: texts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | localized_texts: localized_texts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `localized_texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | units: units, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | device_templates: device_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | packet_templates: packet_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:607:17 [INFO] [stderr] | [INFO] [stderr] 607 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:608:17 [INFO] [stderr] | [INFO] [stderr] 608 | self_mask: self_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:609:17 [INFO] [stderr] | [INFO] [stderr] 609 | peer_address: peer_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:610:17 [INFO] [stderr] | [INFO] [stderr] 610 | peer_mask: peer_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:636:17 [INFO] [stderr] | [INFO] [stderr] 636 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:637:17 [INFO] [stderr] | [INFO] [stderr] 637 | destination_mask: destination_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:638:17 [INFO] [stderr] | [INFO] [stderr] 638 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:639:17 [INFO] [stderr] | [INFO] [stderr] 639 | source_mask: source_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:640:17 [INFO] [stderr] | [INFO] [stderr] 640 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:641:17 [INFO] [stderr] | [INFO] [stderr] 641 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:677:17 [INFO] [stderr] | [INFO] [stderr] 677 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:679:17 [INFO] [stderr] | [INFO] [stderr] 679 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:694:13 [INFO] [stderr] | [INFO] [stderr] 694 | bit_pos: bit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:697:13 [INFO] [stderr] | [INFO] [stderr] 697 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | device_id: device_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | field_id: field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | packet_field_id: packet_field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:255:21 [INFO] [stderr] | [INFO] [stderr] 255 | unit_family: unit_family, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:256:21 [INFO] [stderr] | [INFO] [stderr] 256 | unit_code: unit_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | packet_id: packet_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | destination_device: destination_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | source_device: source_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | devices: devices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:322:13 [INFO] [stderr] | [INFO] [stderr] 322 | packets: packets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `packets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:662:17 [INFO] [stderr] | [INFO] [stderr] 662 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:663:17 [INFO] [stderr] | [INFO] [stderr] 663 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_list_reader.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | file_list: file_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blob_reader.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_reader.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_writer.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | frame_count: frame_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | protocol_version: protocol_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | texts: texts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | localized_texts: localized_texts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `localized_texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | units: units, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | device_templates: device_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | packet_templates: packet_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:607:17 [INFO] [stderr] | [INFO] [stderr] 607 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:608:17 [INFO] [stderr] | [INFO] [stderr] 608 | self_mask: self_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:609:17 [INFO] [stderr] | [INFO] [stderr] 609 | peer_address: peer_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:610:17 [INFO] [stderr] | [INFO] [stderr] 610 | peer_mask: peer_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:636:17 [INFO] [stderr] | [INFO] [stderr] 636 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:637:17 [INFO] [stderr] | [INFO] [stderr] 637 | destination_mask: destination_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:638:17 [INFO] [stderr] | [INFO] [stderr] 638 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:639:17 [INFO] [stderr] | [INFO] [stderr] 639 | source_mask: source_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:640:17 [INFO] [stderr] | [INFO] [stderr] 640 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:641:17 [INFO] [stderr] | [INFO] [stderr] 641 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:677:17 [INFO] [stderr] | [INFO] [stderr] 677 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:679:17 [INFO] [stderr] | [INFO] [stderr] 679 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:694:13 [INFO] [stderr] | [INFO] [stderr] 694 | bit_pos: bit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:697:13 [INFO] [stderr] | [INFO] [stderr] 697 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | device_id: device_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | field_id: field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | packet_field_id: packet_field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:255:21 [INFO] [stderr] | [INFO] [stderr] 255 | unit_family: unit_family, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:256:21 [INFO] [stderr] | [INFO] [stderr] 256 | unit_code: unit_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | packet_id: packet_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | destination_device: destination_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | source_device: source_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | devices: devices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:322:13 [INFO] [stderr] | [INFO] [stderr] 322 | packets: packets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `packets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:662:17 [INFO] [stderr] | [INFO] [stderr] 662 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:663:17 [INFO] [stderr] | [INFO] [stderr] 663 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_list_reader.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | file_list: file_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | const CRC16_TABLE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blob_reader.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return &self.buf[self.start..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.buf[self.start..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recording_decoder.rs:45:55 [INFO] [stderr] | [INFO] [stderr] 45 | let timestamp_ns = (timestamp_ms % 1000) as u32 * 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:435:63 [INFO] [stderr] | [INFO] [stderr] 435 | let timestamp = UTC.timestamp(raw_value + 978307200, 0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | crc = (crc >> 8) ^ CRC16_TABLE [(crc ^ *byte as u16) as usize & 0xFF]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/data.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Packet(Packet), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 13 | Packet(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/data.rs:57:87 [INFO] [stderr] | [INFO] [stderr] 57 | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | _______________________________________________________________________________________^ [INFO] [stderr] 58 | | false [INFO] [stderr] 59 | | } else if left_header.source_address != right_header.source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/data.rs:55:56 [INFO] [stderr] | [INFO] [stderr] 55 | if left_header.channel != right_header.channel { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 56 | | false [INFO] [stderr] 57 | | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | / if left_packet.command != right_packet.command { [INFO] [stderr] 68 | | false [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | true [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_packet.command != right_packet.command)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | } else if left_dgram.param16 != right_dgram.param16 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 83 | | false [INFO] [stderr] 84 | | } else { [INFO] [stderr] 85 | | true [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_dgram.param16 != right_dgram.param16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | / if left_tgram.command != right_tgram.command { [INFO] [stderr] 94 | | false [INFO] [stderr] 95 | | } else { [INFO] [stderr] 96 | | true [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_tgram.command != right_tgram.command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `data_set::DataSet` [INFO] [stderr] --> src/data_set.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> DataSet { [INFO] [stderr] 19 | | DataSet { [INFO] [stderr] 20 | | timestamp: UTC::now(), [INFO] [stderr] 21 | | set: Vec::new(), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for data_set::DataSet { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:37:67 [INFO] [stderr] | [INFO] [stderr] 37 | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 38 | | Malformed [INFO] [stderr] 39 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:35:49 [INFO] [stderr] | [INFO] [stderr] 35 | } else if has_msb_set(&buf [6..10]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 36 | | Malformed [INFO] [stderr] 37 | | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:63:67 [INFO] [stderr] | [INFO] [stderr] 63 | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 64 | | Malformed [INFO] [stderr] 65 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:61:49 [INFO] [stderr] | [INFO] [stderr] 61 | } else if has_msb_set(&buf [6..16]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 62 | | Malformed [INFO] [stderr] 63 | | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:73:66 [INFO] [stderr] | [INFO] [stderr] 73 | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 74 | | Malformed [INFO] [stderr] 75 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:71:48 [INFO] [stderr] | [INFO] [stderr] 71 | } else if has_msb_set(&buf [6..8]) { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 72 | | Malformed [INFO] [stderr] 73 | | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/live_data_reader.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | let data = if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_writer.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | self.writer.write(&bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:24:34 [INFO] [stderr] | [INFO] [stderr] 24 | } else if buf [2] != buf [4] { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 25 | | Malformed [INFO] [stderr] 26 | | } else if buf [3] != buf [5] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:22:50 [INFO] [stderr] | [INFO] [stderr] 22 | } else if (buf [1] >> 4) != (buf [1] & 0x0F) { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 23 | | Malformed [INFO] [stderr] 24 | | } else if buf [2] != buf [4] { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:90:39 [INFO] [stderr] | [INFO] [stderr] 90 | } else if buf [1] != 0x66 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 91 | | None [INFO] [stderr] 92 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | if length < 20 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 89 | | None [INFO] [stderr] 90 | | } else if buf [1] != 0x66 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_reader.rs:88:45 [INFO] [stderr] | [INFO] [stderr] 88 | } else if bytes [1] == 0x44 { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 89 | | break; [INFO] [stderr] 90 | | } else if bytes [1] == 0x66 { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_reader.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | if length == 0 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 87 | | break; [INFO] [stderr] 88 | | } else if bytes [1] == 0x44 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | pub const LIVE_DATA_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | pub const LIVE_TELEGRAM_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | pub const RECORDING_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:138:35 [INFO] [stderr] | [INFO] [stderr] 138 | pub const LIVE_DATA_RECORDING_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:226:25 [INFO] [stderr] | [INFO] [stderr] 226 | pub const SPEC_FILE_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/specification_file.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / fn slice_entry<'a>(buf: &'a [u8], offset: usize, length: usize) -> &'a [u8] { [INFO] [stderr] 92 | | &buf [offset..(offset + length)] [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/specification_file.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | / fn slice_table_entry<'a>(buf: &'a [u8], offset: usize, length: usize, index: usize) -> &'a [u8] { [INFO] [stderr] 97 | | let table_entry_offset = offset + (index * length); [INFO] [stderr] 98 | | slice_entry(buf, table_entry_offset, length) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | const CRC16_TABLE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blob_reader.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return &self.buf[self.start..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.buf[self.start..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:53:39 [INFO] [stderr] | [INFO] [stderr] 53 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/specification_file.rs:385:26 [INFO] [stderr] | [INFO] [stderr] 385 | let text_index = match language { [INFO] [stderr] | __________________________^ [INFO] [stderr] 386 | | &Language::En => &localized_text.text_index_en, [INFO] [stderr] 387 | | &Language::De => &localized_text.text_index_de, [INFO] [stderr] 388 | | &Language::Fr => &localized_text.text_index_fr, [INFO] [stderr] 389 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 385 | let text_index = match *language { [INFO] [stderr] 386 | Language::En => &localized_text.text_index_en, [INFO] [stderr] 387 | Language::De => &localized_text.text_index_de, [INFO] [stderr] 388 | Language::Fr => &localized_text.text_index_fr, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:90:39 [INFO] [stderr] | [INFO] [stderr] 90 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datagram.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datagram.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | param32: 0x1b1c1d1e, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1b1c_1d1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datagram.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | param32: 0x1b1c1d1e, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1b1c_1d1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datagram.rs:91:39 [INFO] [stderr] | [INFO] [stderr] 91 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datagram.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | param32: 0x1b1c1d1e, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1b1c_1d1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:429:104 [INFO] [stderr] | [INFO] [stderr] 429 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ________________________________________________________________________________________________________^ [INFO] [stderr] 430 | | false [INFO] [stderr] 431 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:427:97 [INFO] [stderr] | [INFO] [stderr] 427 | if ((device_template.self_address ^ self_address) & device_template.self_mask) != 0 { [INFO] [stderr] | _________________________________________________________________________________________________^ [INFO] [stderr] 428 | | false [INFO] [stderr] 429 | | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:429:20 [INFO] [stderr] | [INFO] [stderr] 429 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 430 | | false [INFO] [stderr] 431 | | } else { [INFO] [stderr] 432 | | true [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/telegram.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:442:110 [INFO] [stderr] | [INFO] [stderr] 442 | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________^ [INFO] [stderr] 443 | | false [INFO] [stderr] 444 | | } else if packet_template.command != command { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:440:118 [INFO] [stderr] | [INFO] [stderr] 440 | if ((packet_template.destination_address ^ destination_address) & packet_template.destination_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________________^ [INFO] [stderr] 441 | | false [INFO] [stderr] 442 | | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/telegram.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:444:20 [INFO] [stderr] | [INFO] [stderr] 444 | } else if packet_template.command != command { [INFO] [stderr] | ____________________^ [INFO] [stderr] 445 | | false [INFO] [stderr] 446 | | } else { [INFO] [stderr] 447 | | true [INFO] [stderr] 448 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(packet_template.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/telegram.rs:124:39 [INFO] [stderr] | [INFO] [stderr] 124 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:198:39 [INFO] [stderr] | [INFO] [stderr] 198 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:231:39 [INFO] [stderr] | [INFO] [stderr] 231 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:366:39 [INFO] [stderr] | [INFO] [stderr] 366 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:94:39 [INFO] [stderr] | [INFO] [stderr] 94 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/specification.rs:118:36 [INFO] [stderr] | [INFO] [stderr] 118 | fn get_cached_device_spec(devices: &Vec>, channel: u8, self_address: u16, peer_address: u16) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:122:55 [INFO] [stderr] | [INFO] [stderr] 122 | } else if device.self_address != self_address { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 123 | | false [INFO] [stderr] 124 | | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:120:38 [INFO] [stderr] | [INFO] [stderr] 120 | if device.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 121 | | false [INFO] [stderr] 122 | | } else if device.self_address != self_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | ________________^ [INFO] [stderr] 125 | | false [INFO] [stderr] 126 | | } else { [INFO] [stderr] 127 | | true [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(device.peer_address.is_some() && device.peer_address.unwrap() != peer_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:145:39 [INFO] [stderr] | [INFO] [stderr] 145 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:167:39 [INFO] [stderr] | [INFO] [stderr] 167 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:185:39 [INFO] [stderr] | [INFO] [stderr] 185 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/specification.rs:144:39 [INFO] [stderr] | [INFO] [stderr] 144 | Some(device_template) => Some(device_template.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 144 | Some(device_template) => Some(&(*device_template).clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 144 | Some(device_template) => Some(&specification_file::DeviceTemplate::clone(device_template)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/specification.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / match language { [INFO] [stderr] 165 | | &Language::En => format!("Unknown device 0x{:04X}", self_address), [INFO] [stderr] 166 | | &Language::De => format!("Unbekanntes Gerät 0x{:04X}", self_address), [INFO] [stderr] 167 | | &Language::Fr => format!("Unknown device 0x{:04X}", self_address), // FIXME(daniel): missing translation [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 164 | match *language { [INFO] [stderr] 165 | Language::En => format!("Unknown device 0x{:04X}", self_address), [INFO] [stderr] 166 | Language::De => format!("Unbekanntes Gerät 0x{:04X}", self_address), [INFO] [stderr] 167 | Language::Fr => format!("Unknown device 0x{:04X}", self_address), // FIXME(daniel): missing translation [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/specification.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | fn get_cached_packet_spec(packets: &Vec>, channel: u8, destination_address: u16, source_address: u16, command: u16) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:199:69 [INFO] [stderr] | [INFO] [stderr] 199 | } else if packet.destination_address != destination_address { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 200 | | false [INFO] [stderr] 201 | | } else if packet.source_address != source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:197:38 [INFO] [stderr] | [INFO] [stderr] 197 | if packet.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 198 | | false [INFO] [stderr] 199 | | } else if packet.destination_address != destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | } else if packet.command != command { [INFO] [stderr] | ________________^ [INFO] [stderr] 204 | | false [INFO] [stderr] 205 | | } else { [INFO] [stderr] 206 | | true [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(packet.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/specification.rs:217:1 [INFO] [stderr] | [INFO] [stderr] 217 | / fn get_or_create_cached_packet_spec(packets: &mut Vec>, channel: u8, destination_address: u16, source_address: u16, command: u16, devices: &mut Vec>, file: &SpecificationFile, language: &Language) -> Arc { [INFO] [stderr] 218 | | if let Some(packet) = get_cached_packet_spec(packets, channel, destination_address, source_address, command) { [INFO] [stderr] 219 | | return packet; [INFO] [stderr] 220 | | } [INFO] [stderr] ... | [INFO] [stderr] 280 | | get_cached_packet_spec(packets, channel, destination_address, source_address, command).unwrap() [INFO] [stderr] 281 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_decoder.rs:229:39 [INFO] [stderr] | [INFO] [stderr] 229 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_encoder.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_encoder.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_writer.rs:54:39 [INFO] [stderr] | [INFO] [stderr] 54 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recording_decoder.rs:45:55 [INFO] [stderr] | [INFO] [stderr] 45 | let timestamp_ns = (timestamp_ms % 1000) as u32 * 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:306:27 [INFO] [stderr] | [INFO] [stderr] 306 | _ => 10.0f64.powf(n as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | (buf [offset] as i8) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((buf [offset] as i8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | buf [offset] as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf [offset])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:371:35 [INFO] [stderr] | [INFO] [stderr] 371 | part_value &= part.mask as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(part.mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/specification.rs:397:5 [INFO] [stderr] | [INFO] [stderr] 397 | / pub fn fmt_raw_value<'a>(&'a self, raw_value: Option, append_unit: bool) -> PacketFieldFormatter<'a> { [INFO] [stderr] 398 | | let unit_text = if append_unit { [INFO] [stderr] 399 | | &self.unit_text [INFO] [stderr] 400 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1086:43 [INFO] [stderr] | [INFO] [stderr] 1086 | check_next_part(3, 0, 0xFF, true, 16777216); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1087:45 [INFO] [stderr] | [INFO] [stderr] 1087 | check_next_part(36, 0, 0xFF, false, 1000000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1088:45 [INFO] [stderr] | [INFO] [stderr] 1088 | check_next_part(37, 0, 0xFF, false, 256000000000); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `256_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1089:45 [INFO] [stderr] | [INFO] [stderr] 1089 | check_next_part(38, 0, 0xFF, false, 65536000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `65_536_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1090:44 [INFO] [stderr] | [INFO] [stderr] 1090 | check_next_part(39, 0, 0xFF, true, 16777216000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `16_777_216_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: Could not compile `resol-vbus`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:435:63 [INFO] [stderr] | [INFO] [stderr] 435 | let timestamp = UTC.timestamp(raw_value + 978307200, 0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:617:25 [INFO] [stderr] | [INFO] [stderr] 617 | assert_eq!(Some(0x12345678), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_i64(buf)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:620:25 [INFO] [stderr] | [INFO] [stderr] 620 | assert_eq!(Some(0x345678), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_i64(&buf [0..3])); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0034_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:642:25 [INFO] [stderr] | [INFO] [stderr] 642 | assert_eq!(Some(0x12345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:643:25 [INFO] [stderr] | [INFO] [stderr] 643 | assert_eq!(Some(888.8000000000001), packet_spec.get_field_spec("004_4_0").unwrap().get_raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `888.800_000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:644:26 [INFO] [stderr] | [INFO] [stderr] 644 | assert_eq!(Some(-888.8000000000001), packet_spec.get_field_spec("008_4_0").unwrap().get_raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `888.800_000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:645:25 [INFO] [stderr] | [INFO] [stderr] 645 | assert_eq!(Some(0x345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_f64(&buf [0..3])); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0034_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:692:63 [INFO] [stderr] | [INFO] [stderr] 692 | assert_eq!("1.2345678900", fmt_raw_value(&field_spec, 1.23456789, false)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1.234_567_89` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:701:70 [INFO] [stderr] | [INFO] [stderr] 701 | assert_eq!("2013-12-22 15:17:42", fmt_raw_value(&field_spec, 409418262.0, true)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `409_418_262.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | crc = (crc >> 8) ^ CRC16_TABLE [(crc ^ *byte as u16) as usize & 0xFF]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/data.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Packet(Packet), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 13 | Packet(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/data.rs:57:87 [INFO] [stderr] | [INFO] [stderr] 57 | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | _______________________________________________________________________________________^ [INFO] [stderr] 58 | | false [INFO] [stderr] 59 | | } else if left_header.source_address != right_header.source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/data.rs:55:56 [INFO] [stderr] | [INFO] [stderr] 55 | if left_header.channel != right_header.channel { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 56 | | false [INFO] [stderr] 57 | | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | / if left_packet.command != right_packet.command { [INFO] [stderr] 68 | | false [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | true [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_packet.command != right_packet.command)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | } else if left_dgram.param16 != right_dgram.param16 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 83 | | false [INFO] [stderr] 84 | | } else { [INFO] [stderr] 85 | | true [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_dgram.param16 != right_dgram.param16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | / if left_tgram.command != right_tgram.command { [INFO] [stderr] 94 | | false [INFO] [stderr] 95 | | } else { [INFO] [stderr] 96 | | true [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_tgram.command != right_tgram.command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/data.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | / fn test_eq() { [INFO] [stderr] 231 | | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] 232 | | let channel = 0x11; [INFO] [stderr] 233 | | [INFO] [stderr] ... | [INFO] [stderr] 361 | | assert_eq!(true, Data::Telegram(other).eq(&tgram_data)); [INFO] [stderr] 362 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 48 [INFO] [stderr] --> src/data.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | / fn test_partial_cmp() { [INFO] [stderr] 366 | | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] 367 | | let channel = 0x11; [INFO] [stderr] 368 | | [INFO] [stderr] ... | [INFO] [stderr] 556 | | assert_eq!(Some(Equal), Data::Telegram(other).partial_cmp(&tgram_data)); [INFO] [stderr] 557 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `data_set::DataSet` [INFO] [stderr] --> src/data_set.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> DataSet { [INFO] [stderr] 19 | | DataSet { [INFO] [stderr] 20 | | timestamp: UTC::now(), [INFO] [stderr] 21 | | set: Vec::new(), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for data_set::DataSet { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:37:67 [INFO] [stderr] | [INFO] [stderr] 37 | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 38 | | Malformed [INFO] [stderr] 39 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:35:49 [INFO] [stderr] | [INFO] [stderr] 35 | } else if has_msb_set(&buf [6..10]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 36 | | Malformed [INFO] [stderr] 37 | | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:63:67 [INFO] [stderr] | [INFO] [stderr] 63 | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 64 | | Malformed [INFO] [stderr] 65 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:61:49 [INFO] [stderr] | [INFO] [stderr] 61 | } else if has_msb_set(&buf [6..16]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 62 | | Malformed [INFO] [stderr] 63 | | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:73:66 [INFO] [stderr] | [INFO] [stderr] 73 | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 74 | | Malformed [INFO] [stderr] 75 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:71:48 [INFO] [stderr] | [INFO] [stderr] 71 | } else if has_msb_set(&buf [6..8]) { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 72 | | Malformed [INFO] [stderr] 73 | | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/live_data_decoder.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / fn test_length_from_bytes() { [INFO] [stderr] 186 | | // version independent [INFO] [stderr] 187 | | assert_eq!(Partial, length_from_bytes(&[])); [INFO] [stderr] 188 | | assert_eq!(Malformed, length_from_bytes(&[ 0x00 ])); [INFO] [stderr] ... | [INFO] [stderr] 224 | | assert_eq!(BlobLength(17), length_from_bytes(&LIVE_TELEGRAM_1 [0..])); [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/live_data_reader.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | let data = if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_writer.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | self.writer.write(&bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:24:34 [INFO] [stderr] | [INFO] [stderr] 24 | } else if buf [2] != buf [4] { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 25 | | Malformed [INFO] [stderr] 26 | | } else if buf [3] != buf [5] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:22:50 [INFO] [stderr] | [INFO] [stderr] 22 | } else if (buf [1] >> 4) != (buf [1] & 0x0F) { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 23 | | Malformed [INFO] [stderr] 24 | | } else if buf [2] != buf [4] { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:90:39 [INFO] [stderr] | [INFO] [stderr] 90 | } else if buf [1] != 0x66 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 91 | | None [INFO] [stderr] 92 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | if length < 20 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 89 | | None [INFO] [stderr] 90 | | } else if buf [1] != 0x66 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_reader.rs:88:45 [INFO] [stderr] | [INFO] [stderr] 88 | } else if bytes [1] == 0x44 { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 89 | | break; [INFO] [stderr] 90 | | } else if bytes [1] == 0x66 { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_reader.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | if length == 0 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 87 | | break; [INFO] [stderr] 88 | | } else if bytes [1] == 0x44 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/specification_file.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / fn slice_entry<'a>(buf: &'a [u8], offset: usize, length: usize) -> &'a [u8] { [INFO] [stderr] 92 | | &buf [offset..(offset + length)] [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/specification_file.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | / fn slice_table_entry<'a>(buf: &'a [u8], offset: usize, length: usize, index: usize) -> &'a [u8] { [INFO] [stderr] 97 | | let table_entry_offset = offset + (index * length); [INFO] [stderr] 98 | | slice_entry(buf, table_entry_offset, length) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/specification_file.rs:385:26 [INFO] [stderr] | [INFO] [stderr] 385 | let text_index = match language { [INFO] [stderr] | __________________________^ [INFO] [stderr] 386 | | &Language::En => &localized_text.text_index_en, [INFO] [stderr] 387 | | &Language::De => &localized_text.text_index_de, [INFO] [stderr] 388 | | &Language::Fr => &localized_text.text_index_fr, [INFO] [stderr] 389 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 385 | let text_index = match *language { [INFO] [stderr] 386 | Language::En => &localized_text.text_index_en, [INFO] [stderr] 387 | Language::De => &localized_text.text_index_de, [INFO] [stderr] 388 | Language::Fr => &localized_text.text_index_fr, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:429:104 [INFO] [stderr] | [INFO] [stderr] 429 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ________________________________________________________________________________________________________^ [INFO] [stderr] 430 | | false [INFO] [stderr] 431 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:427:97 [INFO] [stderr] | [INFO] [stderr] 427 | if ((device_template.self_address ^ self_address) & device_template.self_mask) != 0 { [INFO] [stderr] | _________________________________________________________________________________________________^ [INFO] [stderr] 428 | | false [INFO] [stderr] 429 | | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:429:20 [INFO] [stderr] | [INFO] [stderr] 429 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 430 | | false [INFO] [stderr] 431 | | } else { [INFO] [stderr] 432 | | true [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:442:110 [INFO] [stderr] | [INFO] [stderr] 442 | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________^ [INFO] [stderr] 443 | | false [INFO] [stderr] 444 | | } else if packet_template.command != command { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:440:118 [INFO] [stderr] | [INFO] [stderr] 440 | if ((packet_template.destination_address ^ destination_address) & packet_template.destination_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________________^ [INFO] [stderr] 441 | | false [INFO] [stderr] 442 | | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:444:20 [INFO] [stderr] | [INFO] [stderr] 444 | } else if packet_template.command != command { [INFO] [stderr] | ____________________^ [INFO] [stderr] 445 | | false [INFO] [stderr] 446 | | } else { [INFO] [stderr] 447 | | true [INFO] [stderr] 448 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(packet_template.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/specification_file.rs:710:5 [INFO] [stderr] | [INFO] [stderr] 710 | / fn check_spec_file_fixture(spec_file: &SpecificationFile) { [INFO] [stderr] 711 | | let mut text_index = 0; [INFO] [stderr] 712 | | [INFO] [stderr] 713 | | let mut check_next_text = |ref_text| { [INFO] [stderr] ... | [INFO] [stderr] 1090 | | check_next_part(39, 0, 0xFF, true, 16777216000000000); [INFO] [stderr] 1091 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/specification.rs:118:36 [INFO] [stderr] | [INFO] [stderr] 118 | fn get_cached_device_spec(devices: &Vec>, channel: u8, self_address: u16, peer_address: u16) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:122:55 [INFO] [stderr] | [INFO] [stderr] 122 | } else if device.self_address != self_address { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 123 | | false [INFO] [stderr] 124 | | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:120:38 [INFO] [stderr] | [INFO] [stderr] 120 | if device.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 121 | | false [INFO] [stderr] 122 | | } else if device.self_address != self_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | ________________^ [INFO] [stderr] 125 | | false [INFO] [stderr] 126 | | } else { [INFO] [stderr] 127 | | true [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(device.peer_address.is_some() && device.peer_address.unwrap() != peer_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/specification.rs:144:39 [INFO] [stderr] | [INFO] [stderr] 144 | Some(device_template) => Some(device_template.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 144 | Some(device_template) => Some(&(*device_template).clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 144 | Some(device_template) => Some(&specification_file::DeviceTemplate::clone(device_template)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/specification.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / match language { [INFO] [stderr] 165 | | &Language::En => format!("Unknown device 0x{:04X}", self_address), [INFO] [stderr] 166 | | &Language::De => format!("Unbekanntes Gerät 0x{:04X}", self_address), [INFO] [stderr] 167 | | &Language::Fr => format!("Unknown device 0x{:04X}", self_address), // FIXME(daniel): missing translation [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 164 | match *language { [INFO] [stderr] 165 | Language::En => format!("Unknown device 0x{:04X}", self_address), [INFO] [stderr] 166 | Language::De => format!("Unbekanntes Gerät 0x{:04X}", self_address), [INFO] [stderr] 167 | Language::Fr => format!("Unknown device 0x{:04X}", self_address), // FIXME(daniel): missing translation [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/specification.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | fn get_cached_packet_spec(packets: &Vec>, channel: u8, destination_address: u16, source_address: u16, command: u16) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:199:69 [INFO] [stderr] | [INFO] [stderr] 199 | } else if packet.destination_address != destination_address { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 200 | | false [INFO] [stderr] 201 | | } else if packet.source_address != source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:197:38 [INFO] [stderr] | [INFO] [stderr] 197 | if packet.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 198 | | false [INFO] [stderr] 199 | | } else if packet.destination_address != destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | } else if packet.command != command { [INFO] [stderr] | ________________^ [INFO] [stderr] 204 | | false [INFO] [stderr] 205 | | } else { [INFO] [stderr] 206 | | true [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(packet.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/specification.rs:217:1 [INFO] [stderr] | [INFO] [stderr] 217 | / fn get_or_create_cached_packet_spec(packets: &mut Vec>, channel: u8, destination_address: u16, source_address: u16, command: u16, devices: &mut Vec>, file: &SpecificationFile, language: &Language) -> Arc { [INFO] [stderr] 218 | | if let Some(packet) = get_cached_packet_spec(packets, channel, destination_address, source_address, command) { [INFO] [stderr] 219 | | return packet; [INFO] [stderr] 220 | | } [INFO] [stderr] ... | [INFO] [stderr] 280 | | get_cached_packet_spec(packets, channel, destination_address, source_address, command).unwrap() [INFO] [stderr] 281 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:306:27 [INFO] [stderr] | [INFO] [stderr] 306 | _ => 10.0f64.powf(n as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | (buf [offset] as i8) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((buf [offset] as i8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | buf [offset] as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf [offset])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:371:35 [INFO] [stderr] | [INFO] [stderr] 371 | part_value &= part.mask as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(part.mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/specification.rs:397:5 [INFO] [stderr] | [INFO] [stderr] 397 | / pub fn fmt_raw_value<'a>(&'a self, raw_value: Option, append_unit: bool) -> PacketFieldFormatter<'a> { [INFO] [stderr] 398 | | let unit_text = if append_unit { [INFO] [stderr] 399 | | &self.unit_text [INFO] [stderr] 400 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:456:37 [INFO] [stderr] | [INFO] [stderr] 456 | assert_eq!(10.0f64.powf(n as f64), get_power_of_ten(n)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/specification.rs:456:13 [INFO] [stderr] | [INFO] [stderr] 456 | assert_eq!(10.0f64.powf(n as f64), get_power_of_ten(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/specification.rs:456:13 [INFO] [stderr] | [INFO] [stderr] 456 | assert_eq!(10.0f64.powf(n as f64), get_power_of_ten(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/specification.rs:512:5 [INFO] [stderr] | [INFO] [stderr] 512 | / fn test_get_packet_spec() { [INFO] [stderr] 513 | | let spec_file = SpecificationFile::from_bytes(SPEC_FILE_1).unwrap(); [INFO] [stderr] 514 | | [INFO] [stderr] 515 | | let spec = Specification::from_file(spec_file, Language::En); [INFO] [stderr] ... | [INFO] [stderr] 573 | | assert_eq!(0, packet_spec.fields.len()); [INFO] [stderr] 574 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:642:25 [INFO] [stderr] | [INFO] [stderr] 642 | assert_eq!(Some(0x12345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(0x12345678)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:645:25 [INFO] [stderr] | [INFO] [stderr] 645 | assert_eq!(Some(0x345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_f64(&buf [0..3])); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(0x345678)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:646:25 [INFO] [stderr] | [INFO] [stderr] 646 | assert_eq!(Some(0x5678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_f64(&buf [0..2])); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(0x5678)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:647:25 [INFO] [stderr] | [INFO] [stderr] 647 | assert_eq!(Some(0x78 as f64), packet_spec.get_field_spec("000_4_0").unwrap().get_raw_value_f64(&buf [0..1])); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(0x78)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 14 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `resol-vbus`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9dc80b47751560e70233b31776787f64e9720cceb74227d2c07f6b26e96e20f5"` [INFO] running `"docker" "rm" "-f" "9dc80b47751560e70233b31776787f64e9720cceb74227d2c07f6b26e96e20f5"` [INFO] [stdout] 9dc80b47751560e70233b31776787f64e9720cceb74227d2c07f6b26e96e20f5