[INFO] crate reroute 0.3.2 is already in cache [INFO] extracting crate reroute 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/reroute/0.3.2 [INFO] extracting crate reroute 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reroute/0.3.2 [INFO] validating manifest of reroute-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reroute-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reroute-0.3.2 [INFO] finished frobbing reroute-0.3.2 [INFO] frobbed toml for reroute-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/reroute/0.3.2/Cargo.toml [INFO] started frobbing reroute-0.3.2 [INFO] finished frobbing reroute-0.3.2 [INFO] frobbed toml for reroute-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reroute/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reroute-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reroute/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a4f87c329537cb91e78228436467987fbe4c87b91a0e93e3856dbfe03d9ef1a [INFO] running `"docker" "start" "-a" "8a4f87c329537cb91e78228436467987fbe4c87b91a0e93e3856dbfe03d9ef1a"` [INFO] [stderr] Checking reroute v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let ref regex = self.patterns[index]; [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let regex = &self.patterns[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RouterBuilder` [INFO] [stderr] --> src/lib.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / pub fn new() -> RouterBuilder { [INFO] [stderr] 67 | | RouterBuilder { [INFO] [stderr] 68 | | routes: vec![], [INFO] [stderr] 69 | | handlers: vec![], [INFO] [stderr] 70 | | not_found: None, [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let ref regex = self.patterns[index]; [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let regex = &self.patterns[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RouterBuilder` [INFO] [stderr] --> src/lib.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / pub fn new() -> RouterBuilder { [INFO] [stderr] 67 | | RouterBuilder { [INFO] [stderr] 68 | | routes: vec![], [INFO] [stderr] 69 | | handlers: vec![], [INFO] [stderr] 70 | | not_found: None, [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.72s [INFO] running `"docker" "inspect" "8a4f87c329537cb91e78228436467987fbe4c87b91a0e93e3856dbfe03d9ef1a"` [INFO] running `"docker" "rm" "-f" "8a4f87c329537cb91e78228436467987fbe4c87b91a0e93e3856dbfe03d9ef1a"` [INFO] [stdout] 8a4f87c329537cb91e78228436467987fbe4c87b91a0e93e3856dbfe03d9ef1a