[INFO] crate reproto-server 0.3.36 is already in cache [INFO] extracting crate reproto-server 0.3.36 into work/ex/clippy-test-run/sources/stable/reg/reproto-server/0.3.36 [INFO] extracting crate reproto-server 0.3.36 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-server/0.3.36 [INFO] validating manifest of reproto-server-0.3.36 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reproto-server-0.3.36 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reproto-server-0.3.36 [INFO] finished frobbing reproto-server-0.3.36 [INFO] frobbed toml for reproto-server-0.3.36 written to work/ex/clippy-test-run/sources/stable/reg/reproto-server/0.3.36/Cargo.toml [INFO] started frobbing reproto-server-0.3.36 [INFO] finished frobbing reproto-server-0.3.36 [INFO] frobbed toml for reproto-server-0.3.36 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-server/0.3.36/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reproto-server-0.3.36 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reproto-server/0.3.36:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 452b69bd209a23e4c8050b7cc0b4530800380e4d53993f3621d580304ff3d272 [INFO] running `"docker" "start" "-a" "452b69bd209a23e4c8050b7cc0b4530800380e4d53993f3621d580304ff3d272"` [INFO] [stderr] Checking ropey v0.6.3 [INFO] [stderr] Checking serde_test v1.0.85 [INFO] [stderr] Checking reproto-semver v0.3.36 [INFO] [stderr] Checking relative-path v0.3.7 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking pretty_env_logger v0.1.1 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Checking reproto-core v0.3.36 [INFO] [stderr] Checking reproto-repository v0.3.36 [INFO] [stderr] Checking reproto-server v0.3.36 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | 10000000u64 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reproto_service.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | const CHECKSUM_MISMATCH: &'static str = "checksum mismatch"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reproto_service.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | const BAD_OBJECT_ID: &'static str = "bad object id"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reproto_service.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | / return Response::new() [INFO] [stderr] 203 | | .with_status(StatusCode::BadRequest) [INFO] [stderr] 204 | | .with_header(ContentLength(message.len() as u64)) [INFO] [stderr] 205 | | .with_header(ContentType(mime::TEXT_PLAIN)) [INFO] [stderr] 206 | | .with_body(message) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 202 | Response::new() [INFO] [stderr] 203 | .with_status(StatusCode::BadRequest) [INFO] [stderr] 204 | .with_header(ContentLength(message.len() as u64)) [INFO] [stderr] 205 | .with_header(ContentType(mime::TEXT_PLAIN)) [INFO] [stderr] 206 | .with_body(message) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reproto_service.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | return Response::new().with_status(StatusCode::InternalServerError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::new().with_status(StatusCode::InternalServerError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | 10000000u64 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reproto_service.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | const CHECKSUM_MISMATCH: &'static str = "checksum mismatch"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reproto_service.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | const BAD_OBJECT_ID: &'static str = "bad object id"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reproto_service.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | / return Response::new() [INFO] [stderr] 203 | | .with_status(StatusCode::BadRequest) [INFO] [stderr] 204 | | .with_header(ContentLength(message.len() as u64)) [INFO] [stderr] 205 | | .with_header(ContentType(mime::TEXT_PLAIN)) [INFO] [stderr] 206 | | .with_body(message) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 202 | Response::new() [INFO] [stderr] 203 | .with_status(StatusCode::BadRequest) [INFO] [stderr] 204 | .with_header(ContentLength(message.len() as u64)) [INFO] [stderr] 205 | .with_header(ContentType(mime::TEXT_PLAIN)) [INFO] [stderr] 206 | .with_body(message) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reproto_service.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | return Response::new().with_status(StatusCode::InternalServerError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::new().with_status(StatusCode::InternalServerError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/reproto_service.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if h.0 [INFO] [stderr] | ________________^ [INFO] [stderr] 48 | | .iter() [INFO] [stderr] 49 | | .find(|encoding| **encoding == Encoding::Gzip) [INFO] [stderr] 50 | | .is_some() [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|encoding| **encoding == Encoding::Gzip).is_some()` with `any(|encoding| **encoding == Encoding::Gzip)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reproto_service.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | return Err(Error::BadRequest("file too large".into()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::BadRequest("file too large".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reproto_service.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | return Err(Error::BadRequest("missing content-length".into()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::BadRequest("missing content-length".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | max_file_size: max_file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_file_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/reproto_service.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if h.0 [INFO] [stderr] | ________________^ [INFO] [stderr] 48 | | .iter() [INFO] [stderr] 49 | | .find(|encoding| **encoding == Encoding::Gzip) [INFO] [stderr] 50 | | .is_some() [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|encoding| **encoding == Encoding::Gzip).is_some()` with `any(|encoding| **encoding == Encoding::Gzip)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reproto_service.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | return Err(Error::BadRequest("file too large".into()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::BadRequest("file too large".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reproto_service.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | return Err(Error::BadRequest("missing content-length".into()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::BadRequest("missing content-length".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | max_file_size: max_file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_file_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => return Err(e.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => return Err(e.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.92s [INFO] running `"docker" "inspect" "452b69bd209a23e4c8050b7cc0b4530800380e4d53993f3621d580304ff3d272"` [INFO] running `"docker" "rm" "-f" "452b69bd209a23e4c8050b7cc0b4530800380e4d53993f3621d580304ff3d272"` [INFO] [stdout] 452b69bd209a23e4c8050b7cc0b4530800380e4d53993f3621d580304ff3d272