[INFO] crate reproto-repository 0.3.36 is already in cache
[INFO] extracting crate reproto-repository 0.3.36 into work/ex/clippy-test-run/sources/stable/reg/reproto-repository/0.3.36
[INFO] extracting crate reproto-repository 0.3.36 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-repository/0.3.36
[INFO] validating manifest of reproto-repository-0.3.36 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of reproto-repository-0.3.36 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing reproto-repository-0.3.36
[INFO] finished frobbing reproto-repository-0.3.36
[INFO] frobbed toml for reproto-repository-0.3.36 written to work/ex/clippy-test-run/sources/stable/reg/reproto-repository/0.3.36/Cargo.toml
[INFO] started frobbing reproto-repository-0.3.36
[INFO] finished frobbing reproto-repository-0.3.36
[INFO] frobbed toml for reproto-repository-0.3.36 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-repository/0.3.36/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting reproto-repository-0.3.36 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reproto-repository/0.3.36:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5681f65885a5e6ff33e3badeefac11469c5e90d2dddc13f5dc73f76350e316cc
[INFO] running `"docker" "start" "-a" "5681f65885a5e6ff33e3badeefac11469c5e90d2dddc13f5dc73f76350e316cc"`
[INFO] [stderr]     Checking ropey v0.6.3
[INFO] [stderr]     Checking serde_test v1.0.85
[INFO] [stderr]     Checking reproto-semver v0.3.36
[INFO] [stderr]     Checking relative-path v0.3.7
[INFO] [stderr]     Checking toml v0.4.10
[INFO] [stderr]     Checking num-bigint v0.1.44
[INFO] [stderr]     Checking linked-hash-map v0.5.1
[INFO] [stderr]     Checking reproto-core v0.3.36
[INFO] [stderr]     Checking reproto-repository v0.3.36 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/checksum.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 |         Checksum { bytes: bytes }
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/checksum.rs:28:23
[INFO] [stderr]    |
[INFO] [stderr] 28 |         Ok(Checksum { bytes: bytes })
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/git/git_repo.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             git_command: git_command,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `git_command`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/git/git_repo.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             git_command: git_command,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `git_command`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index/file_index.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index/mod.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             version: version,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index/mod.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             object: object,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `object`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/objects/cached_objects.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             objects_cache: objects_cache,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `objects_cache`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/objects/cached_objects.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             missing_cache_time: missing_cache_time,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `missing_cache_time`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/objects/cached_objects.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             inner: inner,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/repository.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             index: index,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/repository.rs:18:13
[INFO] [stderr]    |
[INFO] [stderr] 18 |             objects: objects,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `objects`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/resolver/paths.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             paths: paths,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `paths`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/resolver/paths.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             published: published,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `published`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/resolver/paths.rs:155:13
[INFO] [stderr]     |
[INFO] [stderr] 155 |             package: package,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `package`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/resolver/resolvers.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             resolvers: resolvers,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolvers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/checksum.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 |         Checksum { bytes: bytes }
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/checksum.rs:28:23
[INFO] [stderr]    |
[INFO] [stderr] 28 |         Ok(Checksum { bytes: bytes })
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/git/git_repo.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             git_command: git_command,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `git_command`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/git/git_repo.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             git_command: git_command,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `git_command`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index/file_index.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index/mod.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             version: version,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index/mod.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             object: object,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `object`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/objects/cached_objects.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             objects_cache: objects_cache,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `objects_cache`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/objects/cached_objects.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             missing_cache_time: missing_cache_time,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `missing_cache_time`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/objects/cached_objects.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             inner: inner,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/repository.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             index: index,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/repository.rs:18:13
[INFO] [stderr]    |
[INFO] [stderr] 18 |             objects: objects,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `objects`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/resolver/paths.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             paths: paths,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `paths`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/resolver/paths.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             published: published,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `published`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/resolver/paths.rs:155:13
[INFO] [stderr]     |
[INFO] [stderr] 155 |             package: package,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `package`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/resolver/resolvers.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             resolvers: resolvers,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolvers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/git/git_repo.rs:11:21
[INFO] [stderr]    |
[INFO] [stderr] 11 | const GIT_BIN_ENV: &'static str = "REPROTO_GIT_BIN";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/git/git_repo.rs:12:20
[INFO] [stderr]    |
[INFO] [stderr] 12 | const FETCH_HEAD: &'static str = "FETCH_HEAD";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/git/git_repo.rs:16:37
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub const DEFAULT_GIT_COMMAND: &'static str = "git";
[INFO] [stderr]    |                                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/git/mod.rs:9:28
[INFO] [stderr]   |
[INFO] [stderr] 9 | const DEFAULT_REMOTE_REF: &'static str = "refs/heads/master";
[INFO] [stderr]   |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/index/file_index.rs:13:25
[INFO] [stderr]    |
[INFO] [stderr] 13 | const DEFAULT_OBJECTS: &'static str = "./objects";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/index/file_index.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 | const CONFIG_JSON: &'static str = "config.json";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/index/file_index.rs:17:23
[INFO] [stderr]    |
[INFO] [stderr] 17 | const METADATA_JSON: &'static str = "metadata.json";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/index/file_index.rs:200:9
[INFO] [stderr]     |
[INFO] [stderr] 200 | /         if other_match {
[INFO] [stderr] 201 | |             if !force {
[INFO] [stderr] 202 | |                 return Err(format!("{}@{}: already published", package, version).into());
[INFO] [stderr] 203 | |             }
[INFO] [stderr] 204 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 200 |         if other_match && !force {
[INFO] [stderr] 201 |     return Err(format!("{}@{}: already published", package, version).into());
[INFO] [stderr] 202 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/objects/cached_objects.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 |         return Ok(None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/objects/file_objects.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return Ok(true);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/git/git_repo.rs:11:21
[INFO] [stderr]    |
[INFO] [stderr] 11 | const GIT_BIN_ENV: &'static str = "REPROTO_GIT_BIN";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/git/git_repo.rs:12:20
[INFO] [stderr]    |
[INFO] [stderr] 12 | const FETCH_HEAD: &'static str = "FETCH_HEAD";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/git/git_repo.rs:16:37
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub const DEFAULT_GIT_COMMAND: &'static str = "git";
[INFO] [stderr]    |                                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/git/mod.rs:9:28
[INFO] [stderr]   |
[INFO] [stderr] 9 | const DEFAULT_REMOTE_REF: &'static str = "refs/heads/master";
[INFO] [stderr]   |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/index/file_index.rs:13:25
[INFO] [stderr]    |
[INFO] [stderr] 13 | const DEFAULT_OBJECTS: &'static str = "./objects";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/index/file_index.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 | const CONFIG_JSON: &'static str = "config.json";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/index/file_index.rs:17:23
[INFO] [stderr]    |
[INFO] [stderr] 17 | const METADATA_JSON: &'static str = "metadata.json";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/index/file_index.rs:200:9
[INFO] [stderr]     |
[INFO] [stderr] 200 | /         if other_match {
[INFO] [stderr] 201 | |             if !force {
[INFO] [stderr] 202 | |                 return Err(format!("{}@{}: already published", package, version).into());
[INFO] [stderr] 203 | |             }
[INFO] [stderr] 204 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 200 |         if other_match && !force {
[INFO] [stderr] 201 |     return Err(format!("{}@{}: already published", package, version).into());
[INFO] [stderr] 202 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/objects/cached_objects.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 |         return Ok(None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/objects/file_objects.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return Ok(true);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/checksum.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn from_str(input: &str) -> Result<Checksum> {
[INFO] [stderr] 22 | |         let bytes: Vec<u8> = FromHex::from_hex(input)?;
[INFO] [stderr] 23 | |
[INFO] [stderr] 24 | |         if bytes.len() != 32usize {
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         Ok(Checksum { bytes: bytes })
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/git/git_repo.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 | /     match env::var(GIT_BIN_ENV) {
[INFO] [stderr] 142 | |         Ok(git_bin) => return Ok(git_bin.to_owned()),
[INFO] [stderr] 143 | |         Err(_) => {}
[INFO] [stderr] 144 | |     };
[INFO] [stderr]     | |_____^ help: try this: `if let Ok(git_bin) = env::var(GIT_BIN_ENV) { return Ok(git_bin.to_owned()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/checksum.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn from_str(input: &str) -> Result<Checksum> {
[INFO] [stderr] 22 | |         let bytes: Vec<u8> = FromHex::from_hex(input)?;
[INFO] [stderr] 23 | |
[INFO] [stderr] 24 | |         if bytes.len() != 32usize {
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         Ok(Checksum { bytes: bytes })
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/index/mod.rs:167:41
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let mut scheme = url.scheme().split("+");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/git/git_repo.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 | /     match env::var(GIT_BIN_ENV) {
[INFO] [stderr] 142 | |         Ok(git_bin) => return Ok(git_bin.to_owned()),
[INFO] [stderr] 143 | |         Err(_) => {}
[INFO] [stderr] 144 | |     };
[INFO] [stderr]     | |_____^ help: try this: `if let Ok(git_bin) = env::var(GIT_BIN_ENV) { return Ok(git_bin.to_owned()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/objects/mod.rs:107:41
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let mut scheme = url.scheme().split("+");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/resolver/paths.rs:41:68
[INFO] [stderr]    |
[INFO] [stderr] 41 |             let version = Version::parse(name_version).map_err(|_| format!("bad version"))?;
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bad version".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/index/mod.rs:167:41
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let mut scheme = url.scheme().split("+");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `sha256::Sha256`
[INFO] [stderr]   --> src/sha256.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new() -> Sha256 {
[INFO] [stderr] 30 | |         Sha256 {
[INFO] [stderr] 31 | |             context: digest::Context::new(&digest::SHA256),
[INFO] [stderr] 32 | |         }
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | impl Default for sha256::Sha256 {
[INFO] [stderr] 29 |     fn default() -> Self {
[INFO] [stderr] 30 |         Self::new()
[INFO] [stderr] 31 |     }
[INFO] [stderr] 32 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/objects/mod.rs:107:41
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let mut scheme = url.scheme().split("+");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/resolver/paths.rs:41:68
[INFO] [stderr]    |
[INFO] [stderr] 41 |             let version = Version::parse(name_version).map_err(|_| format!("bad version"))?;
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bad version".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `sha256::Sha256`
[INFO] [stderr]   --> src/sha256.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new() -> Sha256 {
[INFO] [stderr] 30 | |         Sha256 {
[INFO] [stderr] 31 | |             context: digest::Context::new(&digest::SHA256),
[INFO] [stderr] 32 | |         }
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | impl Default for sha256::Sha256 {
[INFO] [stderr] 29 |     fn default() -> Self {
[INFO] [stderr] 30 |         Self::new()
[INFO] [stderr] 31 |     }
[INFO] [stderr] 32 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.91s
[INFO] running `"docker" "inspect" "5681f65885a5e6ff33e3badeefac11469c5e90d2dddc13f5dc73f76350e316cc"`
[INFO] running `"docker" "rm" "-f" "5681f65885a5e6ff33e3badeefac11469c5e90d2dddc13f5dc73f76350e316cc"`
[INFO] [stdout] 5681f65885a5e6ff33e3badeefac11469c5e90d2dddc13f5dc73f76350e316cc