[INFO] crate reproto-lexer 0.3.36 is already in cache [INFO] extracting crate reproto-lexer 0.3.36 into work/ex/clippy-test-run/sources/stable/reg/reproto-lexer/0.3.36 [INFO] extracting crate reproto-lexer 0.3.36 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-lexer/0.3.36 [INFO] validating manifest of reproto-lexer-0.3.36 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reproto-lexer-0.3.36 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reproto-lexer-0.3.36 [INFO] finished frobbing reproto-lexer-0.3.36 [INFO] frobbed toml for reproto-lexer-0.3.36 written to work/ex/clippy-test-run/sources/stable/reg/reproto-lexer/0.3.36/Cargo.toml [INFO] started frobbing reproto-lexer-0.3.36 [INFO] finished frobbing reproto-lexer-0.3.36 [INFO] frobbed toml for reproto-lexer-0.3.36 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-lexer/0.3.36/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reproto-lexer-0.3.36 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reproto-lexer/0.3.36:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01b2364b924340c571cba751b4b4ec1265b13da0d86791c14941537b1cb2f729 [INFO] running `"docker" "start" "-a" "01b2364b924340c571cba751b4b4ec1265b13da0d86791c14941537b1cb2f729"` [INFO] [stderr] Checking ropey v0.6.3 [INFO] [stderr] Checking serde_test v1.0.85 [INFO] [stderr] Checking relative-path v0.3.7 [INFO] [stderr] Checking reproto-semver v0.3.36 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Checking reproto-core v0.3.36 [INFO] [stderr] Checking reproto-lexer v0.3.36 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | digits: digits, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | decimal: decimal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `decimal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:266:25 [INFO] [stderr] | [INFO] [stderr] 266 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:276:21 [INFO] [stderr] | [INFO] [stderr] 276 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:307:41 [INFO] [stderr] | [INFO] [stderr] 307 | Err(Error::UnterminatedString { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:332:44 [INFO] [stderr] | [INFO] [stderr] 332 | Err(Error::UnterminatedCodeBlock { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:496:9 [INFO] [stderr] | [INFO] [stderr] 496 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | n0: n0, [INFO] [stderr] | ^^^^^^ help: replace it with: `n0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | n1: n1, [INFO] [stderr] | ^^^^^^ help: replace it with: `n1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | n2: n2, [INFO] [stderr] | ^^^^^^ help: replace it with: `n2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | digits: digits, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | decimal: decimal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `decimal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:266:25 [INFO] [stderr] | [INFO] [stderr] 266 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:276:21 [INFO] [stderr] | [INFO] [stderr] 276 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:307:41 [INFO] [stderr] | [INFO] [stderr] 307 | Err(Error::UnterminatedString { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:332:44 [INFO] [stderr] | [INFO] [stderr] 332 | Err(Error::UnterminatedCodeBlock { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:496:9 [INFO] [stderr] | [INFO] [stderr] 496 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | n0: n0, [INFO] [stderr] | ^^^^^^ help: replace it with: `n0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | n1: n1, [INFO] [stderr] | ^^^^^^ help: replace it with: `n1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | n2: n2, [INFO] [stderr] | ^^^^^^ help: replace it with: `n2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> lexer.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Ok((start, token, end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((start, token, end))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> lexer.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | return Ok(escaped); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(escaped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> lexer.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Ok((start, token, end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((start, token, end))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> lexer.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | return Ok(escaped); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(escaped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> lexer.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | *decimal = *decimal - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*decimal -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lexer.rs:273:28 [INFO] [stderr] | [INFO] [stderr] 273 | return Err(Error::InvalidEscape { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 274 | | message: "unrecognized escape, should be one of: \\\", \\n, \\r, \\t, \\\\, \ [INFO] [stderr] 275 | | or \\uXXXX", [INFO] [stderr] 276 | | pos: pos, [INFO] [stderr] 277 | | }.into()); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 273 | return Err(Error::InvalidEscape { [INFO] [stderr] 274 | message: "unrecognized escape, should be one of: \\\", \\n, \\r, \\t, \\\\, \ [INFO] [stderr] 275 | or \\uXXXX", [INFO] [stderr] 276 | pos: pos, [INFO] [stderr] 277 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lexer.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | Err(Error::UnterminatedString { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::UnterminatedString { start: start }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lexer.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | Err(Error::UnterminatedCodeBlock { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::UnterminatedCodeBlock { start: start }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> lexer.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | *decimal = *decimal - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*decimal -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lexer.rs:273:28 [INFO] [stderr] | [INFO] [stderr] 273 | return Err(Error::InvalidEscape { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 274 | | message: "unrecognized escape, should be one of: \\\", \\n, \\r, \\t, \\\\, \ [INFO] [stderr] 275 | | or \\uXXXX", [INFO] [stderr] 276 | | pos: pos, [INFO] [stderr] 277 | | }.into()); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 273 | return Err(Error::InvalidEscape { [INFO] [stderr] 274 | message: "unrecognized escape, should be one of: \\\", \\n, \\r, \\t, \\\\, \ [INFO] [stderr] 275 | or \\uXXXX", [INFO] [stderr] 276 | pos: pos, [INFO] [stderr] 277 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lexer.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | Err(Error::UnterminatedString { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::UnterminatedString { start: start }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lexer.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | Err(Error::UnterminatedCodeBlock { start: start }.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::UnterminatedCodeBlock { start: start }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.29s [INFO] running `"docker" "inspect" "01b2364b924340c571cba751b4b4ec1265b13da0d86791c14941537b1cb2f729"` [INFO] running `"docker" "rm" "-f" "01b2364b924340c571cba751b4b4ec1265b13da0d86791c14941537b1cb2f729"` [INFO] [stdout] 01b2364b924340c571cba751b4b4ec1265b13da0d86791c14941537b1cb2f729