[INFO] crate reproto-derive 0.3.36 is already in cache [INFO] extracting crate reproto-derive 0.3.36 into work/ex/clippy-test-run/sources/stable/reg/reproto-derive/0.3.36 [INFO] extracting crate reproto-derive 0.3.36 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-derive/0.3.36 [INFO] validating manifest of reproto-derive-0.3.36 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reproto-derive-0.3.36 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reproto-derive-0.3.36 [INFO] finished frobbing reproto-derive-0.3.36 [INFO] frobbed toml for reproto-derive-0.3.36 written to work/ex/clippy-test-run/sources/stable/reg/reproto-derive/0.3.36/Cargo.toml [INFO] started frobbing reproto-derive-0.3.36 [INFO] finished frobbing reproto-derive-0.3.36 [INFO] frobbed toml for reproto-derive-0.3.36 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-derive/0.3.36/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reproto-derive-0.3.36 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reproto-derive/0.3.36:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 457ad134f01baaff4c1fc36b5f728654ae44c49bf92da9144064543f1afed622 [INFO] running `"docker" "start" "-a" "457ad134f01baaff4c1fc36b5f728654ae44c49bf92da9144064543f1afed622"` [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking yaml-rust v0.4.2 [INFO] [stderr] Checking reproto-core v0.3.36 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking reproto-lexer v0.3.36 [INFO] [stderr] Checking reproto-ast v0.3.36 [INFO] [stderr] Checking reproto-derive v0.3.36 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sir.rs:268:17 [INFO] [stderr] | [INFO] [stderr] 268 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sir.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | root_name: root_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | package_prefix: package_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `package_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | Self { content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | field_as: field_as, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `field_as` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:462:17 [INFO] [stderr] | [INFO] [stderr] 462 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:532:9 [INFO] [stderr] | [INFO] [stderr] 532 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sir.rs:268:17 [INFO] [stderr] | [INFO] [stderr] 268 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sir.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | root_name: root_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | package_prefix: package_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `package_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | Self { content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | field_as: field_as, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `field_as` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:462:17 [INFO] [stderr] | [INFO] [stderr] 462 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:532:9 [INFO] [stderr] | [INFO] [stderr] 532 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> json.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> yaml.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> json.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> yaml.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> json.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | .ok_or_else(|| format!("Expected at least one JSON value").into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected at least one JSON value".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> json.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | let diff = (((number as f32) as f64) - number).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((number as f32))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> sir.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | while let Some(other) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for other in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> yaml.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | let diff = (((number as f32) as f64) - number).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((number as f32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | Err(format!("No last component in name").into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No last component in name".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> lib.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let mut path = self.path.iter().cloned().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lib.rs:233:26 [INFO] [stderr] | [INFO] [stderr] 233 | ty: Loc::new(ty.into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | ty: Loc::new(ty.into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:242:35 [INFO] [stderr] | [INFO] [stderr] 242 | item: Loc::new(field, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:250:22 [INFO] [stderr] | [INFO] [stderr] 250 | out.push(format!("## Examples").into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"## Examples".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:253:22 [INFO] [stderr] | [INFO] [stderr] 253 | out.push(format!("```json").into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"```json".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:267:22 [INFO] [stderr] | [INFO] [stderr] 267 | out.push(format!("```").into()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"```".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> json.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | .ok_or_else(|| format!("Expected at least one JSON value").into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected at least one JSON value".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:342:34 [INFO] [stderr] | [INFO] [stderr] 342 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:375:66 [INFO] [stderr] | [INFO] [stderr] 375 | name: Loc::new(self.ctx.ident()?.to_string().into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:385:34 [INFO] [stderr] | [INFO] [stderr] 385 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | self.span.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> json.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | let diff = (((number as f32) as f64) - number).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((number as f32))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:427:53 [INFO] [stderr] | [INFO] [stderr] 427 | let name = Loc::new("type_info".into(), self.span.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:431:47 [INFO] [stderr] | [INFO] [stderr] 431 | name: Loc::new("type".into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:432:68 [INFO] [stderr] | [INFO] [stderr] 432 | value: Loc::new(Value::String("type".to_string()), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:437:41 [INFO] [stderr] | [INFO] [stderr] 437 | attributes.push(Loc::new(a, self.span.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:451:34 [INFO] [stderr] | [INFO] [stderr] 451 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:492:34 [INFO] [stderr] | [INFO] [stderr] 492 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> sir.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | while let Some(other) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for other in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> yaml.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | let diff = (((number as f32) as f64) - number).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((number as f32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | Err(format!("No last component in name").into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No last component in name".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> lib.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let mut path = self.path.iter().cloned().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> lib.rs:233:26 [INFO] [stderr] | [INFO] [stderr] 233 | ty: Loc::new(ty.into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | ty: Loc::new(ty.into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:242:35 [INFO] [stderr] | [INFO] [stderr] 242 | item: Loc::new(field, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:250:22 [INFO] [stderr] | [INFO] [stderr] 250 | out.push(format!("## Examples").into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"## Examples".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:253:22 [INFO] [stderr] | [INFO] [stderr] 253 | out.push(format!("```json").into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"```json".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> lib.rs:267:22 [INFO] [stderr] | [INFO] [stderr] 267 | out.push(format!("```").into()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"```".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:342:34 [INFO] [stderr] | [INFO] [stderr] 342 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:375:66 [INFO] [stderr] | [INFO] [stderr] 375 | name: Loc::new(self.ctx.ident()?.to_string().into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:385:34 [INFO] [stderr] | [INFO] [stderr] 385 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | self.span.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:427:53 [INFO] [stderr] | [INFO] [stderr] 427 | let name = Loc::new("type_info".into(), self.span.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:431:47 [INFO] [stderr] | [INFO] [stderr] 431 | name: Loc::new("type".into(), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:432:68 [INFO] [stderr] | [INFO] [stderr] 432 | value: Loc::new(Value::String("type".to_string()), self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:437:41 [INFO] [stderr] | [INFO] [stderr] 437 | attributes.push(Loc::new(a, self.span.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:451:34 [INFO] [stderr] | [INFO] [stderr] 451 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:492:34 [INFO] [stderr] | [INFO] [stderr] 492 | item: Loc::new(body, self.span.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> lib.rs:549:44 [INFO] [stderr] | [INFO] [stderr] 549 | let source = Source::bytes("test", input.as_bytes().iter().cloned().collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.55s [INFO] running `"docker" "inspect" "457ad134f01baaff4c1fc36b5f728654ae44c49bf92da9144064543f1afed622"` [INFO] running `"docker" "rm" "-f" "457ad134f01baaff4c1fc36b5f728654ae44c49bf92da9144064543f1afed622"` [INFO] [stdout] 457ad134f01baaff4c1fc36b5f728654ae44c49bf92da9144064543f1afed622