[INFO] crate reproto-core 0.3.36 is already in cache [INFO] extracting crate reproto-core 0.3.36 into work/ex/clippy-test-run/sources/stable/reg/reproto-core/0.3.36 [INFO] extracting crate reproto-core 0.3.36 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-core/0.3.36 [INFO] validating manifest of reproto-core-0.3.36 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reproto-core-0.3.36 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reproto-core-0.3.36 [INFO] finished frobbing reproto-core-0.3.36 [INFO] frobbed toml for reproto-core-0.3.36 written to work/ex/clippy-test-run/sources/stable/reg/reproto-core/0.3.36/Cargo.toml [INFO] started frobbing reproto-core-0.3.36 [INFO] finished frobbing reproto-core-0.3.36 [INFO] frobbed toml for reproto-core-0.3.36 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-core/0.3.36/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reproto-core-0.3.36 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reproto-core/0.3.36:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7490b7d7399291d51c40e043f42421248d79eeaa7067117491a73213bcc12f03 [INFO] running `"docker" "start" "-a" "7490b7d7399291d51c40e043f42421248d79eeaa7067117491a73213bcc12f03"` [INFO] [stderr] Checking serde_test v1.0.85 [INFO] [stderr] Checking reproto-semver v0.3.36 [INFO] [stderr] Checking relative-path v0.3.7 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Checking reproto-core v0.3.36 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attributes.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | words: words, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attributes.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attributes.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | words: words, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attributes.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | words: words, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] --> src/attributes.rs:87:13 [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 87 | selections: selections, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selections` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/attributes.rs:40:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 40 | values: values, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] --> src/fs.rs:48:41 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 48 | return Ok(Box::new(RealHandle { root: root })); [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/attributes.rs:86:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 86 | words: words, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] --> src/loc.rs:26:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 26 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/attributes.rs:87:13 [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] 87 | selections: selections, [INFO] [stderr] --> src/rp_decl.rs:112:17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selections` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 112 | Decls { iter: iter } [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/fs.rs:48:41 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] 48 | return Ok(Box::new(RealHandle { root: root })); [INFO] [stderr] --> src/rp_endpoint.rs:289:13 [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 289 | request: request, [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loc.rs:26:13 [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 26 | inner: inner, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] --> src/rp_endpoint.rs:290:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 290 | response: response, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_decl.rs:112:17 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 112 | Decls { iter: iter } [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] --> src/rp_endpoint.rs:291:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 291 | path: path, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_endpoint.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | request: request, [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_endpoint.rs:292:13 [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 292 | method: method, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] --> src/rp_endpoint.rs:290:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 290 | response: response, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_enum.rs:35:13 [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 35 | name: name, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] --> src/rp_endpoint.rs:291:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 291 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_enum.rs:158:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 158 | name: name, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_endpoint.rs:292:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 292 | method: method, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] --> src/rp_field.rs:47:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 47 | ty: ty, [INFO] [stderr] [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_enum.rs:35:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 35 | name: name, [INFO] [stderr] warning: lint name `linkedlist` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/rp_file.rs:20:9 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 20 | #[allow(linkedlist)] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::linkedlist` [INFO] [stderr] --> src/rp_enum.rs:158:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] 158 | name: name, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] --> src/rp_file.rs:52:23 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 52 | ForEachDecl { queue: queue } [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_field.rs:47:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 47 | ty: ty, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] --> src/rp_interface.rs:110:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 110 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: lint name `linkedlist` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] | [INFO] [stderr] --> src/rp_file.rs:20:9 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] 20 | #[allow(linkedlist)] [INFO] [stderr] --> src/rp_interface.rs:179:13 [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::linkedlist` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 179 | name: name, [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_file.rs:52:23 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 52 | ForEachDecl { queue: queue } [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] --> src/rp_name.rs:29:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 29 | prefix: prefix, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_interface.rs:110:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 110 | name: name, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] --> src/rp_name.rs:30:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 30 | package: package, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] --> src/rp_interface.rs:179:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 179 | name: name, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_name.rs:31:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 31 | parts: parts, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] --> src/rp_name.rs:29:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 29 | prefix: prefix, [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_name.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_name.rs:56:13 [INFO] [stderr] --> src/rp_name.rs:30:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 56 | parts: parts, [INFO] [stderr] 30 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_name.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] --> src/rp_name.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_name.rs:45:13 [INFO] [stderr] --> src/rp_name.rs:86:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 45 | parts: parts, [INFO] [stderr] 86 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_package.rs:53:21 [INFO] [stderr] --> src/rp_name.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 53 | RpPackage { parts: parts } [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] --> src/rp_name.rs:76:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 76 | package: package, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_required_package.rs:16:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 16 | package: package, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] --> src/rp_name.rs:86:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 86 | parts: parts, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/rp_required_package.rs:17:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 17 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_service.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_service.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | endpoints: endpoints, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_tuple.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_type_model.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_versioned_package.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_versioned_package.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_package.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | RpPackage { parts: parts } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_required_package.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_required_package.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_service.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_service.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | endpoints: endpoints, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_tuple.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_type_model.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_versioned_package.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rp_versioned_package.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/errors.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return Some(Backtrace::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Backtrace::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fs.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / return Ok(Box::new(CapturingHandle { [INFO] [stderr] 106 | | files: self.files.clone(), [INFO] [stderr] 107 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Box::new(CapturingHandle { [INFO] [stderr] 106 | files: self.files.clone(), [INFO] [stderr] 107 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rp_endpoint.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | / return Some(RpEndpointHttp1 { [INFO] [stderr] 289 | | request: request, [INFO] [stderr] 290 | | response: response, [INFO] [stderr] 291 | | path: path, [INFO] [stderr] 292 | | method: method, [INFO] [stderr] 293 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 288 | Some(RpEndpointHttp1 { [INFO] [stderr] 289 | request: request, [INFO] [stderr] 290 | response: response, [INFO] [stderr] 291 | path: path, [INFO] [stderr] 292 | method: method, [INFO] [stderr] 293 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rp_enum.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | return Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("number is not within {} to {} (inclusive)", mn, mx).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_enum.rs:193:39 [INFO] [stderr] | [INFO] [stderr] 193 | const MAX_SAFE_INTEGER: i64 = 9007199254740991i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_enum.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | const MIN_SAFE_INTEGER: i64 = -9007199254740991i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `linkedlist` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rp_file.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | #[allow(linkedlist)] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::linkedlist` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/translator.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return Ok(reg.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(reg.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/errors.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return Some(Backtrace::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Backtrace::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fs.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / return Ok(Box::new(CapturingHandle { [INFO] [stderr] 106 | | files: self.files.clone(), [INFO] [stderr] 107 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Box::new(CapturingHandle { [INFO] [stderr] 106 | files: self.files.clone(), [INFO] [stderr] 107 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rp_endpoint.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | / return Some(RpEndpointHttp1 { [INFO] [stderr] 289 | | request: request, [INFO] [stderr] 290 | | response: response, [INFO] [stderr] 291 | | path: path, [INFO] [stderr] 292 | | method: method, [INFO] [stderr] 293 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 288 | Some(RpEndpointHttp1 { [INFO] [stderr] 289 | request: request, [INFO] [stderr] 290 | response: response, [INFO] [stderr] 291 | path: path, [INFO] [stderr] 292 | method: method, [INFO] [stderr] 293 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rp_enum.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | return Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("number is not within {} to {} (inclusive)", mn, mx).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_enum.rs:193:39 [INFO] [stderr] | [INFO] [stderr] 193 | const MAX_SAFE_INTEGER: i64 = 9007199254740991i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_enum.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | const MIN_SAFE_INTEGER: i64 = -9007199254740991i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `linkedlist` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rp_file.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | #[allow(linkedlist)] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::linkedlist` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_number.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | digits: 104321.into(), [INFO] [stderr] | ^^^^^^ help: consider: `104_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_number.rs:183:23 [INFO] [stderr] | [INFO] [stderr] 183 | digits: (-104321).into(), [INFO] [stderr] | ^^^^^^ help: consider: `104_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_number.rs:198:22 [INFO] [stderr] | [INFO] [stderr] 198 | digits: (104321).into(), [INFO] [stderr] | ^^^^^^ help: consider: `104_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_number.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | digits: (104321).into(), [INFO] [stderr] | ^^^^^^ help: consider: `104_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rp_number.rs:212:22 [INFO] [stderr] | [INFO] [stderr] 212 | digits: (104321).into(), [INFO] [stderr] | ^^^^^^ help: consider: `104_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/translator.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return Ok(reg.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(reg.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/errors.rs:135:52 [INFO] [stderr] | [INFO] [stderr] 135 | let enabled = is_backtrace_enabled(|var| env::var_os(var)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `env::var_os` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `fs::RealFilesystem` [INFO] [stderr] --> src/fs.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> RealFilesystem { [INFO] [stderr] 37 | | Self {} [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fs.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | Ok(fs::create_dir_all(&path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 65 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `fs::CapturingFilesystem` [INFO] [stderr] --> src/fs.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> CapturingFilesystem { [INFO] [stderr] 85 | | Self { [INFO] [stderr] 86 | | files: Rc::new(RefCell::new(LinkedHashMap::new())), [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | Loc::new(op(loc.inner), loc.span.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/loc.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn as_ref(loc: &Loc) -> Loc<&T> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | Loc::new(&loc.inner, loc.span.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | op(inner).map(|value| Loc::new(value, span.clone())) [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | Loc::span(value).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `Loc::span(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rp_decl.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | value.span().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.span()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rp_endpoint.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | .unwrap_or(self.ident()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rp_endpoint.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | .unwrap_or(self.ident.as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident.as_str())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rp_endpoint.rs:210:12 [INFO] [stderr] | [INFO] [stderr] 210 | if !self.http.path.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.http.path.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rp_enum.rs:209:12 [INFO] [stderr] | [INFO] [stderr] 209 | if &mn <= n && n <= &mx { [INFO] [stderr] | ---^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `mn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rp_enum.rs:209:24 [INFO] [stderr] | [INFO] [stderr] 209 | if &mn <= n && n <= &mx { [INFO] [stderr] | ^^^^^--- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `mx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: item `rp_package::RpPackage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/rp_package.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl RpPackage { [INFO] [stderr] 52 | | pub fn new(parts: Vec) -> RpPackage { [INFO] [stderr] 53 | | RpPackage { parts: parts } [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rp_required_package.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | let mut it = input.splitn(2, '@').into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.splitn(2, '@')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/source.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / match Url::from_file_path(path) { [INFO] [stderr] 144 | | Ok(url) => return Some(url), [INFO] [stderr] 145 | | Err(_) => {} [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(url) = Url::from_file_path(path) { return Some(url) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/translator.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | / match decls.get(&key) { [INFO] [stderr] 314 | | Some(reg) => return Ok(reg.clone()), [INFO] [stderr] 315 | | None => {} [INFO] [stderr] 316 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(reg) = decls.get(&key) { return Ok(reg.clone()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/utils.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | const NL: u8 = '\n' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/utils.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const CR: u8 = '\r' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/utils.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | while let Some(b) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for b in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn column(&self, buffer: &[u8], col: usize) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/errors.rs:135:52 [INFO] [stderr] | [INFO] [stderr] 135 | let enabled = is_backtrace_enabled(|var| env::var_os(var)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `env::var_os` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `fs::RealFilesystem` [INFO] [stderr] --> src/fs.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> RealFilesystem { [INFO] [stderr] 37 | | Self {} [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fs.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | Ok(fs::create_dir_all(&path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 65 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `fs::CapturingFilesystem` [INFO] [stderr] --> src/fs.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> CapturingFilesystem { [INFO] [stderr] 85 | | Self { [INFO] [stderr] 86 | | files: Rc::new(RefCell::new(LinkedHashMap::new())), [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | Loc::new(op(loc.inner), loc.span.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/loc.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn as_ref(loc: &Loc) -> Loc<&T> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | Loc::new(&loc.inner, loc.span.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | op(inner).map(|value| Loc::new(value, span.clone())) [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/loc.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | Loc::span(value).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `Loc::span(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rp_decl.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | value.span().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.span()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rp_endpoint.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | .unwrap_or(self.ident()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rp_endpoint.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | .unwrap_or(self.ident.as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident.as_str())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rp_endpoint.rs:210:12 [INFO] [stderr] | [INFO] [stderr] 210 | if !self.http.path.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.http.path.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rp_enum.rs:209:12 [INFO] [stderr] | [INFO] [stderr] 209 | if &mn <= n && n <= &mx { [INFO] [stderr] | ---^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `mn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rp_enum.rs:209:24 [INFO] [stderr] | [INFO] [stderr] 209 | if &mn <= n && n <= &mx { [INFO] [stderr] | ^^^^^--- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `mx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: item `rp_package::RpPackage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/rp_package.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl RpPackage { [INFO] [stderr] 52 | | pub fn new(parts: Vec) -> RpPackage { [INFO] [stderr] 53 | | RpPackage { parts: parts } [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rp_required_package.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | let mut it = input.splitn(2, '@').into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.splitn(2, '@')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/source.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / match Url::from_file_path(path) { [INFO] [stderr] 144 | | Ok(url) => return Some(url), [INFO] [stderr] 145 | | Err(_) => {} [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(url) = Url::from_file_path(path) { return Some(url) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/translator.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | / match decls.get(&key) { [INFO] [stderr] 314 | | Some(reg) => return Ok(reg.clone()), [INFO] [stderr] 315 | | None => {} [INFO] [stderr] 316 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(reg) = decls.get(&key) { return Ok(reg.clone()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/utils.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | const NL: u8 = '\n' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/utils.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const CR: u8 = '\r' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/utils.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | while let Some(b) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for b in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn column(&self, buffer: &[u8], col: usize) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.24s [INFO] running `"docker" "inspect" "7490b7d7399291d51c40e043f42421248d79eeaa7067117491a73213bcc12f03"` [INFO] running `"docker" "rm" "-f" "7490b7d7399291d51c40e043f42421248d79eeaa7067117491a73213bcc12f03"` [INFO] [stdout] 7490b7d7399291d51c40e043f42421248d79eeaa7067117491a73213bcc12f03