[INFO] crate repos 0.1.8 is already in cache
[INFO] extracting crate repos 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/repos/0.1.8
[INFO] extracting crate repos 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/repos/0.1.8
[INFO] validating manifest of repos-0.1.8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of repos-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing repos-0.1.8
[INFO] finished frobbing repos-0.1.8
[INFO] frobbed toml for repos-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/repos/0.1.8/Cargo.toml
[INFO] started frobbing repos-0.1.8
[INFO] finished frobbing repos-0.1.8
[INFO] frobbed toml for repos-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/repos/0.1.8/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting repos-0.1.8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/repos/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ce07afd7a2e2d3a8d8349e3ba8b3ba3e73915ef49fc614c0c4fe2b75560737c7
[INFO] running `"docker" "start" "-a" "ce07afd7a2e2d3a8d8349e3ba8b3ba3e73915ef49fc614c0c4fe2b75560737c7"`
[INFO] [stderr]     Checking phf_shared v0.7.15
[INFO] [stderr]     Checking r2d2 v0.7.4
[INFO] [stderr]     Checking phf v0.7.15
[INFO] [stderr]     Checking postgres v0.11.12
[INFO] [stderr]     Checking r2d2_postgres v0.10.1
[INFO] [stderr]     Checking repos v0.1.8 (/opt/crater/workdir)
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/lib.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/lib.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/lib.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 |     None
[INFO] [stderr]     |     ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/lib.rs:312:5
[INFO] [stderr]     |
[INFO] [stderr] 312 |     vec![]
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/lib.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 |     None
[INFO] [stderr]     |     ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/lib.rs:312:5
[INFO] [stderr]     |
[INFO] [stderr] 312 |     vec![]
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:21:36
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn get_values<'a>(&'a self, _: &Vec<&'static str>)->
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&'static str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/lib.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |         self.get_values(&vec![field_name]).get(&field_name).map(|v| *v).unwrap()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get_values(&vec![field_name]).get(&field_name).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/lib.rs:144:5
[INFO] [stderr]     |
[INFO] [stderr] 144 | /     fn new(&self) -> bool {
[INFO] [stderr] 145 | |         let (params, t): (Vec<_>, Vec<_>) = self.get_values(&T::get_fields())
[INFO] [stderr] 146 | |             .iter()
[INFO] [stderr] 147 | |             .enumerate()
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |         execute(&sql, values.as_slice()) == 1
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:148:71
[INFO] [stderr]     |
[INFO] [stderr] 148 |             .map(|(index, (key, value))| (format!("${}", index + 1), (format!("{}", key), *value)))
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `key.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:233:32
[INFO] [stderr]     |
[INFO] [stderr] 233 |     if order_field.starts_with("-") {
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:21:36
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn get_values<'a>(&'a self, _: &Vec<&'static str>)->
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&'static str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/lib.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |         self.get_values(&vec![field_name]).get(&field_name).map(|v| *v).unwrap()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get_values(&vec![field_name]).get(&field_name).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/lib.rs:144:5
[INFO] [stderr]     |
[INFO] [stderr] 144 | /     fn new(&self) -> bool {
[INFO] [stderr] 145 | |         let (params, t): (Vec<_>, Vec<_>) = self.get_values(&T::get_fields())
[INFO] [stderr] 146 | |             .iter()
[INFO] [stderr] 147 | |             .enumerate()
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |         execute(&sql, values.as_slice()) == 1
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:148:71
[INFO] [stderr]     |
[INFO] [stderr] 148 |             .map(|(index, (key, value))| (format!("${}", index + 1), (format!("{}", key), *value)))
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `key.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:233:32
[INFO] [stderr]     |
[INFO] [stderr] 233 |     if order_field.starts_with("-") {
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/simple.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | #[macro_use] extern crate lazy_static;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/simple.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | #[macro_use] extern crate log;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/simple.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | #[macro_use] extern crate repos;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.31s
[INFO] running `"docker" "inspect" "ce07afd7a2e2d3a8d8349e3ba8b3ba3e73915ef49fc614c0c4fe2b75560737c7"`
[INFO] running `"docker" "rm" "-f" "ce07afd7a2e2d3a8d8349e3ba8b3ba3e73915ef49fc614c0c4fe2b75560737c7"`
[INFO] [stdout] ce07afd7a2e2d3a8d8349e3ba8b3ba3e73915ef49fc614c0c4fe2b75560737c7