[INFO] crate repo-backup 0.2.2 is already in cache [INFO] extracting crate repo-backup 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/repo-backup/0.2.2 [INFO] extracting crate repo-backup 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/repo-backup/0.2.2 [INFO] validating manifest of repo-backup-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of repo-backup-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing repo-backup-0.2.2 [INFO] finished frobbing repo-backup-0.2.2 [INFO] frobbed toml for repo-backup-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/repo-backup/0.2.2/Cargo.toml [INFO] started frobbing repo-backup-0.2.2 [INFO] finished frobbing repo-backup-0.2.2 [INFO] frobbed toml for repo-backup-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/repo-backup/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting repo-backup-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/repo-backup/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fb327f88b64d38f25413f223c904411836f4572bf03dc7f687064e10c02c342 [INFO] running `"docker" "start" "-a" "8fb327f88b64d38f25413f223c904411836f4572bf03dc7f687064e10c02c342"` [INFO] [stderr] Checking sec v0.99.4 [INFO] [stderr] Checking hyperx v0.13.2 [INFO] [stderr] Checking gitlab v0.1103.2 [INFO] [stderr] Checking repo-backup v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:202:50 [INFO] [stderr] | [INFO] [stderr] 202 | return self.items.next().map(|it| Ok(it)); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/utils.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / link.values() [INFO] [stderr] 215 | | .iter() [INFO] [stderr] 216 | | .filter_map(|v| if is_next(v) { Some(v) } else { None }) [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn from_str(src: &str) -> Result { [INFO] [stderr] 99 | | toml::from_str(src) [INFO] [stderr] 100 | | .context("Parsing config file failed") [INFO] [stderr] 101 | | .map_err(Error::from) [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:202:50 [INFO] [stderr] | [INFO] [stderr] 202 | return self.items.next().map(|it| Ok(it)); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/utils.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / link.values() [INFO] [stderr] 215 | | .iter() [INFO] [stderr] 216 | | .filter_map(|v| if is_next(v) { Some(v) } else { None }) [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn from_str(src: &str) -> Result { [INFO] [stderr] 99 | | toml::from_str(src) [INFO] [stderr] 100 | | .context("Parsing config file failed") [INFO] [stderr] 101 | | .map_err(Error::from) [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitlab_provider.rs:65:59 [INFO] [stderr] | [INFO] [stderr] 65 | let mut split = project.path_with_namespace.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitlab_provider.rs:65:59 [INFO] [stderr] | [INFO] [stderr] 65 | let mut split = project.path_with_namespace.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.96s [INFO] running `"docker" "inspect" "8fb327f88b64d38f25413f223c904411836f4572bf03dc7f687064e10c02c342"` [INFO] running `"docker" "rm" "-f" "8fb327f88b64d38f25413f223c904411836f4572bf03dc7f687064e10c02c342"` [INFO] [stdout] 8fb327f88b64d38f25413f223c904411836f4572bf03dc7f687064e10c02c342