[INFO] crate renv 0.2.3 is already in cache
[INFO] extracting crate renv 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/renv/0.2.3
[INFO] extracting crate renv 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/renv/0.2.3
[INFO] validating manifest of renv-0.2.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of renv-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing renv-0.2.3
[INFO] finished frobbing renv-0.2.3
[INFO] frobbed toml for renv-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/renv/0.2.3/Cargo.toml
[INFO] started frobbing renv-0.2.3
[INFO] finished frobbing renv-0.2.3
[INFO] frobbed toml for renv-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/renv/0.2.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting renv-0.2.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/renv/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e0526501d8749b94aaa5d118f43645f4b7688796b03b136a03467ce134705179
[INFO] running `"docker" "start" "-a" "e0526501d8749b94aaa5d118f43645f4b7688796b03b136a03467ce134705179"`
[INFO] [stderr]     Checking java-properties v0.1.1
[INFO] [stderr]     Checking renv v0.2.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fs.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             vars: vars,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `vars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fs.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             vars: vars,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `vars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fs.rs:59:41
[INFO] [stderr]    |
[INFO] [stderr] 59 |         io::ErrorKind::AlreadyExists => return Ok(()),
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fs.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             return Err(err);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/fs.rs:32:11
[INFO] [stderr]    |
[INFO] [stderr] 32 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fs.rs:59:41
[INFO] [stderr]    |
[INFO] [stderr] 59 |         io::ErrorKind::AlreadyExists => return Ok(()),
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fs.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             return Err(err);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/fs.rs:32:11
[INFO] [stderr]    |
[INFO] [stderr] 32 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 | /     match run_subcommand(&matches) {
[INFO] [stderr] 138 | |         Err(err) => {
[INFO] [stderr] 139 | |             writeln!(&mut stderr, "Error: {:?}", err).unwrap();
[INFO] [stderr] 140 | |         },
[INFO] [stderr] 141 | |         _ => {}
[INFO] [stderr] 142 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 137 |     if let Err(err) = run_subcommand(&matches) {
[INFO] [stderr] 138 |     writeln!(&mut stderr, "Error: {:?}", err).unwrap();
[INFO] [stderr] 139 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:266:9
[INFO] [stderr]     |
[INFO] [stderr] 266 |         split.get(1).map(|o| *o)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `split.get(1).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/main.rs:288:5
[INFO] [stderr]     |
[INFO] [stderr] 288 |     patterns.iter().find(|p| p.matches(file_name)).is_some()
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|p| p.matches(file_name)).is_some()` with `any(|p| p.matches(file_name))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 | /     match run_subcommand(&matches) {
[INFO] [stderr] 138 | |         Err(err) => {
[INFO] [stderr] 139 | |             writeln!(&mut stderr, "Error: {:?}", err).unwrap();
[INFO] [stderr] 140 | |         },
[INFO] [stderr] 141 | |         _ => {}
[INFO] [stderr] 142 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 137 |     if let Err(err) = run_subcommand(&matches) {
[INFO] [stderr] 138 |     writeln!(&mut stderr, "Error: {:?}", err).unwrap();
[INFO] [stderr] 139 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:266:9
[INFO] [stderr]     |
[INFO] [stderr] 266 |         split.get(1).map(|o| *o)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `split.get(1).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/main.rs:288:5
[INFO] [stderr]     |
[INFO] [stderr] 288 |     patterns.iter().find(|p| p.matches(file_name)).is_some()
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|p| p.matches(file_name)).is_some()` with `any(|p| p.matches(file_name))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.78s
[INFO] running `"docker" "inspect" "e0526501d8749b94aaa5d118f43645f4b7688796b03b136a03467ce134705179"`
[INFO] running `"docker" "rm" "-f" "e0526501d8749b94aaa5d118f43645f4b7688796b03b136a03467ce134705179"`
[INFO] [stdout] e0526501d8749b94aaa5d118f43645f4b7688796b03b136a03467ce134705179