[INFO] crate rental-impl 0.5.2 is already in cache [INFO] extracting crate rental-impl 0.5.2 into work/ex/clippy-test-run/sources/stable/reg/rental-impl/0.5.2 [INFO] extracting crate rental-impl 0.5.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rental-impl/0.5.2 [INFO] validating manifest of rental-impl-0.5.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rental-impl-0.5.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rental-impl-0.5.2 [INFO] finished frobbing rental-impl-0.5.2 [INFO] frobbed toml for rental-impl-0.5.2 written to work/ex/clippy-test-run/sources/stable/reg/rental-impl/0.5.2/Cargo.toml [INFO] started frobbing rental-impl-0.5.2 [INFO] finished frobbing rental-impl-0.5.2 [INFO] frobbed toml for rental-impl-0.5.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rental-impl/0.5.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rental-impl-0.5.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rental-impl/0.5.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 636f943bedd36139c854faf8534270a3e288c44608d32c673831b2999a36cd66 [INFO] running `"docker" "start" "-a" "636f943bedd36139c854faf8534270a3e288c44608d32c673831b2999a36cd66"` [INFO] [stderr] Checking rental-impl v0.5.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1015:3 [INFO] [stderr] | [INFO] [stderr] 1015 | is_rental_mut: is_rental_mut, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_rental_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1016:3 [INFO] [stderr] | [INFO] [stderr] 1016 | is_debug: is_debug, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1017:3 [INFO] [stderr] | [INFO] [stderr] 1017 | is_clone: is_clone, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_clone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1018:3 [INFO] [stderr] | [INFO] [stderr] 1018 | is_deref_suffix: is_deref_suffix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_deref_suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1019:3 [INFO] [stderr] | [INFO] [stderr] 1019 | is_deref_mut_suffix: is_deref_mut_suffix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_deref_mut_suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1020:3 [INFO] [stderr] | [INFO] [stderr] 1020 | is_covariant: is_covariant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_covariant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1021:3 [INFO] [stderr] | [INFO] [stderr] 1021 | map_suffix_param: map_suffix_param, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_suffix_param` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1237:4 [INFO] [stderr] | [INFO] [stderr] 1237 | subrental: subrental, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subrental` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1238:4 [INFO] [stderr] | [INFO] [stderr] 1238 | self_rlt_args: self_rlt_args, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_rlt_args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1239:4 [INFO] [stderr] | [INFO] [stderr] 1239 | used_rlt_args: used_rlt_args, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `used_rlt_args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1240:4 [INFO] [stderr] | [INFO] [stderr] 1240 | target_ty_hack: target_ty_hack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_ty_hack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1241:4 [INFO] [stderr] | [INFO] [stderr] 1241 | target_ty_hack_erased: target_ty_hack_erased, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_ty_hack_erased` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1572:5 [INFO] [stderr] | [INFO] [stderr] 1572 | leading_colon: leading_colon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `leading_colon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1015:3 [INFO] [stderr] | [INFO] [stderr] 1015 | is_rental_mut: is_rental_mut, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_rental_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1016:3 [INFO] [stderr] | [INFO] [stderr] 1016 | is_debug: is_debug, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1017:3 [INFO] [stderr] | [INFO] [stderr] 1017 | is_clone: is_clone, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_clone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1018:3 [INFO] [stderr] | [INFO] [stderr] 1018 | is_deref_suffix: is_deref_suffix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_deref_suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1019:3 [INFO] [stderr] | [INFO] [stderr] 1019 | is_deref_mut_suffix: is_deref_mut_suffix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_deref_mut_suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1020:3 [INFO] [stderr] | [INFO] [stderr] 1020 | is_covariant: is_covariant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_covariant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1021:3 [INFO] [stderr] | [INFO] [stderr] 1021 | map_suffix_param: map_suffix_param, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_suffix_param` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1237:4 [INFO] [stderr] | [INFO] [stderr] 1237 | subrental: subrental, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subrental` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1238:4 [INFO] [stderr] | [INFO] [stderr] 1238 | self_rlt_args: self_rlt_args, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_rlt_args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1239:4 [INFO] [stderr] | [INFO] [stderr] 1239 | used_rlt_args: used_rlt_args, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `used_rlt_args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1240:4 [INFO] [stderr] | [INFO] [stderr] 1240 | target_ty_hack: target_ty_hack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_ty_hack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1241:4 [INFO] [stderr] | [INFO] [stderr] 1241 | target_ty_hack_erased: target_ty_hack_erased, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_ty_hack_erased` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1572:5 [INFO] [stderr] | [INFO] [stderr] 1572 | leading_colon: leading_colon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `leading_colon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1175:3 [INFO] [stderr] | [INFO] [stderr] 1175 | if subrental.is_some() { [INFO] [stderr] | _________^ [INFO] [stderr] 1176 | | if match target_ty_hack { [INFO] [stderr] 1177 | | Some(syn::Type::Path(ref ty_path)) => ty_path.qself.is_some(), [INFO] [stderr] 1178 | | Some(_) => true, [INFO] [stderr] ... | [INFO] [stderr] 1186 | | } [INFO] [stderr] 1187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1175 | if subrental.is_some() && match target_ty_hack { [INFO] [stderr] 1176 | Some(syn::Type::Path(ref ty_path)) => ty_path.qself.is_some(), [INFO] [stderr] 1177 | Some(_) => true, [INFO] [stderr] 1178 | _ => false, [INFO] [stderr] 1179 | } { [INFO] [stderr] 1180 | panic!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1175:3 [INFO] [stderr] | [INFO] [stderr] 1175 | if subrental.is_some() { [INFO] [stderr] | _________^ [INFO] [stderr] 1176 | | if match target_ty_hack { [INFO] [stderr] 1177 | | Some(syn::Type::Path(ref ty_path)) => ty_path.qself.is_some(), [INFO] [stderr] 1178 | | Some(_) => true, [INFO] [stderr] ... | [INFO] [stderr] 1186 | | } [INFO] [stderr] 1187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1175 | if subrental.is_some() && match target_ty_hack { [INFO] [stderr] 1176 | Some(syn::Type::Path(ref ty_path)) => ty_path.qself.is_some(), [INFO] [stderr] 1177 | Some(_) => true, [INFO] [stderr] 1178 | _ => false, [INFO] [stderr] 1179 | } { [INFO] [stderr] 1180 | panic!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | for arity in 2 .. max_arity + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `2..=max_arity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 172 [INFO] [stderr] --> src/lib.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | / fn write_rental_struct_and_impls(tokens: &mut proc_macro2::TokenStream, struct_info: &syn::ItemStruct) { [INFO] [stderr] 102 | | let def_site: Span = Span::call_site(); // FIXME: hygiene [INFO] [stderr] 103 | | let call_site: Span = Span::call_site(); [INFO] [stderr] 104 | | [INFO] [stderr] ... | [INFO] [stderr] 877 | | } [INFO] [stderr] 878 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | for arity in 2 .. max_arity + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `2..=max_arity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 172 [INFO] [stderr] --> src/lib.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | / fn write_rental_struct_and_impls(tokens: &mut proc_macro2::TokenStream, struct_info: &syn::ItemStruct) { [INFO] [stderr] 102 | | let def_site: Span = Span::call_site(); // FIXME: hygiene [INFO] [stderr] 103 | | let call_site: Span = Span::call_site(); [INFO] [stderr] 104 | | [INFO] [stderr] ... | [INFO] [stderr] 877 | | } [INFO] [stderr] 878 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:807:9 [INFO] [stderr] | [INFO] [stderr] 807 | if mapped_param.bounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!mapped_param.bounds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:893:128 [INFO] [stderr] | [INFO] [stderr] 893 | if let Some(rental_pos) = rattribs.iter()/*.filter(|attr| !attr.is_sugared_doc)*/.position(|attr| match attr.interpret_meta().expect(&format!("Struct `{}` Attribute `{}` is not properly formatted.", struct_info.ident, attr.path.clone().into_token_stream())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Struct `{}` Attribute `{}` is not properly formatted.", struct_info.ident))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:807:9 [INFO] [stderr] | [INFO] [stderr] 807 | if mapped_param.bounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!mapped_param.bounds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:948:15 [INFO] [stderr] | [INFO] [stderr] 948 | if ty_param.ident.to_string() == ty_param_str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ty_param.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:962:92 [INFO] [stderr] | [INFO] [stderr] 962 | if struct_info.fields.iter().take(struct_info.fields.iter().count() - 1).any(|f| { [INFO] [stderr] | __________________________________________________________________________________________________________________________^ [INFO] [stderr] 963 | | finder.found = false; [INFO] [stderr] 964 | | finder.visit_field(f); [INFO] [stderr] 965 | | finder.found [INFO] [stderr] 966 | | }) { [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:893:128 [INFO] [stderr] | [INFO] [stderr] 893 | if let Some(rental_pos) = rattribs.iter()/*.filter(|attr| !attr.is_sugared_doc)*/.position(|attr| match attr.interpret_meta().expect(&format!("Struct `{}` Attribute `{}` is not properly formatted.", struct_info.ident, attr.path.clone().into_token_stream())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Struct `{}` Attribute `{}` is not properly formatted.", struct_info.ident))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:948:15 [INFO] [stderr] | [INFO] [stderr] 948 | if ty_param.ident.to_string() == ty_param_str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ty_param.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 58 [INFO] [stderr] --> src/lib.rs:1252:26 [INFO] [stderr] | [INFO] [stderr] 1252 | (0 .. fields.len()).map(|idx| { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 1253 | | let (field_ty, deref) = if idx == fields.len() - 1 { [INFO] [stderr] 1254 | | let orig_ty = &fields[idx].orig_ty; [INFO] [stderr] 1255 | | ( [INFO] [stderr] ... | [INFO] [stderr] 1416 | | } [INFO] [stderr] 1417 | | }).collect() [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:962:92 [INFO] [stderr] | [INFO] [stderr] 962 | if struct_info.fields.iter().take(struct_info.fields.iter().count() - 1).any(|f| { [INFO] [stderr] | __________________________________________________________________________________________________________________________^ [INFO] [stderr] 963 | | finder.found = false; [INFO] [stderr] 964 | | finder.visit_field(f); [INFO] [stderr] 965 | | finder.found [INFO] [stderr] 966 | | }) { [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 58 [INFO] [stderr] --> src/lib.rs:1252:26 [INFO] [stderr] | [INFO] [stderr] 1252 | (0 .. fields.len()).map(|idx| { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 1253 | | let (field_ty, deref) = if idx == fields.len() - 1 { [INFO] [stderr] 1254 | | let orig_ty = &fields[idx].orig_ty; [INFO] [stderr] 1255 | | ( [INFO] [stderr] ... | [INFO] [stderr] 1416 | | } [INFO] [stderr] 1417 | | }).collect() [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.05s [INFO] running `"docker" "inspect" "636f943bedd36139c854faf8534270a3e288c44608d32c673831b2999a36cd66"` [INFO] running `"docker" "rm" "-f" "636f943bedd36139c854faf8534270a3e288c44608d32c673831b2999a36cd66"` [INFO] [stdout] 636f943bedd36139c854faf8534270a3e288c44608d32c673831b2999a36cd66