[INFO] crate rench 0.3.0 is already in cache [INFO] extracting crate rench 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rench/0.3.0 [INFO] extracting crate rench 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rench/0.3.0 [INFO] validating manifest of rench-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rench-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rench-0.3.0 [INFO] finished frobbing rench-0.3.0 [INFO] frobbed toml for rench-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rench/0.3.0/Cargo.toml [INFO] started frobbing rench-0.3.0 [INFO] finished frobbing rench-0.3.0 [INFO] frobbed toml for rench-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rench/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rench-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rench/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b218ef2c3058083d95e480f68b5a73f678ae2b524225b5b10ed99fe1aed8e1d [INFO] running `"docker" "start" "-a" "5b218ef2c3058083d95e480f68b5a73f678ae2b524225b5b10ed99fe1aed8e1d"` [INFO] [stderr] Checking rench v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stats.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stats.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stats.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | assert_eq!(Duration::new(1, 500000).to_ms(), 1000.5f64); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stats.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | let ms: MS = Duration::new(1, 500000).into(); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stats.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(duration, Duration::new(1, 500000)); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stats.rs:369:54 [INFO] [stderr] | [INFO] [stderr] 369 | assert_eq!(summary.average, Duration::new(2, 500000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stats.rs:381:53 [INFO] [stderr] | [INFO] [stderr] 381 | assert_eq!(summary.stddev, Duration::new(1, 290994448)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `290_994_448` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stats.rs:405:53 [INFO] [stderr] | [INFO] [stderr] 405 | assert_eq!(summary.median, Duration::new(2, 500000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/chart.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let data: Vec = data.into_iter().map(|d| d.clone().into()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/chart.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let data: Vec = data.into_iter().map(|d| d.clone().into()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/chart.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | let chart = Chart::new().make(&vec![1, 2, 3, 4, 3, 2, 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 4, 3, 2, 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/chart.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | let chart = Chart::new().height(4).make(&vec![1, 2, 3, 4, 3, 2, 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 4, 3, 2, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/stats.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | assert_eq!(Duration::new(1, 500000).to_ms(), 1000.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/stats.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | assert_eq!(Duration::new(1, 500000).to_ms(), 1000.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rench`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5b218ef2c3058083d95e480f68b5a73f678ae2b524225b5b10ed99fe1aed8e1d"` [INFO] running `"docker" "rm" "-f" "5b218ef2c3058083d95e480f68b5a73f678ae2b524225b5b10ed99fe1aed8e1d"` [INFO] [stdout] 5b218ef2c3058083d95e480f68b5a73f678ae2b524225b5b10ed99fe1aed8e1d