[INFO] crate relegram 0.1.4 is already in cache [INFO] extracting crate relegram 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/relegram/0.1.4 [INFO] extracting crate relegram 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/relegram/0.1.4 [INFO] validating manifest of relegram-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of relegram-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing relegram-0.1.4 [INFO] finished frobbing relegram-0.1.4 [INFO] frobbed toml for relegram-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/relegram/0.1.4/Cargo.toml [INFO] started frobbing relegram-0.1.4 [INFO] finished frobbing relegram-0.1.4 [INFO] frobbed toml for relegram-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/relegram/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting relegram-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/relegram/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a62a5b4ff1b28ad4ebc9aa9e5aa190614f10f2d0c0f14bf597d3149ccf964520 [INFO] running `"docker" "start" "-a" "a62a5b4ff1b28ad4ebc9aa9e5aa190614f10f2d0c0f14bf597d3149ccf964520"` [INFO] [stderr] Checking relegram v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/responses/message.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | return Err(UnexpectedResponse::ConvertError(String::from("Tried all kind of messages. If this happens, probably there is bug in lib"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(UnexpectedResponse::ConvertError(String::from("Tried all kind of messages. If this happens, probably there is bug in lib")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | const BASE_API_URI: &'static str = "https://api.telegram.org/bot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | const GET_FILE_URI: &'static str = "https://api.telegram.org/file/bot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/responses/message.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | return Err(UnexpectedResponse::ConvertError(String::from("Tried all kind of messages. If this happens, probably there is bug in lib"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(UnexpectedResponse::ConvertError(String::from("Tried all kind of messages. If this happens, probably there is bug in lib")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | const BASE_API_URI: &'static str = "https://api.telegram.org/bot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | const GET_FILE_URI: &'static str = "https://api.telegram.org/file/bot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `requests::get_updates::GetUpdatesRequest` [INFO] [stderr] --> src/requests/get_updates.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> GetUpdatesRequest { [INFO] [stderr] 40 | | GetUpdatesRequest { [INFO] [stderr] 41 | | offset: None, [INFO] [stderr] 42 | | limit: None, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/responses/message.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | Game { game: Game }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 95 | Game { game: Box }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (32/7) [INFO] [stderr] --> src/responses/message.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | / fn try_into_message_kind(text: Option, [INFO] [stderr] 172 | | media_group_id: Option, [INFO] [stderr] 173 | | entities: Option>, [INFO] [stderr] 174 | | caption: Option, [INFO] [stderr] ... | [INFO] [stderr] 350 | | return Err(UnexpectedResponse::ConvertError(String::from("Tried all kind of messages. If this happens, probably there is bug in lib"))); [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/responses/message.rs:242:91 [INFO] [stderr] | [INFO] [stderr] 242 | MessageEntity::TextMention { mention: captured, user: From::from(user) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `user` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | if let Some(_) = delete_chat_photo { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 317 | | return Ok(MessageKind::DeleteChatPhoto); [INFO] [stderr] 318 | | } [INFO] [stderr] | |_________________- help: try this: `if delete_chat_photo.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:319:24 [INFO] [stderr] | [INFO] [stderr] 319 | if let Some(_) = group_chat_created { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 320 | | return Ok(MessageKind::GroupChatCreated); [INFO] [stderr] 321 | | } [INFO] [stderr] | |_________________- help: try this: `if group_chat_created.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:322:24 [INFO] [stderr] | [INFO] [stderr] 322 | if let Some(_) = supergroup_chat_created { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 323 | | return Ok(MessageKind::SuperGroupChatCreated); [INFO] [stderr] 324 | | } [INFO] [stderr] | |_________________- help: try this: `if supergroup_chat_created.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:325:24 [INFO] [stderr] | [INFO] [stderr] 325 | if let Some(_) = channel_chat_created { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 326 | | return Ok(MessageKind::ChannelChatCreated); [INFO] [stderr] 327 | | } [INFO] [stderr] | |_________________- help: try this: `if channel_chat_created.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `requests::get_updates::GetUpdatesRequest` [INFO] [stderr] --> src/requests/get_updates.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> GetUpdatesRequest { [INFO] [stderr] 40 | | GetUpdatesRequest { [INFO] [stderr] 41 | | offset: None, [INFO] [stderr] 42 | | limit: None, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/responses/message.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | Game { game: Game }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 95 | Game { game: Box }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (32/7) [INFO] [stderr] --> src/responses/message.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | / fn try_into_message_kind(text: Option, [INFO] [stderr] 172 | | media_group_id: Option, [INFO] [stderr] 173 | | entities: Option>, [INFO] [stderr] 174 | | caption: Option, [INFO] [stderr] ... | [INFO] [stderr] 350 | | return Err(UnexpectedResponse::ConvertError(String::from("Tried all kind of messages. If this happens, probably there is bug in lib"))); [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/responses/message.rs:242:91 [INFO] [stderr] | [INFO] [stderr] 242 | MessageEntity::TextMention { mention: captured, user: From::from(user) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `user` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | if let Some(_) = delete_chat_photo { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 317 | | return Ok(MessageKind::DeleteChatPhoto); [INFO] [stderr] 318 | | } [INFO] [stderr] | |_________________- help: try this: `if delete_chat_photo.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:319:24 [INFO] [stderr] | [INFO] [stderr] 319 | if let Some(_) = group_chat_created { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 320 | | return Ok(MessageKind::GroupChatCreated); [INFO] [stderr] 321 | | } [INFO] [stderr] | |_________________- help: try this: `if group_chat_created.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:322:24 [INFO] [stderr] | [INFO] [stderr] 322 | if let Some(_) = supergroup_chat_created { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 323 | | return Ok(MessageKind::SuperGroupChatCreated); [INFO] [stderr] 324 | | } [INFO] [stderr] | |_________________- help: try this: `if supergroup_chat_created.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/responses/message.rs:325:24 [INFO] [stderr] | [INFO] [stderr] 325 | if let Some(_) = channel_chat_created { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 326 | | return Ok(MessageKind::ChannelChatCreated); [INFO] [stderr] 327 | | } [INFO] [stderr] | |_________________- help: try this: `if channel_chat_created.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/responses/update.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | CallbackQuery(CallbackQuery), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | CallbackQuery(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/api.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | let timeout = Duration::from_secs(request.timeout.map(|x| max(x * 2, 10)).unwrap_or(10) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(request.timeout.map(|x| max(x * 2, 10)).unwrap_or(10))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/api.rs:162:38 [INFO] [stderr] | [INFO] [stderr] 162 | .unwrap_or(Error::Unknown(String::from("Error while converting tg response to utf8 string")))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Error::Unknown(String::from("Error while converting tg response to utf8 string")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/api.rs:170:30 [INFO] [stderr] | [INFO] [stderr] 170 | .unwrap_or(Error::Unknown(String::from("Error while converting tg response to utf8 string")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Error::Unknown(String::from("Error while converting tg response to utf8 string")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/responses/update.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | CallbackQuery(CallbackQuery), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | CallbackQuery(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/api.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | let timeout = Duration::from_secs(request.timeout.map(|x| max(x * 2, 10)).unwrap_or(10) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(request.timeout.map(|x| max(x * 2, 10)).unwrap_or(10))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/api.rs:162:38 [INFO] [stderr] | [INFO] [stderr] 162 | .unwrap_or(Error::Unknown(String::from("Error while converting tg response to utf8 string")))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Error::Unknown(String::from("Error while converting tg response to utf8 string")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/api.rs:170:30 [INFO] [stderr] | [INFO] [stderr] 170 | .unwrap_or(Error::Unknown(String::from("Error while converting tg response to utf8 string")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Error::Unknown(String::from("Error while converting tg response to utf8 string")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.48s [INFO] running `"docker" "inspect" "a62a5b4ff1b28ad4ebc9aa9e5aa190614f10f2d0c0f14bf597d3149ccf964520"` [INFO] running `"docker" "rm" "-f" "a62a5b4ff1b28ad4ebc9aa9e5aa190614f10f2d0c0f14bf597d3149ccf964520"` [INFO] [stdout] a62a5b4ff1b28ad4ebc9aa9e5aa190614f10f2d0c0f14bf597d3149ccf964520