[INFO] crate relative-path 0.4.0 is already in cache [INFO] extracting crate relative-path 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/relative-path/0.4.0 [INFO] extracting crate relative-path 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/relative-path/0.4.0 [INFO] validating manifest of relative-path-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of relative-path-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing relative-path-0.4.0 [INFO] finished frobbing relative-path-0.4.0 [INFO] frobbed toml for relative-path-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/relative-path/0.4.0/Cargo.toml [INFO] started frobbing relative-path-0.4.0 [INFO] finished frobbing relative-path-0.4.0 [INFO] frobbed toml for relative-path-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/relative-path/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting relative-path-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/relative-path/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34692e6c0f94941bb45942337b470f1467e03e25c25378bc51421fb100db2819 [INFO] running `"docker" "start" "-a" "34692e6c0f94941bb45942337b470f1467e03e25c25378bc51421fb100db2819"` [INFO] [stderr] Checking relative-path v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:507:9 [INFO] [stderr] | [INFO] [stderr] 507 | / if self.file_name().is_some() { [INFO] [stderr] 508 | | if !self.pop() { [INFO] [stderr] 509 | | self.inner = file_name.to_string(); [INFO] [stderr] 510 | | return; [INFO] [stderr] 511 | | } [INFO] [stderr] 512 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 507 | if self.file_name().is_some() && !self.pop() { [INFO] [stderr] 508 | self.inner = file_name.to_string(); [INFO] [stderr] 509 | return; [INFO] [stderr] 510 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:465:12 [INFO] [stderr] | [INFO] [stderr] 465 | if self.inner.len() > 0 && !self.ends_with_sep() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.inner.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:732:5 [INFO] [stderr] | [INFO] [stderr] 732 | / pub fn from_path<'a, P: ?Sized + AsRef>( [INFO] [stderr] 733 | | path: &'a P, [INFO] [stderr] 734 | | ) -> Result<&'a RelativePath, FromPathError> { [INFO] [stderr] 735 | | use path::Component::*; [INFO] [stderr] ... | [INFO] [stderr] 757 | | Ok(rel) [INFO] [stderr] 758 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:507:9 [INFO] [stderr] | [INFO] [stderr] 507 | / if self.file_name().is_some() { [INFO] [stderr] 508 | | if !self.pop() { [INFO] [stderr] 509 | | self.inner = file_name.to_string(); [INFO] [stderr] 510 | | return; [INFO] [stderr] 511 | | } [INFO] [stderr] 512 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 507 | if self.file_name().is_some() && !self.pop() { [INFO] [stderr] 508 | self.inner = file_name.to_string(); [INFO] [stderr] 509 | return; [INFO] [stderr] 510 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:465:12 [INFO] [stderr] | [INFO] [stderr] 465 | if self.inner.len() > 0 && !self.ends_with_sep() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.inner.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:732:5 [INFO] [stderr] | [INFO] [stderr] 732 | / pub fn from_path<'a, P: ?Sized + AsRef>( [INFO] [stderr] 733 | | path: &'a P, [INFO] [stderr] 734 | | ) -> Result<&'a RelativePath, FromPathError> { [INFO] [stderr] 735 | | use path::Component::*; [INFO] [stderr] ... | [INFO] [stderr] 757 | | Ok(rel) [INFO] [stderr] 758 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 163 [INFO] [stderr] --> src/lib.rs:1489:5 [INFO] [stderr] | [INFO] [stderr] 1489 | / pub fn test_decompositions() { [INFO] [stderr] 1490 | | t!("", [INFO] [stderr] 1491 | | iter: [], [INFO] [stderr] 1492 | | parent: None, [INFO] [stderr] ... | [INFO] [stderr] 1704 | | ); [INFO] [stderr] 1705 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 41 [INFO] [stderr] --> src/lib.rs:1826:5 [INFO] [stderr] | [INFO] [stderr] 1826 | / pub fn test_compare() { [INFO] [stderr] 1827 | | use std::collections::hash_map::DefaultHasher; [INFO] [stderr] 1828 | | use std::hash::{Hash, Hasher}; [INFO] [stderr] 1829 | | [INFO] [stderr] ... | [INFO] [stderr] 1924 | | ); [INFO] [stderr] 1925 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.03s [INFO] running `"docker" "inspect" "34692e6c0f94941bb45942337b470f1467e03e25c25378bc51421fb100db2819"` [INFO] running `"docker" "rm" "-f" "34692e6c0f94941bb45942337b470f1467e03e25c25378bc51421fb100db2819"` [INFO] [stdout] 34692e6c0f94941bb45942337b470f1467e03e25c25378bc51421fb100db2819