[INFO] crate reki3 0.0.2 is already in cache
[INFO] extracting crate reki3 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/reki3/0.0.2
[INFO] extracting crate reki3 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reki3/0.0.2
[INFO] validating manifest of reki3-0.0.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of reki3-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing reki3-0.0.2
[INFO] finished frobbing reki3-0.0.2
[INFO] frobbed toml for reki3-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/reki3/0.0.2/Cargo.toml
[INFO] started frobbing reki3-0.0.2
[INFO] finished frobbing reki3-0.0.2
[INFO] frobbed toml for reki3-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reki3/0.0.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting reki3-0.0.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reki3/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b609f6327b0992df938ca9b322712389ee7b236ec227e655a8c2a204285b627c
[INFO] running `"docker" "start" "-a" "b609f6327b0992df938ca9b322712389ee7b236ec227e655a8c2a204285b627c"`
[INFO] [stderr]     Checking redis v0.5.4
[INFO] [stderr]     Checking hyper v0.8.1
[INFO] [stderr]     Checking reki3 v0.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 |         announce_interval: announce_interval,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `announce_interval`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         drop_threshold: drop_threshold,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `drop_threshold`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         completion_website: completion_website,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completion_website`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 |         announce_interval: announce_interval,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `announce_interval`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         drop_threshold: drop_threshold,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `drop_threshold`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         completion_website: completion_website,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completion_website`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/announce.rs:192:5
[INFO] [stderr]     |
[INFO] [stderr] 192 |     return Ok(response);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(response)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/announce.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 |     return retval;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return Ok(output);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return output;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/announce.rs:192:5
[INFO] [stderr]     |
[INFO] [stderr] 192 |     return Ok(response);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(response)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/common.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return retval;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/common.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     return Ok(hexstring(&info_hash_binary));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hexstring(&info_hash_binary))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/announce.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 |     return retval;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return Ok(output);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return output;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/common.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return retval;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/common.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     return Ok(hexstring(&info_hash_binary));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hexstring(&info_hash_binary))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/announce.rs:25:1
[INFO] [stderr]     |
[INFO] [stderr] 25  | / pub fn announce(req: &Request, redis_connection: &Mutex<redis::Connection>,
[INFO] [stderr] 26  | |     announce_interval: u32,
[INFO] [stderr] 27  | |     drop_threshold: u32,
[INFO] [stderr] 28  | |     completion_website: &Option<String>) -> Result<Vec<u8>, String>
[INFO] [stderr] ...   |
[INFO] [stderr] 192 | |     return Ok(response);
[INFO] [stderr] 193 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/announce.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 or(query_hashmap.get("ip")).
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| query_hashmap.get("ip"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/announce.rs:113:17
[INFO] [stderr]     |
[INFO] [stderr] 113 |     let ip = ip.unwrap_or(req.remote_addr.ip());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| req.remote_addr.ip())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/announce.rs:25:1
[INFO] [stderr]     |
[INFO] [stderr] 25  | / pub fn announce(req: &Request, redis_connection: &Mutex<redis::Connection>,
[INFO] [stderr] 26  | |     announce_interval: u32,
[INFO] [stderr] 27  | |     drop_threshold: u32,
[INFO] [stderr] 28  | |     completion_website: &Option<String>) -> Result<Vec<u8>, String>
[INFO] [stderr] ...   |
[INFO] [stderr] 192 | |     return Ok(response);
[INFO] [stderr] 193 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/announce.rs:126:32
[INFO] [stderr]     |
[INFO] [stderr] 126 |     let time_drop = time_now - (drop_threshold as i64)*1000;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(drop_threshold)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/common.rs:16:47
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let mut input_iterator = input.as_bytes().into_iter();
[INFO] [stderr]    |                                               ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/common.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match i {
[INFO] [stderr] 19 | |             &b'%' => {
[INFO] [stderr] 20 | |                 let hexdigit1 = input_iterator.next()
[INFO] [stderr] 21 | |                     .and_then(|h| from_hex(*h));
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |             }
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |         match *i {
[INFO] [stderr] 19 |             b'%' => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/common.rs:80:16
[INFO] [stderr]    |
[INFO] [stderr] 80 |       let path = match uri {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 81 | |         &RequestUri::AbsolutePath(ref i) => i,
[INFO] [stderr] 82 | |         _ => return retval,
[INFO] [stderr] 83 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 80 |     let path = match *uri {
[INFO] [stderr] 81 |         RequestUri::AbsolutePath(ref i) => i,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/common.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 | /         match component.find('=') {
[INFO] [stderr] 93 | |             Some(position) => {
[INFO] [stderr] 94 | |                 retval.insert(&component[..position], &component[position + 1..]);
[INFO] [stderr] 95 | |             }
[INFO] [stderr] 96 | |             None => {},
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 92 |         if let Some(position) = component.find('=') {
[INFO] [stderr] 93 |     retval.insert(&component[..position], &component[position + 1..]);
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:86:10
[INFO] [stderr]    |
[INFO] [stderr] 86 |         .unwrap_or("9001".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "9001".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:90:10
[INFO] [stderr]    |
[INFO] [stderr] 90 |         .unwrap_or("0.0.0.0".to_owned());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "0.0.0.0".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:92:10
[INFO] [stderr]    |
[INFO] [stderr] 92 |         .unwrap_or("redis://127.0.0.1/".to_owned());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "redis://127.0.0.1/".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:94:10
[INFO] [stderr]    |
[INFO] [stderr] 94 |         .unwrap_or("10".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "10".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:98:10
[INFO] [stderr]    |
[INFO] [stderr] 98 |         .unwrap_or("1800".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1800".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:102:10
[INFO] [stderr]     |
[INFO] [stderr] 102 |         .unwrap_or("3600".to_owned())
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "3600".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/announce.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 or(query_hashmap.get("ip")).
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| query_hashmap.get("ip"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/announce.rs:113:17
[INFO] [stderr]     |
[INFO] [stderr] 113 |     let ip = ip.unwrap_or(req.remote_addr.ip());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| req.remote_addr.ip())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:128:10
[INFO] [stderr]     |
[INFO] [stderr] 128 |         .expect(&format!("Unable to open connection to Redis ({})", redis_url));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open connection to Redis ({})", redis_url))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/announce.rs:126:32
[INFO] [stderr]     |
[INFO] [stderr] 126 |     let time_drop = time_now - (drop_threshold as i64)*1000;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(drop_threshold)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/common.rs:16:47
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let mut input_iterator = input.as_bytes().into_iter();
[INFO] [stderr]    |                                               ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/common.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match i {
[INFO] [stderr] 19 | |             &b'%' => {
[INFO] [stderr] 20 | |                 let hexdigit1 = input_iterator.next()
[INFO] [stderr] 21 | |                     .and_then(|h| from_hex(*h));
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |             }
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |         match *i {
[INFO] [stderr] 19 |             b'%' => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/common.rs:80:16
[INFO] [stderr]    |
[INFO] [stderr] 80 |       let path = match uri {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 81 | |         &RequestUri::AbsolutePath(ref i) => i,
[INFO] [stderr] 82 | |         _ => return retval,
[INFO] [stderr] 83 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 80 |     let path = match *uri {
[INFO] [stderr] 81 |         RequestUri::AbsolutePath(ref i) => i,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/common.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 | /         match component.find('=') {
[INFO] [stderr] 93 | |             Some(position) => {
[INFO] [stderr] 94 | |                 retval.insert(&component[..position], &component[position + 1..]);
[INFO] [stderr] 95 | |             }
[INFO] [stderr] 96 | |             None => {},
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 92 |         if let Some(position) = component.find('=') {
[INFO] [stderr] 93 |     retval.insert(&component[..position], &component[position + 1..]);
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/common.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |     assert_eq!(*hmap.get("param").unwrap(), "hello");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hmap["param"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/common.rs:109:17
[INFO] [stderr]     |
[INFO] [stderr] 109 |     assert_eq!(*hmap.get("something").unwrap(), "world");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hmap["something"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/common.rs:110:17
[INFO] [stderr]     |
[INFO] [stderr] 110 |     assert_eq!(*hmap.get("n").unwrap(), "");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hmap["n"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:86:10
[INFO] [stderr]    |
[INFO] [stderr] 86 |         .unwrap_or("9001".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "9001".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:90:10
[INFO] [stderr]    |
[INFO] [stderr] 90 |         .unwrap_or("0.0.0.0".to_owned());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "0.0.0.0".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:92:10
[INFO] [stderr]    |
[INFO] [stderr] 92 |         .unwrap_or("redis://127.0.0.1/".to_owned());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "redis://127.0.0.1/".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:94:10
[INFO] [stderr]    |
[INFO] [stderr] 94 |         .unwrap_or("10".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "10".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:98:10
[INFO] [stderr]    |
[INFO] [stderr] 98 |         .unwrap_or("1800".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1800".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:102:10
[INFO] [stderr]     |
[INFO] [stderr] 102 |         .unwrap_or("3600".to_owned())
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "3600".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:128:10
[INFO] [stderr]     |
[INFO] [stderr] 128 |         .expect(&format!("Unable to open connection to Redis ({})", redis_url));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open connection to Redis ({})", redis_url))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.41s
[INFO] running `"docker" "inspect" "b609f6327b0992df938ca9b322712389ee7b236ec227e655a8c2a204285b627c"`
[INFO] running `"docker" "rm" "-f" "b609f6327b0992df938ca9b322712389ee7b236ec227e655a8c2a204285b627c"`
[INFO] [stdout] b609f6327b0992df938ca9b322712389ee7b236ec227e655a8c2a204285b627c