[INFO] crate regex_generate 0.2.0 is already in cache [INFO] extracting crate regex_generate 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/regex_generate/0.2.0 [INFO] extracting crate regex_generate 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/regex_generate/0.2.0 [INFO] validating manifest of regex_generate-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of regex_generate-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing regex_generate-0.2.0 [INFO] finished frobbing regex_generate-0.2.0 [INFO] frobbed toml for regex_generate-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/regex_generate/0.2.0/Cargo.toml [INFO] started frobbing regex_generate-0.2.0 [INFO] finished frobbing regex_generate-0.2.0 [INFO] frobbed toml for regex_generate-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/regex_generate/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting regex_generate-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/regex_generate/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 649598eb855524d91d7a091775af60e157a5826398e647b3f9bfb70fec3474dd [INFO] running `"docker" "start" "-a" "649598eb855524d91d7a091775af60e157a5826398e647b3f9bfb70fec3474dd"` [INFO] [stderr] Checking regex_generate v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | max_repeat: max_repeat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | max_repeat: max_repeat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | &Expr::Literal{ref chars, casei:_} => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Literal { ref chars, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:92:38 [INFO] [stderr] | [INFO] [stderr] 92 | &Expr::Group{e: ref exp, i:_, name:_} => Self::generate_from_expr(buffer, exp, rng, max_repeat), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:92:43 [INFO] [stderr] | [INFO] [stderr] 92 | &Expr::Group{e: ref exp, i:_, name:_} => Self::generate_from_expr(buffer, exp, rng, max_repeat), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Group { e: ref exp, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:130:44 [INFO] [stderr] | [INFO] [stderr] 130 | &Expr::LiteralBytes{ref bytes, casei:_} => buffer.write(bytes).and(Ok(())) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `LiteralBytes { ref bytes, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | buffer.write(&b[0..sl])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match expr { [INFO] [stderr] 58 | | &Expr::Empty | [INFO] [stderr] 59 | | &Expr::StartText | [INFO] [stderr] 60 | | &Expr::EndText | [INFO] [stderr] ... | [INFO] [stderr] 131 | | .chain_err(|| "failed to write literal bytes"), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *expr { [INFO] [stderr] 58 | Expr::Empty | [INFO] [stderr] 59 | Expr::StartText | [INFO] [stderr] 60 | Expr::EndText | [INFO] [stderr] 61 | Expr::WordBoundary | [INFO] [stderr] 62 | Expr::NotWordBoundary | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | let ref exp = exps[idx]; [INFO] [stderr] | ----^^^^^^^------------- help: try: `let exp = &exps[idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:109:92 [INFO] [stderr] | [INFO] [stderr] 109 | Repeater::Range{min, max:None} => if greedy { min..max_repeat } else { min..(min + 1) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `min..=min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:110:72 [INFO] [stderr] | [INFO] [stderr] 110 | Repeater::Range{min, max:Some(max)} => if greedy { min..(max + 1) } else { min..(min + 1) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `min..=max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:110:96 [INFO] [stderr] | [INFO] [stderr] 110 | Repeater::Range{min, max:Some(max)} => if greedy { min..(max + 1) } else { min..(min + 1) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `min..=min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `regex_generate`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | &Expr::Literal{ref chars, casei:_} => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Literal { ref chars, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:92:38 [INFO] [stderr] | [INFO] [stderr] 92 | &Expr::Group{e: ref exp, i:_, name:_} => Self::generate_from_expr(buffer, exp, rng, max_repeat), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:92:43 [INFO] [stderr] | [INFO] [stderr] 92 | &Expr::Group{e: ref exp, i:_, name:_} => Self::generate_from_expr(buffer, exp, rng, max_repeat), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Group { e: ref exp, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:130:44 [INFO] [stderr] | [INFO] [stderr] 130 | &Expr::LiteralBytes{ref bytes, casei:_} => buffer.write(bytes).and(Ok(())) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `LiteralBytes { ref bytes, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `regex_syntax::Expr` [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | use regex_syntax::Expr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | buffer.write(&b[0..sl])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match expr { [INFO] [stderr] 58 | | &Expr::Empty | [INFO] [stderr] 59 | | &Expr::StartText | [INFO] [stderr] 60 | | &Expr::EndText | [INFO] [stderr] ... | [INFO] [stderr] 131 | | .chain_err(|| "failed to write literal bytes"), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *expr { [INFO] [stderr] 58 | Expr::Empty | [INFO] [stderr] 59 | Expr::StartText | [INFO] [stderr] 60 | Expr::EndText | [INFO] [stderr] 61 | Expr::WordBoundary | [INFO] [stderr] 62 | Expr::NotWordBoundary | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | let ref exp = exps[idx]; [INFO] [stderr] | ----^^^^^^^------------- help: try: `let exp = &exps[idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:109:92 [INFO] [stderr] | [INFO] [stderr] 109 | Repeater::Range{min, max:None} => if greedy { min..max_repeat } else { min..(min + 1) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `min..=min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:110:72 [INFO] [stderr] | [INFO] [stderr] 110 | Repeater::Range{min, max:Some(max)} => if greedy { min..(max + 1) } else { min..(min + 1) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `min..=max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:110:96 [INFO] [stderr] | [INFO] [stderr] 110 | Repeater::Range{min, max:Some(max)} => if greedy { min..(max + 1) } else { min..(min + 1) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `min..=min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `regex_generate`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "649598eb855524d91d7a091775af60e157a5826398e647b3f9bfb70fec3474dd"` [INFO] running `"docker" "rm" "-f" "649598eb855524d91d7a091775af60e157a5826398e647b3f9bfb70fec3474dd"` [INFO] [stdout] 649598eb855524d91d7a091775af60e157a5826398e647b3f9bfb70fec3474dd