[INFO] crate reflink 0.1.2 is already in cache [INFO] extracting crate reflink 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/reflink/0.1.2 [INFO] extracting crate reflink 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reflink/0.1.2 [INFO] validating manifest of reflink-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reflink-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reflink-0.1.2 [INFO] finished frobbing reflink-0.1.2 [INFO] frobbed toml for reflink-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/reflink/0.1.2/Cargo.toml [INFO] started frobbing reflink-0.1.2 [INFO] finished frobbing reflink-0.1.2 [INFO] frobbed toml for reflink-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reflink/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reflink-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reflink/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b51e0bad2db0b4cfa0f4d27fc2b3c839c06bf5aba3c0512d7fedcfdd30a84a35 [INFO] running `"docker" "start" "-a" "b51e0bad2db0b4cfa0f4d27fc2b3c839c06bf5aba3c0512d7fedcfdd30a84a35"` [INFO] [stderr] Checking reflink v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sys/unix.rs:12:32 [INFO] [stderr] | [INFO] [stderr] 12 | const IOCTL_FICLONE: u64 = 0x40049409; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4004_9409` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match reflink(&from, &to) { [INFO] [stderr] 58 | | Ok(()) => return Ok(None), [INFO] [stderr] 59 | | Err(_) => {}, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = reflink(&from, &to) { return Ok(None) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | fs::copy(from, to).map(|written| Some(written)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sys/unix.rs:12:32 [INFO] [stderr] | [INFO] [stderr] 12 | const IOCTL_FICLONE: u64 = 0x40049409; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4004_9409` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match reflink(&from, &to) { [INFO] [stderr] 58 | | Ok(()) => return Ok(None), [INFO] [stderr] 59 | | Err(_) => {}, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = reflink(&from, &to) { return Ok(None) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | fs::copy(from, to).map(|written| Some(written)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `"docker" "inspect" "b51e0bad2db0b4cfa0f4d27fc2b3c839c06bf5aba3c0512d7fedcfdd30a84a35"` [INFO] running `"docker" "rm" "-f" "b51e0bad2db0b4cfa0f4d27fc2b3c839c06bf5aba3c0512d7fedcfdd30a84a35"` [INFO] [stdout] b51e0bad2db0b4cfa0f4d27fc2b3c839c06bf5aba3c0512d7fedcfdd30a84a35