[INFO] crate reflection_derive 0.1.1 is already in cache [INFO] extracting crate reflection_derive 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/reflection_derive/0.1.1 [INFO] extracting crate reflection_derive 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reflection_derive/0.1.1 [INFO] validating manifest of reflection_derive-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reflection_derive-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reflection_derive-0.1.1 [INFO] finished frobbing reflection_derive-0.1.1 [INFO] frobbed toml for reflection_derive-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/reflection_derive/0.1.1/Cargo.toml [INFO] started frobbing reflection_derive-0.1.1 [INFO] finished frobbing reflection_derive-0.1.1 [INFO] frobbed toml for reflection_derive-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reflection_derive/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reflection_derive-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reflection_derive/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 775b31aa5e682cbdc9cdd0e93462c99f4a46f247dc379fa7062a0ebc09839977 [INFO] running `"docker" "start" "-a" "775b31aa5e682cbdc9cdd0e93462c99f4a46f247dc379fa7062a0ebc09839977"` [INFO] [stderr] Checking proc-macro2 v0.2.3 [INFO] [stderr] Checking quote v0.4.2 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Checking serde_derive_internals v0.21.0 [INFO] [stderr] Checking reflection_derive v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:87:55 [INFO] [stderr] | [INFO] [stderr] 87 | if let syn::Lit::Str( ref lit ) = *&m.lit { [INFO] [stderr] | ^^^^^^^ help: try this: `m.lit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:151:47 [INFO] [stderr] | [INFO] [stderr] 151 | None => { i += 1; return (i-1).to_string() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(i-1).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:87:55 [INFO] [stderr] | [INFO] [stderr] 87 | if let syn::Lit::Str( ref lit ) = *&m.lit { [INFO] [stderr] | ^^^^^^^ help: try this: `m.lit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:151:47 [INFO] [stderr] | [INFO] [stderr] 151 | None => { i += 1; return (i-1).to_string() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(i-1).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | fn is_skipped( attrs: &Vec ) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | fn is_skipped( attrs: &Vec ) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.54s [INFO] running `"docker" "inspect" "775b31aa5e682cbdc9cdd0e93462c99f4a46f247dc379fa7062a0ebc09839977"` [INFO] running `"docker" "rm" "-f" "775b31aa5e682cbdc9cdd0e93462c99f4a46f247dc379fa7062a0ebc09839977"` [INFO] [stdout] 775b31aa5e682cbdc9cdd0e93462c99f4a46f247dc379fa7062a0ebc09839977