[INFO] crate reflect 0.0.3 is already in cache [INFO] extracting crate reflect 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/reflect/0.0.3 [INFO] extracting crate reflect 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reflect/0.0.3 [INFO] validating manifest of reflect-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reflect-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reflect-0.0.3 [INFO] finished frobbing reflect-0.0.3 [INFO] frobbed toml for reflect-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/reflect/0.0.3/Cargo.toml [INFO] started frobbing reflect-0.0.3 [INFO] finished frobbing reflect-0.0.3 [INFO] frobbed toml for reflect-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reflect/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reflect-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reflect/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3643838b841dde8dc0e76c5628d8cc40633158db1990947004f91bb92a7d8741 [INFO] running `"docker" "start" "-a" "3643838b841dde8dc0e76c5628d8cc40633158db1990947004f91bb92a7d8741"` [INFO] [stderr] Compiling ref-cast-impl v0.2.5 [INFO] [stderr] Checking ref-cast v0.2.5 [INFO] [stderr] Checking reflect v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:11 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:35 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: lint name `for_loop_over_option` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:56 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::for_loop_over_option` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:11 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:35 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: lint name `for_loop_over_option` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:56 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::for_loop_over_option` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:11 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:323:11 [INFO] [stderr] | [INFO] [stderr] 323 | allow(needless_pass_by_value, new_without_default, for_loop_over_option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:326:1 [INFO] [stderr] | [INFO] [stderr] 326 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:326:1 [INFO] [stderr] | [INFO] [stderr] 326 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/derive.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/derive.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/test_debug.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | let input = TokenStream::from(quote! { [INFO] [stderr] | _________________^ [INFO] [stderr] 18 | | struct Point { [INFO] [stderr] 19 | | x: i32, [INFO] [stderr] 20 | | y: i32, [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `TokenStream::from()` [INFO] [stderr] | [INFO] [stderr] 17 | let input = quote! { [INFO] [stderr] 18 | struct Point { [INFO] [stderr] 19 | x: i32, [INFO] [stderr] 20 | y: i32, [INFO] [stderr] 21 | } [INFO] [stderr] 22 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/test_debug.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let expected = TokenStream::from(quote! { [INFO] [stderr] | ____________________^ [INFO] [stderr] 25 | | impl ::std::fmt::Debug for Point { [INFO] [stderr] 26 | | fn fmt(&self, __arg0: &mut ::std::fmt::Formatter) -> ::std::fmt::Result { [INFO] [stderr] 27 | | /* [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `TokenStream::from()` [INFO] [stderr] | [INFO] [stderr] 24 | let expected = quote! { [INFO] [stderr] 25 | impl ::std::fmt::Debug for Point { [INFO] [stderr] 26 | fn fmt(&self, __arg0: &mut ::std::fmt::Formatter) -> ::std::fmt::Result { [INFO] [stderr] 27 | /* [INFO] [stderr] 28 | // TODO: somewhat more intelligent impl [INFO] [stderr] 29 | match *self { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.86s [INFO] running `"docker" "inspect" "3643838b841dde8dc0e76c5628d8cc40633158db1990947004f91bb92a7d8741"` [INFO] running `"docker" "rm" "-f" "3643838b841dde8dc0e76c5628d8cc40633158db1990947004f91bb92a7d8741"` [INFO] [stdout] 3643838b841dde8dc0e76c5628d8cc40633158db1990947004f91bb92a7d8741