[INFO] crate redis_cluster_rs 0.1.5 is already in cache
[INFO] extracting crate redis_cluster_rs 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/redis_cluster_rs/0.1.5
[INFO] extracting crate redis_cluster_rs 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis_cluster_rs/0.1.5
[INFO] validating manifest of redis_cluster_rs-0.1.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of redis_cluster_rs-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing redis_cluster_rs-0.1.5
[INFO] finished frobbing redis_cluster_rs-0.1.5
[INFO] frobbed toml for redis_cluster_rs-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/redis_cluster_rs/0.1.5/Cargo.toml
[INFO] started frobbing redis_cluster_rs-0.1.5
[INFO] finished frobbing redis_cluster_rs-0.1.5
[INFO] frobbed toml for redis_cluster_rs-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis_cluster_rs/0.1.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting redis_cluster_rs-0.1.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/redis_cluster_rs/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c57437c506216f6c699925f67d6cc1240620e1e8b70349ee613843b0fbc664f1
[INFO] running `"docker" "start" "-a" "c57437c506216f6c699925f67d6cc1240620e1e8b70349ee613843b0fbc664f1"`
[INFO] [stderr]    Compiling crc16 v0.4.0
[INFO] [stderr]     Checking combine v3.6.6
[INFO] [stderr]     Checking redis v0.9.1
[INFO] [stderr]     Checking redis_cluster_rs v0.1.5 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:177:24
[INFO] [stderr]     |
[INFO] [stderr] 177 |         initial_nodes: &Vec<ConnectionInfo>,
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ConnectionInfo]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:195:12
[INFO] [stderr]     |
[INFO] [stderr] 195 |         if connections.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `connections.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:219:37
[INFO] [stderr]     |
[INFO] [stderr] 219 |                         for slot in slot_data.start()..slot_data.end() + 1 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `slot_data.start()..=slot_data.end()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:302:39
[INFO] [stderr]     |
[INFO] [stderr] 302 |                 let (addr, conn) = if excludes.len() > 0 || slot.is_none() {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!excludes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/lib.rs:315:24
[INFO] [stderr]     |
[INFO] [stderr] 315 |                     if retries <= 0 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using retries == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/lib.rs:399:5
[INFO] [stderr]     |
[INFO] [stderr] 399 | /     match cmd.query::<String>(conn) {
[INFO] [stderr] 400 | |         Ok(_) => true,
[INFO] [stderr] 401 | |         Err(_) => false,
[INFO] [stderr] 402 | |     }
[INFO] [stderr]     | |_____^ help: try this: `cmd.query::<String>(conn).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:437:34
[INFO] [stderr]     |
[INFO] [stderr] 437 |             if !line.starts_with("*") && !line.starts_with("$") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:437:60
[INFO] [stderr]     |
[INFO] [stderr] 437 |             if !line.starts_with("*") && !line.starts_with("$") {
[INFO] [stderr]     |                                                            ^^^ help: try using a char instead: `'$'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/lib.rs:524:16
[INFO] [stderr]     |
[INFO] [stderr] 524 |             if nodes.len() < 1 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `redis_cluster_rs`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:177:24
[INFO] [stderr]     |
[INFO] [stderr] 177 |         initial_nodes: &Vec<ConnectionInfo>,
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ConnectionInfo]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:195:12
[INFO] [stderr]     |
[INFO] [stderr] 195 |         if connections.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `connections.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:219:37
[INFO] [stderr]     |
[INFO] [stderr] 219 |                         for slot in slot_data.start()..slot_data.end() + 1 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `slot_data.start()..=slot_data.end()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:302:39
[INFO] [stderr]     |
[INFO] [stderr] 302 |                 let (addr, conn) = if excludes.len() > 0 || slot.is_none() {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!excludes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/lib.rs:315:24
[INFO] [stderr]     |
[INFO] [stderr] 315 |                     if retries <= 0 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using retries == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/lib.rs:399:5
[INFO] [stderr]     |
[INFO] [stderr] 399 | /     match cmd.query::<String>(conn) {
[INFO] [stderr] 400 | |         Ok(_) => true,
[INFO] [stderr] 401 | |         Err(_) => false,
[INFO] [stderr] 402 | |     }
[INFO] [stderr]     | |_____^ help: try this: `cmd.query::<String>(conn).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:437:34
[INFO] [stderr]     |
[INFO] [stderr] 437 |             if !line.starts_with("*") && !line.starts_with("$") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:437:60
[INFO] [stderr]     |
[INFO] [stderr] 437 |             if !line.starts_with("*") && !line.starts_with("$") {
[INFO] [stderr]     |                                                            ^^^ help: try using a char instead: `'$'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/lib.rs:524:16
[INFO] [stderr]     |
[INFO] [stderr] 524 |             if nodes.len() < 1 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `redis_cluster_rs`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "c57437c506216f6c699925f67d6cc1240620e1e8b70349ee613843b0fbc664f1"`
[INFO] running `"docker" "rm" "-f" "c57437c506216f6c699925f67d6cc1240620e1e8b70349ee613843b0fbc664f1"`
[INFO] [stdout] c57437c506216f6c699925f67d6cc1240620e1e8b70349ee613843b0fbc664f1