[INFO] crate redis-protocol 0.1.1 is already in cache [INFO] extracting crate redis-protocol 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/redis-protocol/0.1.1 [INFO] extracting crate redis-protocol 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis-protocol/0.1.1 [INFO] validating manifest of redis-protocol-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of redis-protocol-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing redis-protocol-0.1.1 [INFO] finished frobbing redis-protocol-0.1.1 [INFO] frobbed toml for redis-protocol-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/redis-protocol/0.1.1/Cargo.toml [INFO] started frobbing redis-protocol-0.1.1 [INFO] finished frobbing redis-protocol-0.1.1 [INFO] frobbed toml for redis-protocol-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis-protocol/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting redis-protocol-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/redis-protocol/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] edbe0b2efc27ea00b94237669a6f28e5211da488ee56a517184f707891213948 [INFO] running `"docker" "start" "-a" "edbe0b2efc27ea00b94237669a6f28e5211da488ee56a517184f707891213948"` [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Checking redis-protocol v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | pub const CRLF: &'static str = "\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub const NULL: &'static str = "$-1\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | pub const ZEROED_KB: &'static [u8; 1024] = &[0; 1024]; [INFO] [stderr] | -^^^^^^^----------- help: consider removing `'static`: `&[u8; 1024]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const PUBSUB_PREFIX: &'static str = "message"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | pub const CRLF: &'static str = "\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub const NULL: &'static str = "$-1\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | pub const ZEROED_KB: &'static [u8; 1024] = &[0; 1024]; [INFO] [stderr] | -^^^^^^^----------- help: consider removing `'static`: `&[u8; 1024]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const PUBSUB_PREFIX: &'static str = "message"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `::types::*` [INFO] [stderr] --> src/encode.rs:111:7 [INFO] [stderr] | [INFO] [stderr] 111 | use ::types::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/encode.rs:113:19 [INFO] [stderr] | [INFO] [stderr] 113 | const PADDING: &'static str = "foobar"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `::utils` [INFO] [stderr] --> src/decode.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | use ::utils; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `::types::*` [INFO] [stderr] --> src/decode.rs:144:7 [INFO] [stderr] | [INFO] [stderr] 144 | use ::types::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/decode.rs:146:7 [INFO] [stderr] | [INFO] [stderr] 146 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `nom::Err as NomError` [INFO] [stderr] --> src/decode.rs:149:7 [INFO] [stderr] | [INFO] [stderr] 149 | use nom::Err as NomError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `nom::simple_errors::Context` [INFO] [stderr] --> src/decode.rs:150:7 [INFO] [stderr] | [INFO] [stderr] 150 | use nom::simple_errors::Context; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/decode.rs:152:19 [INFO] [stderr] | [INFO] [stderr] 152 | const PADDING: &'static str = "FOOBARBAZ"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn array_encode_len(frames: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | crc16_xmodem(&key[i+1..i+j+1]) [INFO] [stderr] | ^^^^^^^^^^ help: use: `i+1..=i+j` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:126:42 [INFO] [stderr] | [INFO] [stderr] 126 | let parts: Vec<&str> = payload.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:129:42 [INFO] [stderr] | [INFO] [stderr] 129 | let parts: Vec<&str> = payload.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/types.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match self.context { [INFO] [stderr] 86 | | Some(ref c) => Some(c), [INFO] [stderr] 87 | | None => None [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: try this: `self.context.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/encode.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | let _ = utils::check_offset(&x)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/encode.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | let _ = utils::check_offset(&x)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/encode.rs:45:50 [INFO] [stderr] | [INFO] [stderr] 45 | fn gen_array<'a>(x: (&'a mut [u8], usize), data: &Vec) -> Result<(&'a mut [u8], usize), GenError> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/encode.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | let _ = utils::check_offset(&x)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/types.rs:360:9 [INFO] [stderr] | [INFO] [stderr] 360 | let s = e.to_string(); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/types.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | let s = e.to_string(); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/types.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | let s = e.to_string(); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/types.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | let s = e.to_string(); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decode.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | let mut bytes: BytesMut = "foobarbazwibblewobble".into(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_bytes` [INFO] [stderr] --> src/encode.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | fn to_bytes(s: &str) -> BytesMut { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_bytes` [INFO] [stderr] --> src/decode.rs:158:3 [INFO] [stderr] | [INFO] [stderr] 158 | fn to_bytes(s: &str) -> BytesMut { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `empty_bytes` [INFO] [stderr] --> src/decode.rs:162:3 [INFO] [stderr] | [INFO] [stderr] 162 | fn empty_bytes() -> BytesMut { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn array_encode_len(frames: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | crc16_xmodem(&key[i+1..i+j+1]) [INFO] [stderr] | ^^^^^^^^^^ help: use: `i+1..=i+j` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:126:42 [INFO] [stderr] | [INFO] [stderr] 126 | let parts: Vec<&str> = payload.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:129:42 [INFO] [stderr] | [INFO] [stderr] 129 | let parts: Vec<&str> = payload.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/types.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match self.context { [INFO] [stderr] 86 | | Some(ref c) => Some(c), [INFO] [stderr] 87 | | None => None [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: try this: `self.context.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/types.rs:422:3 [INFO] [stderr] | [INFO] [stderr] 422 | / fn should_check_frame_types() { [INFO] [stderr] 423 | | let f = Frame::Null; [INFO] [stderr] 424 | | assert!(f.is_null()); [INFO] [stderr] 425 | | assert!(!f.is_string()); [INFO] [stderr] ... | [INFO] [stderr] 485 | | assert!(f.is_moved_or_ask_error()); [INFO] [stderr] 486 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/types.rs:431:31 [INFO] [stderr] | [INFO] [stderr] 431 | let f = Frame::BulkString("foo".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/encode.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | let _ = utils::check_offset(&x)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/encode.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | let _ = utils::check_offset(&x)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/encode.rs:45:50 [INFO] [stderr] | [INFO] [stderr] 45 | fn gen_array<'a>(x: (&'a mut [u8], usize), data: &Vec) -> Result<(&'a mut [u8], usize), GenError> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/encode.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | let _ = utils::check_offset(&x)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode.rs:298:42 [INFO] [stderr] | [INFO] [stderr] 298 | let _ = decode_bytes(&bytes).map_err(|e| pretty_print_panic(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `pretty_print_panic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/decode.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `redis-protocol`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/encode.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `redis-protocol`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/utils.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `redis-protocol`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "edbe0b2efc27ea00b94237669a6f28e5211da488ee56a517184f707891213948"` [INFO] running `"docker" "rm" "-f" "edbe0b2efc27ea00b94237669a6f28e5211da488ee56a517184f707891213948"` [INFO] [stdout] edbe0b2efc27ea00b94237669a6f28e5211da488ee56a517184f707891213948