[INFO] crate redis-cluster 0.1.4 is already in cache [INFO] extracting crate redis-cluster 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/redis-cluster/0.1.4 [INFO] extracting crate redis-cluster 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis-cluster/0.1.4 [INFO] validating manifest of redis-cluster-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of redis-cluster-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing redis-cluster-0.1.4 [INFO] finished frobbing redis-cluster-0.1.4 [INFO] frobbed toml for redis-cluster-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/redis-cluster/0.1.4/Cargo.toml [INFO] started frobbing redis-cluster-0.1.4 [INFO] finished frobbing redis-cluster-0.1.4 [INFO] frobbed toml for redis-cluster-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis-cluster/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting redis-cluster-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/redis-cluster/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 99911efad67de615303ad93d5f4ab68465a740e085c21db6940df719c4c56d26 [INFO] running `"docker" "start" "-a" "99911efad67de615303ad93d5f4ab68465a740e085c21db6940df719c4c56d26"` [INFO] [stderr] Checking redis-cluster v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slots.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | replicas: replicas, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `replicas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | conns: conns, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `conns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slots.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | replicas: replicas, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `replicas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | conns: conns, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `conns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | sample(&mut rng, self.conns.values(), 1).first().unwrap() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | sample(&mut rng, self.conns.values(), 1).first().unwrap() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `try_random_node` is never read [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | try_random_node = false; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cmd::ClusterCmd` [INFO] [stderr] --> src/cmd.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> ClusterCmd { [INFO] [stderr] 15 | | ClusterCmd { [INFO] [stderr] 16 | | cmd: Cmd::new(), [INFO] [stderr] 17 | | args: Vec::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for cmd::ClusterCmd { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | fn slot_for_command(args: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `counter` is only used to index `bytes`. [INFO] [stderr] --> src/crc16.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | for counter in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in &bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(((crc >> 8) as u8) ^ bytes[counter])` [INFO] [stderr] --> src/crc16.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | let index = (((crc >> 8) as u8) ^ bytes[counter]) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/slots.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | data.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/slots.rs:37:52 [INFO] [stderr] | [INFO] [stderr] 37 | let parts: Vec<&str> = node_data.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / match cmd.query::(conn) { [INFO] [stderr] 26 | | Ok(_) => true, [INFO] [stderr] 27 | | Err(_) => false, [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ help: try this: `cmd.query::(conn).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / for conn in self.conns.values() { [INFO] [stderr] 60 | | for slot_data in get_slots(&conn) { [INFO] [stderr] 61 | | for (slot, addr) in slot_data.nodes() { [INFO] [stderr] 62 | | self.slots.insert(slot, addr); [INFO] [stderr] ... | [INFO] [stderr] 66 | | break; [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | let conn = self.conns.get(addr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | let addr = self.slots.get(&slot).map_or(None, |e| Some(e.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | Some(self.conns.get(addr).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | let addr = self.slots.get(&slot).map_or(None, |e| Some(e.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | self.conns.get(addr).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | self.conns.get(addr).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: value assigned to `try_random_node` is never read [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | try_random_node = false; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `redis-cluster`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cmd::ClusterCmd` [INFO] [stderr] --> src/cmd.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> ClusterCmd { [INFO] [stderr] 15 | | ClusterCmd { [INFO] [stderr] 16 | | cmd: Cmd::new(), [INFO] [stderr] 17 | | args: Vec::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for cmd::ClusterCmd { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | fn slot_for_command(args: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `counter` is only used to index `bytes`. [INFO] [stderr] --> src/crc16.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | for counter in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in &bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(((crc >> 8) as u8) ^ bytes[counter])` [INFO] [stderr] --> src/crc16.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | let index = (((crc >> 8) as u8) ^ bytes[counter]) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/slots.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | data.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/slots.rs:37:52 [INFO] [stderr] | [INFO] [stderr] 37 | let parts: Vec<&str> = node_data.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / match cmd.query::(conn) { [INFO] [stderr] 26 | | Ok(_) => true, [INFO] [stderr] 27 | | Err(_) => false, [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ help: try this: `cmd.query::(conn).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / for conn in self.conns.values() { [INFO] [stderr] 60 | | for slot_data in get_slots(&conn) { [INFO] [stderr] 61 | | for (slot, addr) in slot_data.nodes() { [INFO] [stderr] 62 | | self.slots.insert(slot, addr); [INFO] [stderr] ... | [INFO] [stderr] 66 | | break; [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | let conn = self.conns.get(addr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | let addr = self.slots.get(&slot).map_or(None, |e| Some(e.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | Some(self.conns.get(addr).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | let addr = self.slots.get(&slot).map_or(None, |e| Some(e.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | self.conns.get(addr).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | self.conns.get(addr).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `redis-cluster`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "99911efad67de615303ad93d5f4ab68465a740e085c21db6940df719c4c56d26"` [INFO] running `"docker" "rm" "-f" "99911efad67de615303ad93d5f4ab68465a740e085c21db6940df719c4c56d26"` [INFO] [stdout] 99911efad67de615303ad93d5f4ab68465a740e085c21db6940df719c4c56d26