[INFO] crate redis-cell 0.2.2 is already in cache [INFO] extracting crate redis-cell 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/redis-cell/0.2.2 [INFO] extracting crate redis-cell 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis-cell/0.2.2 [INFO] validating manifest of redis-cell-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of redis-cell-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing redis-cell-0.2.2 [INFO] finished frobbing redis-cell-0.2.2 [INFO] frobbed toml for redis-cell-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/redis-cell/0.2.2/Cargo.toml [INFO] started frobbing redis-cell-0.2.2 [INFO] finished frobbing redis-cell-0.2.2 [INFO] frobbed toml for redis-cell-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redis-cell/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting redis-cell-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/redis-cell/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 828625f6c5099193f1fa9e5e365032e83e688339ca8dea0259891dd13c7a379d [INFO] running `"docker" "start" "-a" "828625f6c5099193f1fa9e5e365032e83e688339ca8dea0259891dd13c7a379d"` [INFO] [stderr] Compiling redis-cell v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Build': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cell/mod.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/cell/mod.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:457:17 [INFO] [stderr] | [INFO] [stderr] 457 | num: num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:458:17 [INFO] [stderr] | [INFO] [stderr] 458 | now: now, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `now` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:459:17 [INFO] [stderr] | [INFO] [stderr] 459 | volume: volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:460:17 [INFO] [stderr] | [INFO] [stderr] 460 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:461:17 [INFO] [stderr] | [INFO] [stderr] 461 | reset_after: reset_after, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reset_after` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:462:17 [INFO] [stderr] | [INFO] [stderr] 462 | retry_after: retry_after, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `retry_after` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:463:17 [INFO] [stderr] | [INFO] [stderr] 463 | limited: limited, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `limited` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:482:17 [INFO] [stderr] | [INFO] [stderr] 482 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cell/mod.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/cell/mod.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:457:17 [INFO] [stderr] | [INFO] [stderr] 457 | num: num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:458:17 [INFO] [stderr] | [INFO] [stderr] 458 | now: now, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `now` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:459:17 [INFO] [stderr] | [INFO] [stderr] 459 | volume: volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:460:17 [INFO] [stderr] | [INFO] [stderr] 460 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:461:17 [INFO] [stderr] | [INFO] [stderr] 461 | reset_after: reset_after, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reset_after` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:462:17 [INFO] [stderr] | [INFO] [stderr] 462 | retry_after: retry_after, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `retry_after` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:463:17 [INFO] [stderr] | [INFO] [stderr] 463 | limited: limited, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `limited` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell/mod.rs:482:17 [INFO] [stderr] | [INFO] [stderr] 482 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/redis/mod.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | allow(redundant_field_names, suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/redis/mod.rs:7:41 [INFO] [stderr] | [INFO] [stderr] 7 | allow(redundant_field_names, suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/redis/mod.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | allow(redundant_field_names, suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell/mod.rs:456:13 [INFO] [stderr] | [INFO] [stderr] 456 | / return RateLimitCase { [INFO] [stderr] 457 | | num: num, [INFO] [stderr] 458 | | now: now, [INFO] [stderr] 459 | | volume: volume, [INFO] [stderr] ... | [INFO] [stderr] 463 | | limited: limited, [INFO] [stderr] 464 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 456 | RateLimitCase { [INFO] [stderr] 457 | num: num, [INFO] [stderr] 458 | now: now, [INFO] [stderr] 459 | volume: volume, [INFO] [stderr] 460 | remaining: remaining, [INFO] [stderr] 461 | reset_after: reset_after, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/redis/mod.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | allow(redundant_field_names, suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/redis/mod.rs:7:41 [INFO] [stderr] | [INFO] [stderr] 7 | allow(redundant_field_names, suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/redis/mod.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | allow(redundant_field_names, suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/redis/mod.rs:439:34 [INFO] [stderr] | [INFO] [stderr] 439 | let byte: u8 = unsafe { *byte_str.offset(j as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `byte_str.add(j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/redis/mod.rs:439:34 [INFO] [stderr] | [INFO] [stderr] 439 | let byte: u8 = unsafe { *byte_str.offset(j as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `byte_str.add(j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.77s [INFO] running `"docker" "inspect" "828625f6c5099193f1fa9e5e365032e83e688339ca8dea0259891dd13c7a379d"` [INFO] running `"docker" "rm" "-f" "828625f6c5099193f1fa9e5e365032e83e688339ca8dea0259891dd13c7a379d"` [INFO] [stdout] 828625f6c5099193f1fa9e5e365032e83e688339ca8dea0259891dd13c7a379d