[INFO] crate redif 0.1.1 is already in cache [INFO] extracting crate redif 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/redif/0.1.1 [INFO] extracting crate redif 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redif/0.1.1 [INFO] validating manifest of redif-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of redif-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing redif-0.1.1 [INFO] finished frobbing redif-0.1.1 [INFO] frobbed toml for redif-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/redif/0.1.1/Cargo.toml [INFO] started frobbing redif-0.1.1 [INFO] finished frobbing redif-0.1.1 [INFO] frobbed toml for redif-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/redif/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting redif-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/redif/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 169712b0655aff28bc7c400464dacee590be0455e2519690647de6ba2b9e8c0c [INFO] running `"docker" "start" "-a" "169712b0655aff28bc7c400464dacee590be0455e2519690647de6ba2b9e8c0c"` [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Checking amy v0.8.2 [INFO] [stderr] Checking redif v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(x) => return Ok((Value::Int(x), k + 1)), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | let n = x as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | let n = x as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_reader.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | max_frame_size : max_frame_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_frame_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(x) => return Ok((Value::Int(x), k + 1)), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | let n = x as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | let n = x as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_reader.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | max_frame_size : max_frame_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_frame_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/redif.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 57 | | if let Err(e) = handle_poll_notification(¬ification, ®istrar, &mut connections, handler.clone()) { [INFO] [stderr] 58 | | if let Some(conn) = connections.remove(¬ification.id) { [INFO] [stderr] 59 | | registrar.deregister(&conn.sock).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | } else if let Err(e) = handle_poll_notification(¬ification, ®istrar, &mut connections, handler.clone()) { [INFO] [stderr] 57 | if let Some(conn) = connections.remove(¬ification.id) { [INFO] [stderr] 58 | registrar.deregister(&conn.sock).unwrap(); [INFO] [stderr] 59 | error!("fail to handle poll notification Event::{:?} sock#{} {} -- {}", ¬ification.event, ¬ification.id, &conn.addr, e); [INFO] [stderr] 60 | } else { [INFO] [stderr] 61 | error!("fail to handle poll notification Event::{:?} sock#{} -- {}", ¬ification.event, ¬ification.id, e); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/redif.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 57 | | if let Err(e) = handle_poll_notification(¬ification, ®istrar, &mut connections, handler.clone()) { [INFO] [stderr] 58 | | if let Some(conn) = connections.remove(¬ification.id) { [INFO] [stderr] 59 | | registrar.deregister(&conn.sock).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | } else if let Err(e) = handle_poll_notification(¬ification, ®istrar, &mut connections, handler.clone()) { [INFO] [stderr] 57 | if let Some(conn) = connections.remove(¬ification.id) { [INFO] [stderr] 58 | registrar.deregister(&conn.sock).unwrap(); [INFO] [stderr] 59 | error!("fail to handle poll notification Event::{:?} sock#{} {} -- {}", ¬ification.event, ¬ification.id, &conn.addr, e); [INFO] [stderr] 60 | } else { [INFO] [stderr] 61 | error!("fail to handle poll notification Event::{:?} sock#{} -- {}", ¬ification.event, ¬ification.id, e); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/frame_reader.rs:174:16 [INFO] [stderr] | [INFO] [stderr] 174 | const IP: &'static str = "127.0.0.1:5003"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/redif.rs:69:53 [INFO] [stderr] | [INFO] [stderr] 69 | let handle_poller = thread::Builder::new().name(format!("poller")).spawn(move || { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"poller".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:51:105 [INFO] [stderr] | [INFO] [stderr] 51 | return Err(io::Error::new(io::ErrorKind::InvalidInput, format!("invalid CRLF: {:?}", &bytes[start_index .. k+1]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:61:128 [INFO] [stderr] | [INFO] [stderr] 61 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:68:128 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:76:132 [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:78:128 [INFO] [stderr] | [INFO] [stderr] 78 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:88:120 [INFO] [stderr] | [INFO] [stderr] 88 | return Err(io::Error::new(io::ErrorKind::InvalidInput, format!("invalid Data length: {:?}", &bytes[start_index .. k+1]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:92:50 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok((Value::Data(bytes[k+1 .. k+n+1].to_vec()), k + n + 2 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `k+1..=k+n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:102:121 [INFO] [stderr] | [INFO] [stderr] 102 | return Err(io::Error::new(io::ErrorKind::InvalidInput, format!("invalid Array length: {:?}", &bytes[start_index .. k+1]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/frame_writer.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if frame.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!frame.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/redif.rs:69:53 [INFO] [stderr] | [INFO] [stderr] 69 | let handle_poller = thread::Builder::new().name(format!("poller")).spawn(move || { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"poller".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:51:105 [INFO] [stderr] | [INFO] [stderr] 51 | return Err(io::Error::new(io::ErrorKind::InvalidInput, format!("invalid CRLF: {:?}", &bytes[start_index .. k+1]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:61:128 [INFO] [stderr] | [INFO] [stderr] 61 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:68:128 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:76:132 [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:78:128 [INFO] [stderr] | [INFO] [stderr] 78 | Err(e) => return Err(io::Error::new(io::ErrorKind::InvalidData, format!("invalid Data: {:?} -- {}", &bytes[start_index .. k+1], e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:88:120 [INFO] [stderr] | [INFO] [stderr] 88 | return Err(io::Error::new(io::ErrorKind::InvalidInput, format!("invalid Data length: {:?}", &bytes[start_index .. k+1]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:92:50 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok((Value::Data(bytes[k+1 .. k+n+1].to_vec()), k + n + 2 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `k+1..=k+n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/value.rs:102:121 [INFO] [stderr] | [INFO] [stderr] 102 | return Err(io::Error::new(io::ErrorKind::InvalidInput, format!("invalid Array length: {:?}", &bytes[start_index .. k+1]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `start_index..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/frame_writer.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if frame.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!frame.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> examples/simple.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | let key = match &args[0] { [INFO] [stderr] | ___________________^ [INFO] [stderr] 64 | | &Value::Data(ref data) => { [INFO] [stderr] 65 | | match ::std::str::from_utf8(data) { [INFO] [stderr] 66 | | Ok(s) => s.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | let key = match args[0] { [INFO] [stderr] 64 | Value::Data(ref data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> examples/simple.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | let val = match &args[1] { [INFO] [stderr] | ___________________^ [INFO] [stderr] 78 | | &Value::Data(ref data) => { [INFO] [stderr] 79 | | match ::std::str::from_utf8(data) { [INFO] [stderr] 80 | | Ok(s) => s.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | let val = match args[1] { [INFO] [stderr] 78 | Value::Data(ref data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> examples/simple.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> examples/simple.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | let key = match &args[0] { [INFO] [stderr] | ___________________^ [INFO] [stderr] 103 | | &Value::Data(ref data) => { [INFO] [stderr] 104 | | match ::std::str::from_utf8(data) { [INFO] [stderr] 105 | | Ok(s) => s.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | let key = match args[0] { [INFO] [stderr] 103 | Value::Data(ref data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/simple.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> examples/simple.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | if req.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `req.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/simple.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | filename.split("/").last().unwrap() [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.76s [INFO] running `"docker" "inspect" "169712b0655aff28bc7c400464dacee590be0455e2519690647de6ba2b9e8c0c"` [INFO] running `"docker" "rm" "-f" "169712b0655aff28bc7c400464dacee590be0455e2519690647de6ba2b9e8c0c"` [INFO] [stdout] 169712b0655aff28bc7c400464dacee590be0455e2519690647de6ba2b9e8c0c