[INFO] crate recurdates 0.3.1 is already in cache [INFO] extracting crate recurdates 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/recurdates/0.3.1 [INFO] extracting crate recurdates 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recurdates/0.3.1 [INFO] validating manifest of recurdates-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of recurdates-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing recurdates-0.3.1 [INFO] finished frobbing recurdates-0.3.1 [INFO] frobbed toml for recurdates-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/recurdates/0.3.1/Cargo.toml [INFO] started frobbing recurdates-0.3.1 [INFO] finished frobbing recurdates-0.3.1 [INFO] frobbed toml for recurdates-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recurdates/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting recurdates-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/recurdates/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c32e9416e45f853bf53f198f81f1ec62eff349c09a3c351e9f6ff7710b9d12e [INFO] running `"docker" "start" "-a" "3c32e9416e45f853bf53f198f81f1ec62eff349c09a3c351e9f6ff7710b9d12e"` [INFO] [stderr] Checking recurdates v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 80 | | if self.until < *df { [INFO] [stderr] 81 | | None [INFO] [stderr] 82 | | } else { [INFO] [stderr] 83 | | self.iter().skip_while(|x| *x < *df).next() [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | } else if self.until < *df { [INFO] [stderr] 80 | None [INFO] [stderr] 81 | } else { [INFO] [stderr] 82 | self.iter().skip_while(|x| *x < *df).next() [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 80 | | if self.until < *df { [INFO] [stderr] 81 | | None [INFO] [stderr] 82 | | } else { [INFO] [stderr] 83 | | self.iter().skip_while(|x| *x < *df).next() [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | } else if self.until < *df { [INFO] [stderr] 80 | None [INFO] [stderr] 81 | } else { [INFO] [stderr] 82 | self.iter().skip_while(|x| *x < *df).next() [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/repeat_every.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | + Duration::days(self.days as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.days)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/repeat_every.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | + Duration::minutes(self.minutes as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / if self.adder.is_none() { [INFO] [stderr] 103 | | return None; [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.adder?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | let dt = ReDateTime::at(now.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:103:34 [INFO] [stderr] | [INFO] [stderr] 103 | let dt1 = ReDateTime::repeat(now.clone(), RepeatEvery::weeks(1)); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `now` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/repeat_every.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | + Duration::days(self.days as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.days)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/repeat_every.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | + Duration::minutes(self.minutes as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / if self.adder.is_none() { [INFO] [stderr] 103 | | return None; [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.adder?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.62s [INFO] running `"docker" "inspect" "3c32e9416e45f853bf53f198f81f1ec62eff349c09a3c351e9f6ff7710b9d12e"` [INFO] running `"docker" "rm" "-f" "3c32e9416e45f853bf53f198f81f1ec62eff349c09a3c351e9f6ff7710b9d12e"` [INFO] [stdout] 3c32e9416e45f853bf53f198f81f1ec62eff349c09a3c351e9f6ff7710b9d12e