[INFO] crate recs 2.0.1 is already in cache [INFO] extracting crate recs 2.0.1 into work/ex/clippy-test-run/sources/stable/reg/recs/2.0.1 [INFO] extracting crate recs 2.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recs/2.0.1 [INFO] validating manifest of recs-2.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of recs-2.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing recs-2.0.1 [INFO] finished frobbing recs-2.0.1 [INFO] frobbed toml for recs-2.0.1 written to work/ex/clippy-test-run/sources/stable/reg/recs/2.0.1/Cargo.toml [INFO] started frobbing recs-2.0.1 [INFO] finished frobbing recs-2.0.1 [INFO] frobbed toml for recs-2.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recs/2.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting recs-2.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/recs/2.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fda393607e6e210f9fb5c1f3dce99395cea337872b0a1afc11a995823c290749 [INFO] running `"docker" "start" "-a" "fda393607e6e210f9fb5c1f3dce99395cea337872b0a1afc11a995823c290749"` [INFO] [stderr] Checking recs v2.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | #[allow(needless_lifetimes)] // https://github.com/Manishearth/rust-clippy/issues/740 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `map_clone` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | #[allow(map_clone)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_clone` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | #[allow(needless_lifetimes)] // https://github.com/Manishearth/rust-clippy/issues/740 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | #[allow(needless_lifetimes)] // https://github.com/Manishearth/rust-clippy/issues/740 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `map_clone` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | #[allow(map_clone)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_clone` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | #[allow(needless_lifetimes)] // https://github.com/Manishearth/rust-clippy/issues/740 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | #[allow(needless_lifetimes)] // https://github.com/Manishearth/rust-clippy/issues/740 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | fn contains_type_id(&self, id: &TypeId) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TypeId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | #[allow(needless_lifetimes)] // https://github.com/Manishearth/rust-clippy/issues/740 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mod.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | Vector2f { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mod.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | Vector2f { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | fn contains_type_id(&self, id: &TypeId) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TypeId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/mod.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | fn update_position(pos: &Position, vel: &Velocity) -> Position { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/mod.rs:38:41 [INFO] [stderr] | [INFO] [stderr] 38 | fn update_position(pos: &Position, vel: &Velocity) -> Position { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/mod.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | let components = component_filter!(Position, Velocity); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.78s [INFO] running `"docker" "inspect" "fda393607e6e210f9fb5c1f3dce99395cea337872b0a1afc11a995823c290749"` [INFO] running `"docker" "rm" "-f" "fda393607e6e210f9fb5c1f3dce99395cea337872b0a1afc11a995823c290749"` [INFO] [stdout] fda393607e6e210f9fb5c1f3dce99395cea337872b0a1afc11a995823c290749