[INFO] crate reciter 0.1.2 is already in cache [INFO] extracting crate reciter 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/reciter/0.1.2 [INFO] extracting crate reciter 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reciter/0.1.2 [INFO] validating manifest of reciter-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reciter-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reciter-0.1.2 [INFO] finished frobbing reciter-0.1.2 [INFO] frobbed toml for reciter-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/reciter/0.1.2/Cargo.toml [INFO] started frobbing reciter-0.1.2 [INFO] finished frobbing reciter-0.1.2 [INFO] frobbed toml for reciter-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reciter/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reciter-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reciter/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c881b6d6043e595261e110f616e504807e0cb3c0504f411c1e99c57d7347408 [INFO] running `"docker" "start" "-a" "9c881b6d6043e595261e110f616e504807e0cb3c0504f411c1e99c57d7347408"` [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Checking reciter v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | let tokens = if let Some(cache_size) = cache_size { [INFO] [stderr] | __________________^ [INFO] [stderr] 199 | | if cache_size > 32 { [INFO] [stderr] 200 | | panic!("cache > 32 doesn't work at the momeent because Default is only implemented for arrays up to the size of 32") [INFO] [stderr] 201 | | } [INFO] [stderr] ... | [INFO] [stderr] 304 | | .into() [INFO] [stderr] 305 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | let tokens = if let Some(cache_size) = cache_size { [INFO] [stderr] | __________________^ [INFO] [stderr] 199 | | if cache_size > 32 { [INFO] [stderr] 200 | | panic!("cache > 32 doesn't work at the momeent because Default is only implemented for arrays up to the size of 32") [INFO] [stderr] 201 | | } [INFO] [stderr] ... | [INFO] [stderr] 304 | | .into() [INFO] [stderr] 305 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.55s [INFO] running `"docker" "inspect" "9c881b6d6043e595261e110f616e504807e0cb3c0504f411c1e99c57d7347408"` [INFO] running `"docker" "rm" "-f" "9c881b6d6043e595261e110f616e504807e0cb3c0504f411c1e99c57d7347408"` [INFO] [stdout] 9c881b6d6043e595261e110f616e504807e0cb3c0504f411c1e99c57d7347408