[INFO] crate recaman 0.1.0 is already in cache [INFO] extracting crate recaman 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/recaman/0.1.0 [INFO] extracting crate recaman 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recaman/0.1.0 [INFO] validating manifest of recaman-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of recaman-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing recaman-0.1.0 [INFO] finished frobbing recaman-0.1.0 [INFO] frobbed toml for recaman-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/recaman/0.1.0/Cargo.toml [INFO] started frobbing recaman-0.1.0 [INFO] finished frobbing recaman-0.1.0 [INFO] frobbed toml for recaman-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recaman/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting recaman-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/recaman/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d25af0423f7b5dd2fe368a03f3ceebac8920c51704bffd7a2ef9eae8fe0229e6 [INFO] running `"docker" "start" "-a" "d25af0423f7b5dd2fe368a03f3ceebac8920c51704bffd7a2ef9eae8fe0229e6"` [INFO] [stderr] Checking recaman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: you should consider deriving a `Default` implementation for `Recaman` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut hits = FxHashSet::default(); [INFO] [stderr] 33 | | hits.insert(0); [INFO] [stderr] 34 | | [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | #![deny(warnings, missing_docs)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default_derive)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | self.current = match next == 0 || self.hits.contains(&next) { [INFO] [stderr] | ________________________^ [INFO] [stderr] 60 | | true => self.current + self.step, [INFO] [stderr] 61 | | false => next, [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if next == 0 || self.hits.contains(&next) { self.current + self.step } else { next }` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | #![deny(warnings, missing_docs)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::match_bool)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `recaman`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you should consider deriving a `Default` implementation for `Recaman` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut hits = FxHashSet::default(); [INFO] [stderr] 33 | | hits.insert(0); [INFO] [stderr] 34 | | [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | #![deny(warnings, missing_docs)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default_derive)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | self.current = match next == 0 || self.hits.contains(&next) { [INFO] [stderr] | ________________________^ [INFO] [stderr] 60 | | true => self.current + self.step, [INFO] [stderr] 61 | | false => next, [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if next == 0 || self.hits.contains(&next) { self.current + self.step } else { next }` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | #![deny(warnings, missing_docs)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::match_bool)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `recaman`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d25af0423f7b5dd2fe368a03f3ceebac8920c51704bffd7a2ef9eae8fe0229e6"` [INFO] running `"docker" "rm" "-f" "d25af0423f7b5dd2fe368a03f3ceebac8920c51704bffd7a2ef9eae8fe0229e6"` [INFO] [stdout] d25af0423f7b5dd2fe368a03f3ceebac8920c51704bffd7a2ef9eae8fe0229e6