[INFO] crate reapfrog 0.2.0 is already in cache [INFO] extracting crate reapfrog 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/reapfrog/0.2.0 [INFO] extracting crate reapfrog 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reapfrog/0.2.0 [INFO] validating manifest of reapfrog-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reapfrog-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reapfrog-0.2.0 [INFO] finished frobbing reapfrog-0.2.0 [INFO] frobbed toml for reapfrog-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/reapfrog/0.2.0/Cargo.toml [INFO] started frobbing reapfrog-0.2.0 [INFO] finished frobbing reapfrog-0.2.0 [INFO] frobbed toml for reapfrog-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reapfrog/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reapfrog-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reapfrog/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 294cfa1829fc4f6850eeb3d721709ca37a00dd6b7a4ce49958c438e5ba1edd4c [INFO] running `"docker" "start" "-a" "294cfa1829fc4f6850eeb3d721709ca37a00dd6b7a4ce49958c438e5ba1edd4c"` [INFO] [stderr] Checking reapfrog v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let ref mut fetch = self.owner.open[0].as_mut().expect("expect that readers are only created for successfully opened files"); [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------------------------------------------------------------------------------------------ help: try: `let fetch = &mut self.owner.open[0].as_mut().expect("expect that readers are only created for successfully opened files");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | let ref mut p = match self.open[i] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 132 | let p = &mut (match self.open[i] { [INFO] [stderr] 133 | Ok(ref mut p) => p, [INFO] [stderr] 134 | Err(_) => continue [INFO] [stderr] 135 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / pub fn next(&mut self) -> Option, std::io::Error>> { [INFO] [stderr] 186 | | // discard most recent file [INFO] [stderr] 187 | | if let Some(Ok(p)) = self.open.pop_front() { [INFO] [stderr] 188 | | if p.to_drop > 0 { [INFO] [stderr] ... | [INFO] [stderr] 202 | | Some(Ok(Reader{owner: self})) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let ref mut fetch = self.owner.open[0].as_mut().expect("expect that readers are only created for successfully opened files"); [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------------------------------------------------------------------------------------------ help: try: `let fetch = &mut self.owner.open[0].as_mut().expect("expect that readers are only created for successfully opened files");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | let ref mut p = match self.open[i] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 132 | let p = &mut (match self.open[i] { [INFO] [stderr] 133 | Ok(ref mut p) => p, [INFO] [stderr] 134 | Err(_) => continue [INFO] [stderr] 135 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / pub fn next(&mut self) -> Option, std::io::Error>> { [INFO] [stderr] 186 | | // discard most recent file [INFO] [stderr] 187 | | if let Some(Ok(p)) = self.open.pop_front() { [INFO] [stderr] 188 | | if p.to_drop > 0 { [INFO] [stderr] ... | [INFO] [stderr] 202 | | Some(Ok(Reader{owner: self})) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "294cfa1829fc4f6850eeb3d721709ca37a00dd6b7a4ce49958c438e5ba1edd4c"` [INFO] running `"docker" "rm" "-f" "294cfa1829fc4f6850eeb3d721709ca37a00dd6b7a4ce49958c438e5ba1edd4c"` [INFO] [stdout] 294cfa1829fc4f6850eeb3d721709ca37a00dd6b7a4ce49958c438e5ba1edd4c