[INFO] crate readability 0.1.4 is already in cache
[INFO] extracting crate readability 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/readability/0.1.4
[INFO] extracting crate readability 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/readability/0.1.4
[INFO] validating manifest of readability-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of readability-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing readability-0.1.4
[INFO] finished frobbing readability-0.1.4
[INFO] frobbed toml for readability-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/readability/0.1.4/Cargo.toml
[INFO] started frobbing readability-0.1.4
[INFO] finished frobbing readability-0.1.4
[INFO] frobbed toml for readability-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/readability/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting readability-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/readability/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b026078daecc3d8440d7c119365f31649554d51cfefefa0488026e07880bed20
[INFO] running `"docker" "start" "-a" "b026078daecc3d8440d7c119365f31649554d51cfefefa0488026e07880bed20"`
[INFO] [stderr]    Compiling markup5ever v0.7.5
[INFO] [stderr]     Checking string_cache v0.7.3
[INFO] [stderr]     Checking html5ever v0.22.5
[INFO] [stderr]     Checking readability v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/extractor.rs:76:18
[INFO] [stderr]    |
[INFO] [stderr] 76 |     Ok(Product { title: title, content: content, text: text })
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/extractor.rs:76:32
[INFO] [stderr]    |
[INFO] [stderr] 76 |     Ok(Product { title: title, content: content, text: text })
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/extractor.rs:76:50
[INFO] [stderr]    |
[INFO] [stderr] 76 |     Ok(Product { title: title, content: content, text: text })
[INFO] [stderr]    |                                                  ^^^^^^^^^^ help: replace it with: `text`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dom.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 |                         value: value,
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/extractor.rs:76:18
[INFO] [stderr]    |
[INFO] [stderr] 76 |     Ok(Product { title: title, content: content, text: text })
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/extractor.rs:76:32
[INFO] [stderr]    |
[INFO] [stderr] 76 |     Ok(Product { title: title, content: content, text: text })
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/extractor.rs:76:50
[INFO] [stderr]    |
[INFO] [stderr] 76 |     Ok(Product { title: title, content: content, text: text })
[INFO] [stderr]    |                                                  ^^^^^^^^^^ help: replace it with: `text`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dom.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 |                         value: value,
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scorer.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     return score
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `score`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/scorer.rs:124:19
[INFO] [stderr]     |
[INFO] [stderr] 124 |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr]     |                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Element { ref attrs, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/scorer.rs:154:21
[INFO] [stderr]     |
[INFO] [stderr] 154 | /                     if tag_name != "body" && UNLIKELY.is_match(&val) {
[INFO] [stderr] 155 | |                         if !LIKELY.is_match(&val) {
[INFO] [stderr] 156 | |                             return true
[INFO] [stderr] 157 | |                         }
[INFO] [stderr] 158 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     if tag_name != "body" && UNLIKELY.is_match(&val) && !LIKELY.is_match(&val) {
[INFO] [stderr] 155 |     return true
[INFO] [stderr] 156 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scorer.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 |     return false
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/dom.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |         Element { name: _, ref attrs, .. } => attr(name, &attrs.borrow()),
[INFO] [stderr]    |                   ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Element { ref attrs, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/dom.rs:33:19
[INFO] [stderr]    |
[INFO] [stderr] 33 |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr]    |                   ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Element { ref attrs, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dom.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return false
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/dom.rs:167:5
[INFO] [stderr]     |
[INFO] [stderr] 167 |     return false
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/scorer.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 | /         match url.join(&s) {
[INFO] [stderr] 63 | |             Ok(new_url) => dom::set_attr("src", new_url.as_str(), handle),
[INFO] [stderr] 64 | |             Err(_)      => (),
[INFO] [stderr] 65 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Ok(new_url) = url.join(&s) { dom::set_attr("src", new_url.as_str(), handle) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/scorer.rs:93:46
[INFO] [stderr]    |
[INFO] [stderr] 93 |             !dom::has_nodes(handle.clone(), &BLOCK_CHILD_TAGS.iter().map(|t| *t).collect()),
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `BLOCK_CHILD_TAGS.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/scorer.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 | /     match handle.data {
[INFO] [stderr] 124 | |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr] 125 | |             for name in ["id", "class"].iter() {
[INFO] [stderr] 126 | |                 if let Some(val) = dom::attr(name, &attrs.borrow()) {
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |         _ => (),
[INFO] [stderr] 137 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 123 |     if let Element { name: _, ref attrs, .. } = handle.data {
[INFO] [stderr] 124 |     for name in ["id", "class"].iter() {
[INFO] [stderr] 125 |         if let Some(val) = dom::attr(name, &attrs.borrow()) {
[INFO] [stderr] 126 |             if POSITIVE.is_match(&val) {
[INFO] [stderr] 127 |                 weight += 25.0
[INFO] [stderr] 128 |             };
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/scorer.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 | /     match handle.clone().data {
[INFO] [stderr] 143 | |         Element { ref name, ref attrs, .. } => {
[INFO] [stderr] 144 | |             let tag_name = name.local.as_ref();
[INFO] [stderr] 145 | |             match tag_name.to_lowercase().as_ref() {
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |         _ => (),
[INFO] [stderr] 163 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 142 |     if let Element { ref name, ref attrs, .. } = handle.clone().data {
[INFO] [stderr] 143 |     let tag_name = name.local.as_ref();
[INFO] [stderr] 144 |     match tag_name.to_lowercase().as_ref() {
[INFO] [stderr] 145 |         "script" | "link" | "style"  => {
[INFO] [stderr] 146 |             return true
[INFO] [stderr] 147 |         },
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scorer.rs:183:37
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 if br_count >= 2 && s.trim().len() > 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.trim().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/scorer.rs:199:9
[INFO] [stderr]     |
[INFO] [stderr] 199 | /         match node.clone().data {
[INFO] [stderr] 200 | |             Text { ref contents } => {
[INFO] [stderr] 201 | |                 let text = contents.clone().into_inner().clone();
[INFO] [stderr] 202 | |                 dom.append(&p, NodeOrText::AppendText(text))
[INFO] [stderr] 203 | |             },
[INFO] [stderr] 204 | |             _ => (),
[INFO] [stderr] 205 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 199 |         if let Text { ref contents } = node.clone().data {
[INFO] [stderr] 200 |     let text = contents.clone().into_inner().clone();
[INFO] [stderr] 201 |     dom.append(&p, NodeOrText::AppendText(text))
[INFO] [stderr] 202 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scorer.rs:291:16
[INFO] [stderr]     |
[INFO] [stderr] 291 |             if s.trim().len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.trim().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/dom.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn get_attr<'a>(name: &str, handle: Handle) -> Option<String> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/dom.rs:22:37
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn attr(attr_name: &str, attrs: &Vec<Attribute>) -> Option<String> {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/dom.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     match handle.data {
[INFO] [stderr] 33 | |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr] 34 | |             let attrs = &mut attrs.borrow_mut();
[INFO] [stderr] 35 | |             if let Some(index) = attrs.iter().position(|attr| {
[INFO] [stderr] ...  |
[INFO] [stderr] 48 | |         _ => (),
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 32 |     if let Element { name: _, ref attrs, .. } = handle.data {
[INFO] [stderr] 33 |     let attrs = &mut attrs.borrow_mut();
[INFO] [stderr] 34 |     if let Some(index) = attrs.iter().position(|attr| {
[INFO] [stderr] 35 |         let name = attr.name.local.as_ref();
[INFO] [stderr] 36 |         name == attr_name
[INFO] [stderr] 37 |     }) {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/dom.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 | /                 match StrTendril::from_str(value) {
[INFO] [stderr] 40 | |                     Ok(value) => attrs[index] = Attribute {
[INFO] [stderr] 41 | |                         name:  attrs[index].name.clone(),
[INFO] [stderr] 42 | |                         value: value,
[INFO] [stderr] 43 | |                     },
[INFO] [stderr] 44 | |                     Err(_) => (),
[INFO] [stderr] 45 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 if let Ok(value) = StrTendril::from_str(value) { attrs[index] = Attribute {
[INFO] [stderr] 40 |     name:  attrs[index].name.clone(),
[INFO] [stderr] 41 |     value: value,
[INFO] [stderr] 42 | } }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/dom.rs:139:9
[INFO] [stderr]     |
[INFO] [stderr] 139 | /         match c.data {
[INFO] [stderr] 140 | |             Element { ref name, .. } => {
[INFO] [stderr] 141 | |                 let t = name.local.as_ref();
[INFO] [stderr] 142 | |                 if t.to_lowercase() == tag_name {
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |             _ => ()
[INFO] [stderr] 148 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 139 |         if let Element { ref name, .. } = c.data {
[INFO] [stderr] 140 |     let t = name.local.as_ref();
[INFO] [stderr] 141 |     if t.to_lowercase() == tag_name {
[INFO] [stderr] 142 |         nodes.push(child.clone());
[INFO] [stderr] 143 |     };
[INFO] [stderr] 144 |     find_node(child.clone(), tag_name, nodes)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/dom.rs:152:45
[INFO] [stderr]     |
[INFO] [stderr] 152 | pub fn has_nodes(handle: Handle, tag_names: &Vec<&'static str>) -> bool {
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&'static str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/dom.rs:174:9
[INFO] [stderr]     |
[INFO] [stderr] 174 | /         match c.data {
[INFO] [stderr] 175 | |             Text { ref contents } => {
[INFO] [stderr] 176 | |                 let s = contents.borrow();
[INFO] [stderr] 177 | |                 if s.trim().len() >= 20 {
[INFO] [stderr] ...   |
[INFO] [stderr] 181 | |             _ => ()
[INFO] [stderr] 182 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 174 |         if let Text { ref contents } = c.data {
[INFO] [stderr] 175 |     let s = contents.borrow();
[INFO] [stderr] 176 |     if s.trim().len() >= 20 {
[INFO] [stderr] 177 |         count += 1
[INFO] [stderr] 178 |     }
[INFO] [stderr] 179 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scorer.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     return score
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `score`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/scorer.rs:124:19
[INFO] [stderr]     |
[INFO] [stderr] 124 |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr]     |                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Element { ref attrs, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/scorer.rs:154:21
[INFO] [stderr]     |
[INFO] [stderr] 154 | /                     if tag_name != "body" && UNLIKELY.is_match(&val) {
[INFO] [stderr] 155 | |                         if !LIKELY.is_match(&val) {
[INFO] [stderr] 156 | |                             return true
[INFO] [stderr] 157 | |                         }
[INFO] [stderr] 158 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     if tag_name != "body" && UNLIKELY.is_match(&val) && !LIKELY.is_match(&val) {
[INFO] [stderr] 155 |     return true
[INFO] [stderr] 156 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scorer.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 |     return false
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/dom.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |         Element { name: _, ref attrs, .. } => attr(name, &attrs.borrow()),
[INFO] [stderr]    |                   ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Element { ref attrs, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/dom.rs:33:19
[INFO] [stderr]    |
[INFO] [stderr] 33 |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr]    |                   ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Element { ref attrs, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dom.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return false
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/dom.rs:167:5
[INFO] [stderr]     |
[INFO] [stderr] 167 |     return false
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/scorer.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 | /         match url.join(&s) {
[INFO] [stderr] 63 | |             Ok(new_url) => dom::set_attr("src", new_url.as_str(), handle),
[INFO] [stderr] 64 | |             Err(_)      => (),
[INFO] [stderr] 65 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Ok(new_url) = url.join(&s) { dom::set_attr("src", new_url.as_str(), handle) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/scorer.rs:93:46
[INFO] [stderr]    |
[INFO] [stderr] 93 |             !dom::has_nodes(handle.clone(), &BLOCK_CHILD_TAGS.iter().map(|t| *t).collect()),
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `BLOCK_CHILD_TAGS.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/scorer.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 | /     match handle.data {
[INFO] [stderr] 124 | |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr] 125 | |             for name in ["id", "class"].iter() {
[INFO] [stderr] 126 | |                 if let Some(val) = dom::attr(name, &attrs.borrow()) {
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |         _ => (),
[INFO] [stderr] 137 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 123 |     if let Element { name: _, ref attrs, .. } = handle.data {
[INFO] [stderr] 124 |     for name in ["id", "class"].iter() {
[INFO] [stderr] 125 |         if let Some(val) = dom::attr(name, &attrs.borrow()) {
[INFO] [stderr] 126 |             if POSITIVE.is_match(&val) {
[INFO] [stderr] 127 |                 weight += 25.0
[INFO] [stderr] 128 |             };
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/scorer.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 | /     match handle.clone().data {
[INFO] [stderr] 143 | |         Element { ref name, ref attrs, .. } => {
[INFO] [stderr] 144 | |             let tag_name = name.local.as_ref();
[INFO] [stderr] 145 | |             match tag_name.to_lowercase().as_ref() {
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |         _ => (),
[INFO] [stderr] 163 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 142 |     if let Element { ref name, ref attrs, .. } = handle.clone().data {
[INFO] [stderr] 143 |     let tag_name = name.local.as_ref();
[INFO] [stderr] 144 |     match tag_name.to_lowercase().as_ref() {
[INFO] [stderr] 145 |         "script" | "link" | "style"  => {
[INFO] [stderr] 146 |             return true
[INFO] [stderr] 147 |         },
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scorer.rs:183:37
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 if br_count >= 2 && s.trim().len() > 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.trim().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/scorer.rs:199:9
[INFO] [stderr]     |
[INFO] [stderr] 199 | /         match node.clone().data {
[INFO] [stderr] 200 | |             Text { ref contents } => {
[INFO] [stderr] 201 | |                 let text = contents.clone().into_inner().clone();
[INFO] [stderr] 202 | |                 dom.append(&p, NodeOrText::AppendText(text))
[INFO] [stderr] 203 | |             },
[INFO] [stderr] 204 | |             _ => (),
[INFO] [stderr] 205 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 199 |         if let Text { ref contents } = node.clone().data {
[INFO] [stderr] 200 |     let text = contents.clone().into_inner().clone();
[INFO] [stderr] 201 |     dom.append(&p, NodeOrText::AppendText(text))
[INFO] [stderr] 202 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scorer.rs:291:16
[INFO] [stderr]     |
[INFO] [stderr] 291 |             if s.trim().len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.trim().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/dom.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn get_attr<'a>(name: &str, handle: Handle) -> Option<String> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/dom.rs:22:37
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn attr(attr_name: &str, attrs: &Vec<Attribute>) -> Option<String> {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/dom.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     match handle.data {
[INFO] [stderr] 33 | |         Element { name: _, ref attrs, .. } => {
[INFO] [stderr] 34 | |             let attrs = &mut attrs.borrow_mut();
[INFO] [stderr] 35 | |             if let Some(index) = attrs.iter().position(|attr| {
[INFO] [stderr] ...  |
[INFO] [stderr] 48 | |         _ => (),
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 32 |     if let Element { name: _, ref attrs, .. } = handle.data {
[INFO] [stderr] 33 |     let attrs = &mut attrs.borrow_mut();
[INFO] [stderr] 34 |     if let Some(index) = attrs.iter().position(|attr| {
[INFO] [stderr] 35 |         let name = attr.name.local.as_ref();
[INFO] [stderr] 36 |         name == attr_name
[INFO] [stderr] 37 |     }) {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/dom.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 | /                 match StrTendril::from_str(value) {
[INFO] [stderr] 40 | |                     Ok(value) => attrs[index] = Attribute {
[INFO] [stderr] 41 | |                         name:  attrs[index].name.clone(),
[INFO] [stderr] 42 | |                         value: value,
[INFO] [stderr] 43 | |                     },
[INFO] [stderr] 44 | |                     Err(_) => (),
[INFO] [stderr] 45 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 if let Ok(value) = StrTendril::from_str(value) { attrs[index] = Attribute {
[INFO] [stderr] 40 |     name:  attrs[index].name.clone(),
[INFO] [stderr] 41 |     value: value,
[INFO] [stderr] 42 | } }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/dom.rs:139:9
[INFO] [stderr]     |
[INFO] [stderr] 139 | /         match c.data {
[INFO] [stderr] 140 | |             Element { ref name, .. } => {
[INFO] [stderr] 141 | |                 let t = name.local.as_ref();
[INFO] [stderr] 142 | |                 if t.to_lowercase() == tag_name {
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |             _ => ()
[INFO] [stderr] 148 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 139 |         if let Element { ref name, .. } = c.data {
[INFO] [stderr] 140 |     let t = name.local.as_ref();
[INFO] [stderr] 141 |     if t.to_lowercase() == tag_name {
[INFO] [stderr] 142 |         nodes.push(child.clone());
[INFO] [stderr] 143 |     };
[INFO] [stderr] 144 |     find_node(child.clone(), tag_name, nodes)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/dom.rs:152:45
[INFO] [stderr]     |
[INFO] [stderr] 152 | pub fn has_nodes(handle: Handle, tag_names: &Vec<&'static str>) -> bool {
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&'static str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/dom.rs:174:9
[INFO] [stderr]     |
[INFO] [stderr] 174 | /         match c.data {
[INFO] [stderr] 175 | |             Text { ref contents } => {
[INFO] [stderr] 176 | |                 let s = contents.borrow();
[INFO] [stderr] 177 | |                 if s.trim().len() >= 20 {
[INFO] [stderr] ...   |
[INFO] [stderr] 181 | |             _ => ()
[INFO] [stderr] 182 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 174 |         if let Text { ref contents } = c.data {
[INFO] [stderr] 175 |     let s = contents.borrow();
[INFO] [stderr] 176 |     if s.trim().len() >= 20 {
[INFO] [stderr] 177 |         count += 1
[INFO] [stderr] 178 |     }
[INFO] [stderr] 179 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 28.35s
[INFO] running `"docker" "inspect" "b026078daecc3d8440d7c119365f31649554d51cfefefa0488026e07880bed20"`
[INFO] running `"docker" "rm" "-f" "b026078daecc3d8440d7c119365f31649554d51cfefefa0488026e07880bed20"`
[INFO] [stdout] b026078daecc3d8440d7c119365f31649554d51cfefefa0488026e07880bed20