[INFO] crate reactive-rs 0.1.1 is already in cache [INFO] extracting crate reactive-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/reactive-rs/0.1.1 [INFO] extracting crate reactive-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reactive-rs/0.1.1 [INFO] validating manifest of reactive-rs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reactive-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reactive-rs-0.1.1 [INFO] finished frobbing reactive-rs-0.1.1 [INFO] frobbed toml for reactive-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/reactive-rs/0.1.1/Cargo.toml [INFO] started frobbing reactive-rs-0.1.1 [INFO] finished frobbing reactive-rs-0.1.1 [INFO] frobbed toml for reactive-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reactive-rs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reactive-rs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/reactive-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f35edd9dc62b1ab878e34a2b18dabda29ccf8f208181c6d0c7c863cfb75ae507 [INFO] running `"docker" "start" "-a" "f35edd9dc62b1ab878e34a2b18dabda29ccf8f208181c6d0c7c863cfb75ae507"` [INFO] [stderr] Checking slice-deque v0.1.16 [INFO] [stderr] Checking reactive-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/test_stream.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | s.send_ctx(3.14, 4); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/test_stream.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | assert_eq!(v_ctx.get(), (3.14, 4)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/test_stream.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | t.send_ctx(3.14, 2); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/test_stream.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | assert_eq!(v_ctx.get(), (3.14, 2)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | let s2 = s.clone().with_ctx_map(|ctx, x| *ctx + (*x as f64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:115:48 [INFO] [stderr] | [INFO] [stderr] 115 | let s2 = s.clone().map_ctx(|ctx, x| *ctx + (*x as f64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:116:63 [INFO] [stderr] | [INFO] [stderr] 116 | let s3 = s.clone().map(|x| x * 2).map_ctx(|ctx, x| *ctx + (*x as f64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:117:48 [INFO] [stderr] | [INFO] [stderr] 117 | let s4 = s.clone().map_ctx(|ctx, x| *ctx + (*x as f64)).map(|x| x * 2.); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:154:44 [INFO] [stderr] | [INFO] [stderr] 154 | let s2 = s.clone().filter_ctx(|ctx, x| (*x as f64) > *ctx); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | |ctx, x| if (*x as f64) > *ctx { Some(ctx + (*x as f64)) } else { None }, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:173:57 [INFO] [stderr] | [INFO] [stderr] 173 | |ctx, x| if (*x as f64) > *ctx { Some(ctx + (*x as f64)) } else { None }, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/test_stream.rs:191:65 [INFO] [stderr] | [INFO] [stderr] 191 | let s2 = s.clone().fold_ctx(0., |ctx, acc, x| (acc + ctx) + (*x as f64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> tests/test_stream.rs:230:42 [INFO] [stderr] | [INFO] [stderr] 230 | let s1 = s.clone().last_n(2).map(|x| x.iter().cloned().collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `reactive-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f35edd9dc62b1ab878e34a2b18dabda29ccf8f208181c6d0c7c863cfb75ae507"` [INFO] running `"docker" "rm" "-f" "f35edd9dc62b1ab878e34a2b18dabda29ccf8f208181c6d0c7c863cfb75ae507"` [INFO] [stdout] f35edd9dc62b1ab878e34a2b18dabda29ccf8f208181c6d0c7c863cfb75ae507