[INFO] crate rdxsort 0.3.0 is already in cache [INFO] extracting crate rdxsort 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rdxsort/0.3.0 [INFO] extracting crate rdxsort 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rdxsort/0.3.0 [INFO] validating manifest of rdxsort-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rdxsort-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rdxsort-0.3.0 [INFO] finished frobbing rdxsort-0.3.0 [INFO] frobbed toml for rdxsort-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rdxsort/0.3.0/Cargo.toml [INFO] started frobbing rdxsort-0.3.0 [INFO] finished frobbing rdxsort-0.3.0 [INFO] frobbed toml for rdxsort-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rdxsort/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rdxsort-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rdxsort/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f25f52f8f8a0b6697ffede5b455250910296d66319f69aed4395c0f85b36351 [INFO] running `"docker" "start" "-a" "6f25f52f8f8a0b6697ffede5b455250910296d66319f69aed4395c0f85b36351"` [INFO] [stderr] Checking quicksort v1.1.0 [INFO] [stderr] Checking rdxsort v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> tests/lib.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | let mut hasher = hash::SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> tests/lib.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | let mut hasher = hash::SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/lib.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | fn is_sorted(data: &Vec) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/lib.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match last_entry { [INFO] [stderr] 25 | | Some(l) => { [INFO] [stderr] 26 | | if !(l.le(&x)) { [INFO] [stderr] 27 | | return false; [INFO] [stderr] ... | [INFO] [stderr] 30 | | None => {} [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(l) = last_entry { [INFO] [stderr] 25 | if !(l.le(&x)) { [INFO] [stderr] 26 | return false; [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/lib.rs:83:27 [INFO] [stderr] | [INFO] [stderr] 83 | fn guess_entropy(data: &Vec) -> f64 where T: MyHash { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/lib.rs:133:37 [INFO] [stderr] | [INFO] [stderr] 133 | let mut positions: Vec = (0..(CFG_N + 1)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=CFG_N)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.98s [INFO] running `"docker" "inspect" "6f25f52f8f8a0b6697ffede5b455250910296d66319f69aed4395c0f85b36351"` [INFO] running `"docker" "rm" "-f" "6f25f52f8f8a0b6697ffede5b455250910296d66319f69aed4395c0f85b36351"` [INFO] [stdout] 6f25f52f8f8a0b6697ffede5b455250910296d66319f69aed4395c0f85b36351