[INFO] crate rdf_translator 0.1.3 is already in cache [INFO] extracting crate rdf_translator 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/rdf_translator/0.1.3 [INFO] extracting crate rdf_translator 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rdf_translator/0.1.3 [INFO] validating manifest of rdf_translator-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rdf_translator-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rdf_translator-0.1.3 [INFO] finished frobbing rdf_translator-0.1.3 [INFO] frobbed toml for rdf_translator-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/rdf_translator/0.1.3/Cargo.toml [INFO] started frobbing rdf_translator-0.1.3 [INFO] finished frobbing rdf_translator-0.1.3 [INFO] frobbed toml for rdf_translator-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rdf_translator/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rdf_translator-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rdf_translator/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdc2f12f0df2ef6be0a1ab06ddc97d6115adaab697d4533aa4981a1529467bb5 [INFO] running `"docker" "start" "-a" "fdc2f12f0df2ef6be0a1ab06ddc97d6115adaab697d4533aa4981a1529467bb5"` [INFO] [stderr] Checking rdf v0.1.4 [INFO] [stderr] Checking jsonpath v0.1.1 [INFO] [stderr] Checking rdf_translator v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter/converter.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | graph: graph [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `graph` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter/converter.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | graph: graph [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `graph` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/converter/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod converter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/converter/converter.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | subject [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/converter/converter.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let subject = self.graph.create_uri_node(&Uri::new(value.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/definition/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod definition; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/ebucore.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | const EBUCORE_NAMESPACE: &'static str = "http://www.ebu.ch/metadata/ontologies/ebucore/ebucore#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/owl.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const OWL_NAMESPACE: &'static str = "http://www.w3.org/2002/07/owl#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/rdf.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const RDF_NAMESPACE: &'static str = "http://www.w3.org/1999/02/22-rdf-syntax-ns#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/rdfs.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const RDFS_NAMESPACE: &'static str = "http://www.w3.org/2000/01/rdf-schema#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/xsi.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const XSI_NAMESPACE: &'static str = "http://www.w3.org/2001/XMLSchema-instance"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/converter/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod converter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/converter/converter.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | subject [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/converter/converter.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let subject = self.graph.create_uri_node(&Uri::new(value.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/definition/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod definition; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/ebucore.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | const EBUCORE_NAMESPACE: &'static str = "http://www.ebu.ch/metadata/ontologies/ebucore/ebucore#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/owl.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const OWL_NAMESPACE: &'static str = "http://www.w3.org/2002/07/owl#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/rdf.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const RDF_NAMESPACE: &'static str = "http://www.w3.org/1999/02/22-rdf-syntax-ns#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/rdfs.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const RDFS_NAMESPACE: &'static str = "http://www.w3.org/2000/01/rdf-schema#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/definition/xsi.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const XSI_NAMESPACE: &'static str = "http://www.w3.org/2001/XMLSchema-instance"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `converter::converter::Converter` [INFO] [stderr] --> src/converter/converter.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Converter { [INFO] [stderr] 34 | | let ebucore = EbuCore{}; [INFO] [stderr] 35 | | let owl = Owl{}; [INFO] [stderr] 36 | | let rdf = Rdf{}; [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for converter::converter::Converter { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `converter::converter::Converter` [INFO] [stderr] --> src/converter/converter.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Converter { [INFO] [stderr] 34 | | let ebucore = EbuCore{}; [INFO] [stderr] 35 | | let owl = Owl{}; [INFO] [stderr] 36 | | let rdf = Rdf{}; [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for converter::converter::Converter { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/mapper/loader.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / match get_one(&document, &json_path) { [INFO] [stderr] 71 | | Some(Value::String(content)) => { [INFO] [stderr] 72 | | result += &content; [INFO] [stderr] 73 | | }, [INFO] [stderr] 74 | | _ => {}, [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(Value::String(content)) = get_one(&document, &json_path) { [INFO] [stderr] 71 | result += &content; [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/mapper/loader.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / match get_one(&document, &json_path) { [INFO] [stderr] 71 | | Some(Value::String(content)) => { [INFO] [stderr] 72 | | result += &content; [INFO] [stderr] 73 | | }, [INFO] [stderr] 74 | | _ => {}, [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(Value::String(content)) = get_one(&document, &json_path) { [INFO] [stderr] 71 | result += &content; [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.22s [INFO] running `"docker" "inspect" "fdc2f12f0df2ef6be0a1ab06ddc97d6115adaab697d4533aa4981a1529467bb5"` [INFO] running `"docker" "rm" "-f" "fdc2f12f0df2ef6be0a1ab06ddc97d6115adaab697d4533aa4981a1529467bb5"` [INFO] [stdout] fdc2f12f0df2ef6be0a1ab06ddc97d6115adaab697d4533aa4981a1529467bb5