[INFO] crate rddl 0.1.1 is already in cache [INFO] extracting crate rddl 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/rddl/0.1.1 [INFO] extracting crate rddl 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rddl/0.1.1 [INFO] validating manifest of rddl-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rddl-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rddl-0.1.1 [INFO] finished frobbing rddl-0.1.1 [INFO] frobbed toml for rddl-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/rddl/0.1.1/Cargo.toml [INFO] started frobbing rddl-0.1.1 [INFO] finished frobbing rddl-0.1.1 [INFO] frobbed toml for rddl-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rddl/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rddl-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rddl/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88c93d5ac2338121c1612c52e7f574e824517816c1a25b93f7d1ff808822c166 [INFO] running `"docker" "start" "-a" "88c93d5ac2338121c1612c52e7f574e824517816c1a25b93f7d1ff808822c166"` [INFO] [stderr] Checking rddl v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | vector: vector, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `vector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | matrix: matrix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:99:4 [INFO] [stderr] | [INFO] [stderr] 99 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:100:4 [INFO] [stderr] | [INFO] [stderr] 100 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:102:4 [INFO] [stderr] | [INFO] [stderr] 102 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:236:31 [INFO] [stderr] | [INFO] [stderr] 236 | path.map(|(name, items)| Ref{name: name, path: items}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | vector: vector, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `vector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | matrix: matrix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:99:4 [INFO] [stderr] | [INFO] [stderr] 99 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:100:4 [INFO] [stderr] | [INFO] [stderr] 100 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:102:4 [INFO] [stderr] | [INFO] [stderr] 102 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:236:31 [INFO] [stderr] | [INFO] [stderr] 236 | path.map(|(name, items)| Ref{name: name, path: items}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/parser.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | primitive_type() - space() + name().opt() >> |(type_name, name):(String, Option)| { [INFO] [stderr] | _____^ [INFO] [stderr] 19 | | primitive_data(type_name).map(move |mut item| { [INFO] [stderr] 20 | | item.set_name(name.clone()); [INFO] [stderr] 21 | | item [INFO] [stderr] 22 | | }) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 18 | (primitive_type() - space() + name().opt()) >> |(type_name, name):(String, Option)| { [INFO] [stderr] 19 | primitive_data(type_name).map(move |mut item| { [INFO] [stderr] 20 | item.set_name(name.clone()); [INFO] [stderr] 21 | item [INFO] [stderr] 22 | }) [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/parser.rs:169:16 [INFO] [stderr] | [INFO] [stderr] 169 | let integer = one_of(b"123456789") - one_of(b"0123456789").repeat(0..) | sym(b'0'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(one_of(b"123456789") - one_of(b"0123456789").repeat(0..)) | sym(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/parser.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | primitive_type() - space() + name().opt() >> |(type_name, name):(String, Option)| { [INFO] [stderr] | _____^ [INFO] [stderr] 19 | | primitive_data(type_name).map(move |mut item| { [INFO] [stderr] 20 | | item.set_name(name.clone()); [INFO] [stderr] 21 | | item [INFO] [stderr] 22 | | }) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 18 | (primitive_type() - space() + name().opt()) >> |(type_name, name):(String, Option)| { [INFO] [stderr] 19 | primitive_data(type_name).map(move |mut item| { [INFO] [stderr] 20 | item.set_name(name.clone()); [INFO] [stderr] 21 | item [INFO] [stderr] 22 | }) [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/parser.rs:169:16 [INFO] [stderr] | [INFO] [stderr] 169 | let integer = one_of(b"123456789") - one_of(b"0123456789").repeat(0..) | sym(b'0'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(one_of(b"123456789") - one_of(b"0123456789").repeat(0..)) | sym(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | 1094861636, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_094_861_636` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | 0x41424344, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4142_4344` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | 0o10120441504, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0o10_120_441_504` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 28 | | &mut DataItem::Primitive{ref mut name, ..} => *name = new_name, [INFO] [stderr] 29 | | &mut DataItem::Vector{ref mut name, ..} => *name = new_name, [INFO] [stderr] 30 | | &mut DataItem::Matrix{ref mut name, ..} => *name = new_name, [INFO] [stderr] 31 | | &mut DataItem::Custom{ref mut name, ..} => *name = new_name, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | DataItem::Primitive{ref mut name, ..} => *name = new_name, [INFO] [stderr] 29 | DataItem::Vector{ref mut name, ..} => *name = new_name, [INFO] [stderr] 30 | DataItem::Matrix{ref mut name, ..} => *name = new_name, [INFO] [stderr] 31 | DataItem::Custom{ref mut name, ..} => *name = new_name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:51:67 [INFO] [stderr] | [INFO] [stderr] 51 | "bool" => list(parse_bool() - space(), sym(b',') * space()).map(|vals| PrimitiveVector::Bool(vals)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:52:63 [INFO] [stderr] | [INFO] [stderr] 52 | "i8" => list(parse_i8() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:53:65 [INFO] [stderr] | [INFO] [stderr] 53 | "i16" => list(parse_i16() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:54:65 [INFO] [stderr] | [INFO] [stderr] 54 | "i32" => list(parse_i32() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:55:65 [INFO] [stderr] | [INFO] [stderr] 55 | "i64" => list(parse_i64() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:56:63 [INFO] [stderr] | [INFO] [stderr] 56 | "u8" => list(parse_u8() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:57:65 [INFO] [stderr] | [INFO] [stderr] 57 | "u16" => list(parse_u16() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:58:65 [INFO] [stderr] | [INFO] [stderr] 58 | "u32" => list(parse_u32() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | "u64" => list(parse_u64() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:60:65 [INFO] [stderr] | [INFO] [stderr] 60 | "f32" => list(parse_f32() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::F32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:61:65 [INFO] [stderr] | [INFO] [stderr] 61 | "f64" => list(parse_f64() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::F64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:62:62 [INFO] [stderr] | [INFO] [stderr] 62 | "str" => list(string() - space(), sym(b',') * space()).map(|texts| PrimitiveVector::Str(texts)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:63:65 [INFO] [stderr] | [INFO] [stderr] 63 | "ref" => list(reference() - space(), sym(b',') * space()).map(|refs| PrimitiveVector::Ref(refs)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:64:71 [INFO] [stderr] | [INFO] [stderr] 64 | "type" => list(primitive_type() - space(), sym(b',') * space()).map(|names| PrimitiveVector::Type(names)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:72:138 [INFO] [stderr] | [INFO] [stderr] 72 | "bool" => list(sym(b'{') * space() * list(parse_bool() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|vals| PrimitiveMatrix::Bool(vals)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:73:134 [INFO] [stderr] | [INFO] [stderr] 73 | "i8" => list(sym(b'{') * space() * list(parse_i8() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:74:136 [INFO] [stderr] | [INFO] [stderr] 74 | "i16" => list(sym(b'{') * space() * list(parse_i16() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:75:136 [INFO] [stderr] | [INFO] [stderr] 75 | "i32" => list(sym(b'{') * space() * list(parse_i32() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:76:136 [INFO] [stderr] | [INFO] [stderr] 76 | "i64" => list(sym(b'{') * space() * list(parse_i64() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:77:134 [INFO] [stderr] | [INFO] [stderr] 77 | "u8" => list(sym(b'{') * space() * list(parse_u8() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:78:136 [INFO] [stderr] | [INFO] [stderr] 78 | "u16" => list(sym(b'{') * space() * list(parse_u16() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:79:136 [INFO] [stderr] | [INFO] [stderr] 79 | "u32" => list(sym(b'{') * space() * list(parse_u32() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:80:136 [INFO] [stderr] | [INFO] [stderr] 80 | "u64" => list(sym(b'{') * space() * list(parse_u64() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:81:136 [INFO] [stderr] | [INFO] [stderr] 81 | "f32" => list(sym(b'{') * space() * list(parse_f32() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::F32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:82:136 [INFO] [stderr] | [INFO] [stderr] 82 | "f64" => list(sym(b'{') * space() * list(parse_f64() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::F64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:83:133 [INFO] [stderr] | [INFO] [stderr] 83 | "str" => list(sym(b'{') * space() * list(string() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|texts| PrimitiveMatrix::Str(texts)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:84:136 [INFO] [stderr] | [INFO] [stderr] 84 | "ref" => list(sym(b'{') * space() * list(reference() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|refs| PrimitiveMatrix::Ref(refs)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:85:142 [INFO] [stderr] | [INFO] [stderr] 85 | "type" => list(sym(b'{') * space() * list(primitive_type() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|names| PrimitiveMatrix::Type(names)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parser.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | properties: properties.unwrap_or(HashMap::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `properties.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | identifier.collect().convert(|bytes| String::from_utf8(bytes)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | .convert(|bytes| String::from_utf8(bytes)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:125:30 [INFO] [stderr] | [INFO] [stderr] 125 | "bool" => parse_bool().map(|val| PrimitiveValue::Bool(val)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | "i8" => parse_i8().map(|num|PrimitiveValue::I8(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:127:28 [INFO] [stderr] | [INFO] [stderr] 127 | "i16" => parse_i16().map(|num|PrimitiveValue::I16(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | "i32" => parse_i32().map(|num|PrimitiveValue::I32(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:129:28 [INFO] [stderr] | [INFO] [stderr] 129 | "i64" => parse_i64().map(|num|PrimitiveValue::I64(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | "u8" => parse_u8().map(|num|PrimitiveValue::U8(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:131:28 [INFO] [stderr] | [INFO] [stderr] 131 | "u16" => parse_u16().map(|num|PrimitiveValue::U16(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:132:28 [INFO] [stderr] | [INFO] [stderr] 132 | "u32" => parse_u32().map(|num|PrimitiveValue::U32(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:133:28 [INFO] [stderr] | [INFO] [stderr] 133 | "u64" => parse_u64().map(|num|PrimitiveValue::U64(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | "f32" => parse_f32().map(|num|PrimitiveValue::F32(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:135:28 [INFO] [stderr] | [INFO] [stderr] 135 | "f64" => parse_f64().map(|num|PrimitiveValue::F64(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | "str" => string().map(|text| PrimitiveValue::Str(text)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:137:28 [INFO] [stderr] | [INFO] [stderr] 137 | "ref" => reference().map(|refer|PrimitiveValue::Ref(refer)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | "type" => primitive_type().map(|name| PrimitiveValue::Type(name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | | parse_u64().map(|num|PrimitiveValue::U64(num)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | | parse_i64().map(|num|PrimitiveValue::I64(num)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | | parse_f64().map(|num|PrimitiveValue::F64(num)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | | string().map(|text| PrimitiveValue::Str(text)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | | reference().map(|refer|PrimitiveValue::Ref(refer)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | | primitive_type().map(|name| PrimitiveValue::Type(name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:173:27 [INFO] [stderr] | [INFO] [stderr] 173 | number.collect().convert(|v|String::from_utf8(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:226:77 [INFO] [stderr] | [INFO] [stderr] 226 | let utf8_string = (none_of(b"\\\"") | escape_sequence).repeat(1..).convert(|bytes|String::from_utf8(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 28 | | &mut DataItem::Primitive{ref mut name, ..} => *name = new_name, [INFO] [stderr] 29 | | &mut DataItem::Vector{ref mut name, ..} => *name = new_name, [INFO] [stderr] 30 | | &mut DataItem::Matrix{ref mut name, ..} => *name = new_name, [INFO] [stderr] 31 | | &mut DataItem::Custom{ref mut name, ..} => *name = new_name, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | DataItem::Primitive{ref mut name, ..} => *name = new_name, [INFO] [stderr] 29 | DataItem::Vector{ref mut name, ..} => *name = new_name, [INFO] [stderr] 30 | DataItem::Matrix{ref mut name, ..} => *name = new_name, [INFO] [stderr] 31 | DataItem::Custom{ref mut name, ..} => *name = new_name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:51:67 [INFO] [stderr] | [INFO] [stderr] 51 | "bool" => list(parse_bool() - space(), sym(b',') * space()).map(|vals| PrimitiveVector::Bool(vals)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:52:63 [INFO] [stderr] | [INFO] [stderr] 52 | "i8" => list(parse_i8() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:53:65 [INFO] [stderr] | [INFO] [stderr] 53 | "i16" => list(parse_i16() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:54:65 [INFO] [stderr] | [INFO] [stderr] 54 | "i32" => list(parse_i32() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:55:65 [INFO] [stderr] | [INFO] [stderr] 55 | "i64" => list(parse_i64() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::I64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:56:63 [INFO] [stderr] | [INFO] [stderr] 56 | "u8" => list(parse_u8() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:57:65 [INFO] [stderr] | [INFO] [stderr] 57 | "u16" => list(parse_u16() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:58:65 [INFO] [stderr] | [INFO] [stderr] 58 | "u32" => list(parse_u32() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | "u64" => list(parse_u64() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::U64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:60:65 [INFO] [stderr] | [INFO] [stderr] 60 | "f32" => list(parse_f32() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::F32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:61:65 [INFO] [stderr] | [INFO] [stderr] 61 | "f64" => list(parse_f64() - space(), sym(b',') * space()).map(|nums|PrimitiveVector::F64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:62:62 [INFO] [stderr] | [INFO] [stderr] 62 | "str" => list(string() - space(), sym(b',') * space()).map(|texts| PrimitiveVector::Str(texts)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:63:65 [INFO] [stderr] | [INFO] [stderr] 63 | "ref" => list(reference() - space(), sym(b',') * space()).map(|refs| PrimitiveVector::Ref(refs)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:64:71 [INFO] [stderr] | [INFO] [stderr] 64 | "type" => list(primitive_type() - space(), sym(b',') * space()).map(|names| PrimitiveVector::Type(names)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveVector::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:72:138 [INFO] [stderr] | [INFO] [stderr] 72 | "bool" => list(sym(b'{') * space() * list(parse_bool() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|vals| PrimitiveMatrix::Bool(vals)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:73:134 [INFO] [stderr] | [INFO] [stderr] 73 | "i8" => list(sym(b'{') * space() * list(parse_i8() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:74:136 [INFO] [stderr] | [INFO] [stderr] 74 | "i16" => list(sym(b'{') * space() * list(parse_i16() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:75:136 [INFO] [stderr] | [INFO] [stderr] 75 | "i32" => list(sym(b'{') * space() * list(parse_i32() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:76:136 [INFO] [stderr] | [INFO] [stderr] 76 | "i64" => list(sym(b'{') * space() * list(parse_i64() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::I64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:77:134 [INFO] [stderr] | [INFO] [stderr] 77 | "u8" => list(sym(b'{') * space() * list(parse_u8() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U8(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:78:136 [INFO] [stderr] | [INFO] [stderr] 78 | "u16" => list(sym(b'{') * space() * list(parse_u16() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U16(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:79:136 [INFO] [stderr] | [INFO] [stderr] 79 | "u32" => list(sym(b'{') * space() * list(parse_u32() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:80:136 [INFO] [stderr] | [INFO] [stderr] 80 | "u64" => list(sym(b'{') * space() * list(parse_u64() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::U64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:81:136 [INFO] [stderr] | [INFO] [stderr] 81 | "f32" => list(sym(b'{') * space() * list(parse_f32() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::F32(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:82:136 [INFO] [stderr] | [INFO] [stderr] 82 | "f64" => list(sym(b'{') * space() * list(parse_f64() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|nums|PrimitiveMatrix::F64(nums)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:83:133 [INFO] [stderr] | [INFO] [stderr] 83 | "str" => list(sym(b'{') * space() * list(string() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|texts| PrimitiveMatrix::Str(texts)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:84:136 [INFO] [stderr] | [INFO] [stderr] 84 | "ref" => list(sym(b'{') * space() * list(reference() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|refs| PrimitiveMatrix::Ref(refs)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:85:142 [INFO] [stderr] | [INFO] [stderr] 85 | "type" => list(sym(b'{') * space() * list(primitive_type() - space(), sym(b',') * space()) - sym(b'}') - space(), sym(b',') * space()).map(|names| PrimitiveMatrix::Type(names)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveMatrix::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parser.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | properties: properties.unwrap_or(HashMap::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `properties.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | identifier.collect().convert(|bytes| String::from_utf8(bytes)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | .convert(|bytes| String::from_utf8(bytes)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:125:30 [INFO] [stderr] | [INFO] [stderr] 125 | "bool" => parse_bool().map(|val| PrimitiveValue::Bool(val)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | "i8" => parse_i8().map(|num|PrimitiveValue::I8(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:127:28 [INFO] [stderr] | [INFO] [stderr] 127 | "i16" => parse_i16().map(|num|PrimitiveValue::I16(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | "i32" => parse_i32().map(|num|PrimitiveValue::I32(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:129:28 [INFO] [stderr] | [INFO] [stderr] 129 | "i64" => parse_i64().map(|num|PrimitiveValue::I64(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | "u8" => parse_u8().map(|num|PrimitiveValue::U8(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:131:28 [INFO] [stderr] | [INFO] [stderr] 131 | "u16" => parse_u16().map(|num|PrimitiveValue::U16(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:132:28 [INFO] [stderr] | [INFO] [stderr] 132 | "u32" => parse_u32().map(|num|PrimitiveValue::U32(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:133:28 [INFO] [stderr] | [INFO] [stderr] 133 | "u64" => parse_u64().map(|num|PrimitiveValue::U64(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | "f32" => parse_f32().map(|num|PrimitiveValue::F32(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:135:28 [INFO] [stderr] | [INFO] [stderr] 135 | "f64" => parse_f64().map(|num|PrimitiveValue::F64(num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | "str" => string().map(|text| PrimitiveValue::Str(text)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:137:28 [INFO] [stderr] | [INFO] [stderr] 137 | "ref" => reference().map(|refer|PrimitiveValue::Ref(refer)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | "type" => primitive_type().map(|name| PrimitiveValue::Type(name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | | parse_u64().map(|num|PrimitiveValue::U64(num)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::U64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | | parse_i64().map(|num|PrimitiveValue::I64(num)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::I64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | | parse_f64().map(|num|PrimitiveValue::F64(num)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::F64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | | string().map(|text| PrimitiveValue::Str(text)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | | reference().map(|refer|PrimitiveValue::Ref(refer)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | | primitive_type().map(|name| PrimitiveValue::Type(name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PrimitiveValue::Type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:173:27 [INFO] [stderr] | [INFO] [stderr] 173 | number.collect().convert(|v|String::from_utf8(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:226:77 [INFO] [stderr] | [INFO] [stderr] 226 | let utf8_string = (none_of(b"\\\"") | escape_sequence).repeat(1..).convert(|bytes|String::from_utf8(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.84s [INFO] running `"docker" "inspect" "88c93d5ac2338121c1612c52e7f574e824517816c1a25b93f7d1ff808822c166"` [INFO] running `"docker" "rm" "-f" "88c93d5ac2338121c1612c52e7f574e824517816c1a25b93f7d1ff808822c166"` [INFO] [stdout] 88c93d5ac2338121c1612c52e7f574e824517816c1a25b93f7d1ff808822c166