[INFO] crate rdb 0.2.1 is already in cache [INFO] extracting crate rdb 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/rdb/0.2.1 [INFO] extracting crate rdb 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rdb/0.2.1 [INFO] validating manifest of rdb-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rdb-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rdb-0.2.1 [INFO] finished frobbing rdb-0.2.1 [INFO] frobbed toml for rdb-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/rdb/0.2.1/Cargo.toml [INFO] started frobbing rdb-0.2.1 [INFO] finished frobbing rdb-0.2.1 [INFO] frobbed toml for rdb-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rdb/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rdb-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rdb/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc27ea4b5ded941d2bd6c86c78fbf7a085006e3d4b982bd179f1d57b8f51fea2 [INFO] running `"docker" "start" "-a" "dc27ea4b5ded941d2bd6c86c78fbf7a085006e3d4b982bd179f1d57b8f51fea2"` [INFO] [stderr] Checking lzf v0.3.1 [INFO] [stderr] Checking rdb v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | formatter: formatter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/plain.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Plain { out: out, dbnum: 0, index: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/json.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/protocol.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | Protocol { out: out, last_expiry: None } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | formatter: formatter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/plain.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Plain { out: out, dbnum: 0, index: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/json.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/protocol.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | Protocol { out: out, last_expiry: None } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / macro_rules! ensure { [INFO] [stderr] 4 | | ($expr:expr, $err_result:expr) => ( [INFO] [stderr] 5 | | if !($expr) { return $err_result; } [INFO] [stderr] 6 | | ) [INFO] [stderr] 7 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / macro_rules! fail { [INFO] [stderr] 10 | | ($expr:expr) => ( [INFO] [stderr] 11 | | return Err(::std::error::FromError::from_error($expr)); [INFO] [stderr] 12 | | ) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / macro_rules! unwrap_or { [INFO] [stderr] 16 | | ($expr:expr, $or:expr) => ( [INFO] [stderr] 17 | | match $expr { [INFO] [stderr] 18 | | Some(x) => x, [INFO] [stderr] ... | [INFO] [stderr] 21 | | ) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / macro_rules! try_or_ok { [INFO] [stderr] 33 | | ($expr:expr) => (match $expr { [INFO] [stderr] 34 | | Ok(_) => Ok(()), [INFO] [stderr] 35 | | e => e [INFO] [stderr] 36 | | }) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / macro_rules! unpack_ziplist_entry { [INFO] [stderr] 40 | | ($data:expr) => ({ [INFO] [stderr] 41 | | let entry = try!($data); [INFO] [stderr] 42 | | match entry { [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RDB_MAGIC : &'static str = "REDIS"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / macro_rules! ensure { [INFO] [stderr] 4 | | ($expr:expr, $err_result:expr) => ( [INFO] [stderr] 5 | | if !($expr) { return $err_result; } [INFO] [stderr] 6 | | ) [INFO] [stderr] 7 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / macro_rules! fail { [INFO] [stderr] 10 | | ($expr:expr) => ( [INFO] [stderr] 11 | | return Err(::std::error::FromError::from_error($expr)); [INFO] [stderr] 12 | | ) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / macro_rules! unwrap_or { [INFO] [stderr] 16 | | ($expr:expr, $or:expr) => ( [INFO] [stderr] 17 | | match $expr { [INFO] [stderr] 18 | | Some(x) => x, [INFO] [stderr] ... | [INFO] [stderr] 21 | | ) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / macro_rules! try_or_ok { [INFO] [stderr] 33 | | ($expr:expr) => (match $expr { [INFO] [stderr] 34 | | Ok(_) => Ok(()), [INFO] [stderr] 35 | | e => e [INFO] [stderr] 36 | | }) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / macro_rules! unpack_ziplist_entry { [INFO] [stderr] 40 | | ($data:expr) => ({ [INFO] [stderr] 41 | | let entry = try!($data); [INFO] [stderr] 42 | | match entry { [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RDB_MAGIC : &'static str = "REDIS"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | length = (enc_type & 0x3F) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(enc_type & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | length = (enc_type & 0x3F) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(enc_type & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:63:23 [INFO] [stderr] | [INFO] [stderr] 63 | length = (((enc_type & 0x3F) as u32) <<8) | next_byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(enc_type & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:63:57 [INFO] [stderr] | [INFO] [stderr] 63 | length = (((enc_type & 0x3F) as u32) <<8) | next_byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | let version = (version[0]-48) as u32 * 1000 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[0]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | (version[1]-48) as u32 * 100 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[1]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | (version[2]-48) as u32 * 10 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[2]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | (version[3]-48) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[3]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | encoding::INT8 => { helper::int_to_vec(try!(input.read_i8()) as i32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 121 | encoding::INT8 => { helper::int_to_vec(i32::from(match $ expr { [INFO] [stderr] 122 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 123 | :: Err ( err ) => { [INFO] [stderr] 124 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 125 | $ crate :: convert :: From :: from ( err ) ) } })) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:122:53 [INFO] [stderr] | [INFO] [stderr] 122 | encoding::INT16 => { helper::int_to_vec(try!(input.read_i16::()) as i32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | encoding::INT16 => { helper::int_to_vec(i32::from(match $ expr { [INFO] [stderr] 123 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 124 | :: Err ( err ) => { [INFO] [stderr] 125 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 126 | $ crate :: convert :: From :: from ( err ) ) } })) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:191:49 [INFO] [stderr] | [INFO] [stderr] 191 | self.last_expiretime = Some(expiretime as u64 * 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(expiretime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:323:29 [INFO] [stderr] | [INFO] [stderr] 323 | 0 => { length = (flag & 0x3F) as u64 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(flag & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:326:27 [INFO] [stderr] | [INFO] [stderr] 326 | length = (((flag & 0x3F) as u64) << 8) | next_byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(flag & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:326:58 [INFO] [stderr] | [INFO] [stderr] 326 | length = (((flag & 0x3F) as u64) << 8) | next_byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:329:26 [INFO] [stderr] | [INFO] [stderr] 329 | length = try!(ziplist.read_u32::()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 329 | length = u64::from(match $ expr { [INFO] [stderr] 330 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 331 | :: Err ( err ) => { [INFO] [stderr] 332 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 333 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:333:45 [INFO] [stderr] | [INFO] [stderr] 333 | 0xC => { number_value = try!(ziplist.read_i16::()) as i64 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 333 | 0xC => { number_value = i64::from(match $ expr { [INFO] [stderr] 334 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 335 | :: Err ( err ) => { [INFO] [stderr] 336 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 337 | $ crate :: convert :: From :: from ( err ) ) } }) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:334:45 [INFO] [stderr] | [INFO] [stderr] 334 | 0xD => { number_value = try!(ziplist.read_i32::()) as i64 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 334 | 0xD => { number_value = i64::from(match $ expr { [INFO] [stderr] 335 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 336 | :: Err ( err ) => { [INFO] [stderr] 337 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 338 | $ crate :: convert :: From :: from ( err ) ) } }) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:347:38 [INFO] [stderr] | [INFO] [stderr] 347 | ((bytes[2] as i32) << 24) ^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:348:38 [INFO] [stderr] | [INFO] [stderr] 348 | ((bytes[1] as i32) << 16) ^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:349:38 [INFO] [stderr] | [INFO] [stderr] 349 | ((bytes[0] as i32) << 8) ^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:352:48 [INFO] [stderr] | [INFO] [stderr] 352 | number_value = number as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:355:48 [INFO] [stderr] | [INFO] [stderr] 355 | number_value = try!(ziplist.read_i8()) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 355 | number_value = i64::from(match $ expr { [INFO] [stderr] 356 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 357 | :: Err ( err ) => { [INFO] [stderr] 358 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 359 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:358:48 [INFO] [stderr] | [INFO] [stderr] 358 | number_value = (flag & 0xF) as i64 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(flag & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:392:40 [INFO] [stderr] | [INFO] [stderr] 392 | self.formatter.start_list(key, zllen as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(zllen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:421:40 [INFO] [stderr] | [INFO] [stderr] 421 | self.formatter.start_hash(key, zllen as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(zllen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:448:46 [INFO] [stderr] | [INFO] [stderr] 448 | self.formatter.start_sorted_set(key, zllen as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(zllen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:500:31 [INFO] [stderr] | [INFO] [stderr] 500 | _ => { elem_len = next_byte as u32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:517:22 [INFO] [stderr] | [INFO] [stderr] 517 | length = zmlen as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(zmlen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:524:40 [INFO] [stderr] | [INFO] [stderr] 524 | self.formatter.start_hash(key, size as u32, self.last_expiretime, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:574:22 [INFO] [stderr] | [INFO] [stderr] 574 | 2 => try!(reader.read_i16::()) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 574 | 2 => i64::from(match $ expr { [INFO] [stderr] 575 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 576 | :: Err ( err ) => { [INFO] [stderr] 577 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 578 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:575:22 [INFO] [stderr] | [INFO] [stderr] 575 | 4 => try!(reader.read_i32::()) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 575 | 4 => i64::from(match $ expr { [INFO] [stderr] 576 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 577 | :: Err ( err ) => { [INFO] [stderr] 578 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 579 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | length = (enc_type & 0x3F) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(enc_type & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | length = (enc_type & 0x3F) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(enc_type & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:63:23 [INFO] [stderr] | [INFO] [stderr] 63 | length = (((enc_type & 0x3F) as u32) <<8) | next_byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(enc_type & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:63:57 [INFO] [stderr] | [INFO] [stderr] 63 | length = (((enc_type & 0x3F) as u32) <<8) | next_byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | let version = (version[0]-48) as u32 * 1000 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[0]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | (version[1]-48) as u32 * 100 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[1]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | (version[2]-48) as u32 * 10 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[2]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | (version[3]-48) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(version[3]-48)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `formatter::nil::Nil` [INFO] [stderr] --> src/formatter/nil.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Nil { [INFO] [stderr] 7 | | Nil [INFO] [stderr] 8 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::plain::Plain` [INFO] [stderr] --> src/formatter/plain.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Plain { [INFO] [stderr] 17 | | let out = Box::new(io::stdout()); [INFO] [stderr] 18 | | Plain { out: out, dbnum: 0, index: 0 } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for formatter::plain::Plain { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | encoding::INT8 => { helper::int_to_vec(try!(input.read_i8()) as i32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 121 | encoding::INT8 => { helper::int_to_vec(i32::from(match $ expr { [INFO] [stderr] 122 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 123 | :: Err ( err ) => { [INFO] [stderr] 124 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 125 | $ crate :: convert :: From :: from ( err ) ) } })) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:122:53 [INFO] [stderr] | [INFO] [stderr] 122 | encoding::INT16 => { helper::int_to_vec(try!(input.read_i16::()) as i32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | encoding::INT16 => { helper::int_to_vec(i32::from(match $ expr { [INFO] [stderr] 123 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 124 | :: Err ( err ) => { [INFO] [stderr] 125 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 126 | $ crate :: convert :: From :: from ( err ) ) } })) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::json::JSON` [INFO] [stderr] --> src/formatter/json.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> JSON { [INFO] [stderr] 22 | | let out = Box::new(io::stdout()); [INFO] [stderr] 23 | | JSON { [INFO] [stderr] 24 | | out: out, [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for formatter::json::JSON { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::protocol::Protocol` [INFO] [stderr] --> src/formatter/protocol.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Protocol { [INFO] [stderr] 16 | | let out = Box::new(io::stdout()); [INFO] [stderr] 17 | | Protocol { out: out, last_expiry: None } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for formatter::protocol::Protocol { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:191:49 [INFO] [stderr] | [INFO] [stderr] 191 | self.last_expiretime = Some(expiretime as u64 * 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(expiretime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | self.emit(vec!["PEXPIREAT".as_bytes(), key, expire.as_bytes()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"PEXPIREAT"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | self.emit(vec!["SELECT".as_bytes(), db.as_bytes()]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SELECT"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | self.emit(vec!["SET".as_bytes(), key, value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SET"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | self.emit(vec!["HSET".as_bytes(), key, field, value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"HSET"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | self.emit(vec!["SADD".as_bytes(), key, member]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SADD"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | self.emit(vec!["RPUSH".as_bytes(), key, value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"RPUSH"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | self.emit(vec!["ZADD".as_bytes(), key, score.as_bytes(), member]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ZADD"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/formatter/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | out.write(data.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filter::Simple` [INFO] [stderr] --> src/filter.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Simple { [INFO] [stderr] 20 | | Simple { databases: vec![], types: vec![], keys: None } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:323:29 [INFO] [stderr] | [INFO] [stderr] 323 | 0 => { length = (flag & 0x3F) as u64 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(flag & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:326:27 [INFO] [stderr] | [INFO] [stderr] 326 | length = (((flag & 0x3F) as u64) << 8) | next_byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(flag & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:326:58 [INFO] [stderr] | [INFO] [stderr] 326 | length = (((flag & 0x3F) as u64) << 8) | next_byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:329:26 [INFO] [stderr] | [INFO] [stderr] 329 | length = try!(ziplist.read_u32::()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 329 | length = u64::from(match $ expr { [INFO] [stderr] 330 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 331 | :: Err ( err ) => { [INFO] [stderr] 332 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 333 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:333:45 [INFO] [stderr] | [INFO] [stderr] 333 | 0xC => { number_value = try!(ziplist.read_i16::()) as i64 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 333 | 0xC => { number_value = i64::from(match $ expr { [INFO] [stderr] 334 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 335 | :: Err ( err ) => { [INFO] [stderr] 336 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 337 | $ crate :: convert :: From :: from ( err ) ) } }) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:334:45 [INFO] [stderr] | [INFO] [stderr] 334 | 0xD => { number_value = try!(ziplist.read_i32::()) as i64 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 334 | 0xD => { number_value = i64::from(match $ expr { [INFO] [stderr] 335 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 336 | :: Err ( err ) => { [INFO] [stderr] 337 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 338 | $ crate :: convert :: From :: from ( err ) ) } }) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:347:38 [INFO] [stderr] | [INFO] [stderr] 347 | ((bytes[2] as i32) << 24) ^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:348:38 [INFO] [stderr] | [INFO] [stderr] 348 | ((bytes[1] as i32) << 16) ^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:349:38 [INFO] [stderr] | [INFO] [stderr] 349 | ((bytes[0] as i32) << 8) ^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:352:48 [INFO] [stderr] | [INFO] [stderr] 352 | number_value = number as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:355:48 [INFO] [stderr] | [INFO] [stderr] 355 | number_value = try!(ziplist.read_i8()) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 355 | number_value = i64::from(match $ expr { [INFO] [stderr] 356 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 357 | :: Err ( err ) => { [INFO] [stderr] 358 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 359 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:358:48 [INFO] [stderr] | [INFO] [stderr] 358 | number_value = (flag & 0xF) as i64 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(flag & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:392:40 [INFO] [stderr] | [INFO] [stderr] 392 | self.formatter.start_list(key, zllen as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(zllen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `rdb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:421:40 [INFO] [stderr] | [INFO] [stderr] 421 | self.formatter.start_hash(key, zllen as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(zllen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:448:46 [INFO] [stderr] | [INFO] [stderr] 448 | self.formatter.start_sorted_set(key, zllen as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(zllen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:500:31 [INFO] [stderr] | [INFO] [stderr] 500 | _ => { elem_len = next_byte as u32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:517:22 [INFO] [stderr] | [INFO] [stderr] 517 | length = zmlen as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(zmlen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:524:40 [INFO] [stderr] | [INFO] [stderr] 524 | self.formatter.start_hash(key, size as u32, self.last_expiretime, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:574:22 [INFO] [stderr] | [INFO] [stderr] 574 | 2 => try!(reader.read_i16::()) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 574 | 2 => i64::from(match $ expr { [INFO] [stderr] 575 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 576 | :: Err ( err ) => { [INFO] [stderr] 577 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 578 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:575:22 [INFO] [stderr] | [INFO] [stderr] 575 | 4 => try!(reader.read_i32::()) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 575 | 4 => i64::from(match $ expr { [INFO] [stderr] 576 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 577 | :: Err ( err ) => { [INFO] [stderr] 578 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 579 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `formatter::nil::Nil` [INFO] [stderr] --> src/formatter/nil.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Nil { [INFO] [stderr] 7 | | Nil [INFO] [stderr] 8 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::plain::Plain` [INFO] [stderr] --> src/formatter/plain.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Plain { [INFO] [stderr] 17 | | let out = Box::new(io::stdout()); [INFO] [stderr] 18 | | Plain { out: out, dbnum: 0, index: 0 } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for formatter::plain::Plain { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::json::JSON` [INFO] [stderr] --> src/formatter/json.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> JSON { [INFO] [stderr] 22 | | let out = Box::new(io::stdout()); [INFO] [stderr] 23 | | JSON { [INFO] [stderr] 24 | | out: out, [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for formatter::json::JSON { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::protocol::Protocol` [INFO] [stderr] --> src/formatter/protocol.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Protocol { [INFO] [stderr] 16 | | let out = Box::new(io::stdout()); [INFO] [stderr] 17 | | Protocol { out: out, last_expiry: None } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for formatter::protocol::Protocol { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | self.emit(vec!["PEXPIREAT".as_bytes(), key, expire.as_bytes()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"PEXPIREAT"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | self.emit(vec!["SELECT".as_bytes(), db.as_bytes()]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SELECT"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | self.emit(vec!["SET".as_bytes(), key, value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SET"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | self.emit(vec!["HSET".as_bytes(), key, field, value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"HSET"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | self.emit(vec!["SADD".as_bytes(), key, member]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SADD"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | self.emit(vec!["RPUSH".as_bytes(), key, value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"RPUSH"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/formatter/protocol.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | self.emit(vec!["ZADD".as_bytes(), key, score.as_bytes(), member]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ZADD"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/formatter/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | out.write(data.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filter::Simple` [INFO] [stderr] --> src/filter.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Simple { [INFO] [stderr] 20 | | Simple { databases: vec![], types: vec![], keys: None } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rdb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dc27ea4b5ded941d2bd6c86c78fbf7a085006e3d4b982bd179f1d57b8f51fea2"` [INFO] running `"docker" "rm" "-f" "dc27ea4b5ded941d2bd6c86c78fbf7a085006e3d4b982bd179f1d57b8f51fea2"` [INFO] [stdout] dc27ea4b5ded941d2bd6c86c78fbf7a085006e3d4b982bd179f1d57b8f51fea2