[INFO] crate rcu_cell 0.1.3 is already in cache [INFO] extracting crate rcu_cell 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/rcu_cell/0.1.3 [INFO] extracting crate rcu_cell 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcu_cell/0.1.3 [INFO] validating manifest of rcu_cell-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rcu_cell-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rcu_cell-0.1.3 [INFO] finished frobbing rcu_cell-0.1.3 [INFO] frobbed toml for rcu_cell-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/rcu_cell/0.1.3/Cargo.toml [INFO] started frobbing rcu_cell-0.1.3 [INFO] finished frobbing rcu_cell-0.1.3 [INFO] frobbed toml for rcu_cell-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcu_cell/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rcu_cell-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rcu_cell/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36b55ceb9ef8e8698ec42a4cf118eddb19c147b4877c8c88f87c8f266196770b [INFO] running `"docker" "start" "-a" "36b55ceb9ef8e8698ec42a4cf118eddb19c147b4877c8c88f87c8f266196770b"` [INFO] [stderr] Checking rcu_cell v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | self.get().map(|d| d.unlink()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(d) = self.get() { d.unlink() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | self.get().map(|d| d.unlink()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(d) = self.get() { d.unlink() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:374:20 [INFO] [stderr] | [INFO] [stderr] 374 | assert_eq!(x.map(|v| *v), Some(10)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `x.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:375:20 [INFO] [stderr] | [INFO] [stderr] 375 | assert_eq!(y.map(|v| *v), Some(10)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `y.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:376:20 [INFO] [stderr] | [INFO] [stderr] 376 | assert_eq!(z.map(|v| *v), None); [INFO] [stderr] | ^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `z.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:377:20 [INFO] [stderr] | [INFO] [stderr] 377 | assert_eq!(a.map(|v| *v), None); [INFO] [stderr] | ^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `a.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | assert!(t1.read().map(|v| *v) == Some(10)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t1.read().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | assert!(t.read().map(|v| *v) == Some(5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t.read().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | let x = t.read().map(|v| *v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t.read().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:398:20 [INFO] [stderr] | [INFO] [stderr] 398 | assert_eq!(t.read().map(|v| *v), Some(11)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t.read().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:440:20 [INFO] [stderr] | [INFO] [stderr] 440 | assert_eq!(t.read().map(|v| *v), Some(11)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t.read().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:443:20 [INFO] [stderr] | [INFO] [stderr] 443 | assert_eq!(t.read().map(|v| *v), Some(12)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t.read().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:446:20 [INFO] [stderr] | [INFO] [stderr] 446 | assert_eq!(t.read().map(|v| *v), Some(13)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t.read().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "36b55ceb9ef8e8698ec42a4cf118eddb19c147b4877c8c88f87c8f266196770b"` [INFO] running `"docker" "rm" "-f" "36b55ceb9ef8e8698ec42a4cf118eddb19c147b4877c8c88f87c8f266196770b"` [INFO] [stdout] 36b55ceb9ef8e8698ec42a4cf118eddb19c147b4877c8c88f87c8f266196770b