[INFO] crate rcomplex 0.1.2 is already in cache [INFO] extracting crate rcomplex 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/rcomplex/0.1.2 [INFO] extracting crate rcomplex 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcomplex/0.1.2 [INFO] validating manifest of rcomplex-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rcomplex-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rcomplex-0.1.2 [INFO] finished frobbing rcomplex-0.1.2 [INFO] frobbed toml for rcomplex-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/rcomplex/0.1.2/Cargo.toml [INFO] started frobbing rcomplex-0.1.2 [INFO] finished frobbing rcomplex-0.1.2 [INFO] frobbed toml for rcomplex-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcomplex/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rcomplex-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rcomplex/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f7a681a5e51cdecf1e1d2f412be37ce93107ca5263245f39cf0d5806bd456c06 [INFO] running `"docker" "start" "-a" "f7a681a5e51cdecf1e1d2f412be37ce93107ca5263245f39cf0d5806bd456c06"` [INFO] [stderr] Checking rcomplex v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | real: real, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `real` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | img: img [INFO] [stderr] | ^^^^^^^^ help: replace it with: `img` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | real: real, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `real` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | img: img [INFO] [stderr] | ^^^^^^^^ help: replace it with: `img` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/complex.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | polar [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/complex.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let polar = Polar { [INFO] [stderr] | _____________________^ [INFO] [stderr] 45 | | r : (r2).sqrt(), [INFO] [stderr] 46 | | theta : (self.real/self.img).atan(), [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/complex.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn to_complex(self) -> Complex { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/complex.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | polar [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/complex.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let polar = Polar { [INFO] [stderr] | _____________________^ [INFO] [stderr] 45 | | r : (r2).sqrt(), [INFO] [stderr] 46 | | theta : (self.real/self.img).atan(), [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | let expected = complex::Complex::new(((c4.real).cos()*(c4.img).cosh()), (-(c4.real).sin()*(c4.img).sinh())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:71:75 [INFO] [stderr] | [INFO] [stderr] 71 | let expected = complex::Complex::new(((c4.real).cos()*(c4.img).cosh()), (-(c4.real).sin()*(c4.img).sinh())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/complex.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn to_complex(self) -> Complex { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/integration_test.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | assert!(c1 == c1); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rcomplex`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f7a681a5e51cdecf1e1d2f412be37ce93107ca5263245f39cf0d5806bd456c06"` [INFO] running `"docker" "rm" "-f" "f7a681a5e51cdecf1e1d2f412be37ce93107ca5263245f39cf0d5806bd456c06"` [INFO] [stdout] f7a681a5e51cdecf1e1d2f412be37ce93107ca5263245f39cf0d5806bd456c06