[INFO] crate rckit 0.1.0 is already in cache [INFO] extracting crate rckit 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rckit/0.1.0 [INFO] extracting crate rckit 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rckit/0.1.0 [INFO] validating manifest of rckit-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rckit-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rckit-0.1.0 [INFO] finished frobbing rckit-0.1.0 [INFO] frobbed toml for rckit-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rckit/0.1.0/Cargo.toml [INFO] started frobbing rckit-0.1.0 [INFO] finished frobbing rckit-0.1.0 [INFO] frobbed toml for rckit-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rckit/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rckit-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rckit/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2a893632ba5bca83501daf518c9f0f27b9068adafa97923c5245a676dded9118 [INFO] running `"docker" "start" "-a" "2a893632ba5bca83501daf518c9f0f27b9068adafa97923c5245a676dded9118"` [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Checking redis v0.9.1 [INFO] [stderr] Checking rckit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conn.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conn.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `redis::Commands` [INFO] [stderr] --> src/conn.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use redis::Commands; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Role` [INFO] [stderr] --> src/create.rs:1:37 [INFO] [stderr] | [INFO] [stderr] 1 | use cluster::{Cluster, Error, Node, Role}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/cluster.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | for node in nodes { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `migrate` [INFO] [stderr] --> src/cluster.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | let migrate = &slots[start..start + count]; [INFO] [stderr] | ^^^^^^^ help: consider using `_migrate` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `redis::Commands` [INFO] [stderr] --> src/conn.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use redis::Commands; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Role` [INFO] [stderr] --> src/create.rs:1:37 [INFO] [stderr] | [INFO] [stderr] 1 | use cluster::{Cluster, Error, Node, Role}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `None` [INFO] [stderr] --> src/cluster.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | None, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/add.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | let items: Vec<&str> = addr.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/add.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | let mut ms: Vec<&str> = n.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/add.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | let master = self.slave_master.get(&node.addr()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.slave_master[&node.addr()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/add.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | let _: () = node.set_slave(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: variant `master` should have a camel case name such as `Master` [INFO] [stderr] --> src/cluster.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | master, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `slave` should have a camel case name such as `Slave` [INFO] [stderr] --> src/cluster.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | slave, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:68:41 [INFO] [stderr] | [INFO] [stderr] 68 | node_slot.get(&slot).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node_slot[&slot]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cluster.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | slot_num = slot_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `slot_num += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cluster.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | start = start + count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start += count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/cluster.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | if &n.addr() == node { [INFO] [stderr] | ---------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `n.addr()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / let _: () = redis::cmd("cluster") [INFO] [stderr] 32 | | .arg("addslots") [INFO] [stderr] 33 | | .arg(slots) [INFO] [stderr] 34 | | .query(&con) [INFO] [stderr] 35 | | .expect("add slots err"); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 40 | | .arg("SET-CONFIG-EPOCH") [INFO] [stderr] 41 | | .arg(epoch) [INFO] [stderr] 42 | | .query(&con) [INFO] [stderr] 43 | | .expect("set config epoch err"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 48 | | .arg("MEET") [INFO] [stderr] 49 | | .arg(ip) [INFO] [stderr] 50 | | .arg(port) [INFO] [stderr] 51 | | .query(&con) [INFO] [stderr] 52 | | .unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 58 | | .arg("REPLICATE") [INFO] [stderr] 59 | | .arg(&*node_id) [INFO] [stderr] 60 | | .query(&con) [INFO] [stderr] 61 | | .expect("cluster replicate err"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/conn.rs:69:46 [INFO] [stderr] | [INFO] [stderr] 69 | let kv: Vec = info.split(":").map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/conn.rs:82:46 [INFO] [stderr] | [INFO] [stderr] 82 | let kv: Vec = info.split(" ").map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/conn.rs:92:58 [INFO] [stderr] | [INFO] [stderr] 92 | let mut scope: Vec<&str> = content.split("-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/conn.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | for i in (start + 1..end + 1).into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(start + 1..end + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/conn.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | for i in (start + 1..end + 1).into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(start + 1..=end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 114 | | .arg("FORGET") [INFO] [stderr] 115 | | .arg(node) [INFO] [stderr] 116 | | .query(&con) [INFO] [stderr] 117 | | .unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/create.rs:100:32 [INFO] [stderr] | [INFO] [stderr] 100 | ips.entry(key).or_insert(vec![]).push(n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/create.rs:112:29 [INFO] [stderr] | [INFO] [stderr] 112 | node.add_slots(&(chunk.0..chunk.1).into_iter().collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(chunk.0..chunk.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/create.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let _: () = node.set_slave(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/create.rs:148:35 [INFO] [stderr] | [INFO] [stderr] 148 | let mut key = String::from(slave.ip.clone() + ":" + &slave.port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `slave.ip.clone() + ":" + &slave.port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/create.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | total = total + num; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the HashMap [INFO] [stderr] --> src/create.rs:194:29 [INFO] [stderr] | [INFO] [stderr] 194 | for (_, v) in nodes.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/create.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | len = len + v.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `len += v.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the HashMap [INFO] [stderr] --> src/create.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | for (_, v) in nodes.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let _: () = add.add_node().expect("add node fail"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/cluster.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | for node in nodes { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `migrate` [INFO] [stderr] --> src/cluster.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | let migrate = &slots[start..start + count]; [INFO] [stderr] | ^^^^^^^ help: consider using `_migrate` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `None` [INFO] [stderr] --> src/cluster.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | None, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/add.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | let items: Vec<&str> = addr.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/add.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | let mut ms: Vec<&str> = n.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/add.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | let master = self.slave_master.get(&node.addr()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.slave_master[&node.addr()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/add.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | let _: () = node.set_slave(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: variant `master` should have a camel case name such as `Master` [INFO] [stderr] --> src/cluster.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | master, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `slave` should have a camel case name such as `Slave` [INFO] [stderr] --> src/cluster.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | slave, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:68:41 [INFO] [stderr] | [INFO] [stderr] 68 | node_slot.get(&slot).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node_slot[&slot]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cluster.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | slot_num = slot_num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `slot_num += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cluster.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | start = start + count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start += count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/cluster.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | if &n.addr() == node { [INFO] [stderr] | ---------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `n.addr()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / let _: () = redis::cmd("cluster") [INFO] [stderr] 32 | | .arg("addslots") [INFO] [stderr] 33 | | .arg(slots) [INFO] [stderr] 34 | | .query(&con) [INFO] [stderr] 35 | | .expect("add slots err"); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 40 | | .arg("SET-CONFIG-EPOCH") [INFO] [stderr] 41 | | .arg(epoch) [INFO] [stderr] 42 | | .query(&con) [INFO] [stderr] 43 | | .expect("set config epoch err"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 48 | | .arg("MEET") [INFO] [stderr] 49 | | .arg(ip) [INFO] [stderr] 50 | | .arg(port) [INFO] [stderr] 51 | | .query(&con) [INFO] [stderr] 52 | | .unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 58 | | .arg("REPLICATE") [INFO] [stderr] 59 | | .arg(&*node_id) [INFO] [stderr] 60 | | .query(&con) [INFO] [stderr] 61 | | .expect("cluster replicate err"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/conn.rs:69:46 [INFO] [stderr] | [INFO] [stderr] 69 | let kv: Vec = info.split(":").map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/conn.rs:82:46 [INFO] [stderr] | [INFO] [stderr] 82 | let kv: Vec = info.split(" ").map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/conn.rs:92:58 [INFO] [stderr] | [INFO] [stderr] 92 | let mut scope: Vec<&str> = content.split("-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/conn.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | for i in (start + 1..end + 1).into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(start + 1..end + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/conn.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | for i in (start + 1..end + 1).into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(start + 1..=end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/conn.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / let _: () = redis::cmd("CLUSTER") [INFO] [stderr] 114 | | .arg("FORGET") [INFO] [stderr] 115 | | .arg(node) [INFO] [stderr] 116 | | .query(&con) [INFO] [stderr] 117 | | .unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/create.rs:100:32 [INFO] [stderr] | [INFO] [stderr] 100 | ips.entry(key).or_insert(vec![]).push(n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/create.rs:112:29 [INFO] [stderr] | [INFO] [stderr] 112 | node.add_slots(&(chunk.0..chunk.1).into_iter().collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(chunk.0..chunk.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/create.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let _: () = node.set_slave(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/create.rs:148:35 [INFO] [stderr] | [INFO] [stderr] 148 | let mut key = String::from(slave.ip.clone() + ":" + &slave.port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `slave.ip.clone() + ":" + &slave.port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/create.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | total = total + num; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the HashMap [INFO] [stderr] --> src/create.rs:194:29 [INFO] [stderr] | [INFO] [stderr] 194 | for (_, v) in nodes.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/create.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | len = len + v.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `len += v.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the HashMap [INFO] [stderr] --> src/create.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | for (_, v) in nodes.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let _: () = add.add_node().expect("add node fail"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.17s [INFO] running `"docker" "inspect" "2a893632ba5bca83501daf518c9f0f27b9068adafa97923c5245a676dded9118"` [INFO] running `"docker" "rm" "-f" "2a893632ba5bca83501daf518c9f0f27b9068adafa97923c5245a676dded9118"` [INFO] [stdout] 2a893632ba5bca83501daf518c9f0f27b9068adafa97923c5245a676dded9118