[INFO] crate rcalc 0.1.2 is already in cache [INFO] extracting crate rcalc 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/rcalc/0.1.2 [INFO] extracting crate rcalc 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcalc/0.1.2 [INFO] validating manifest of rcalc-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rcalc-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rcalc-0.1.2 [INFO] finished frobbing rcalc-0.1.2 [INFO] frobbed toml for rcalc-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/rcalc/0.1.2/Cargo.toml [INFO] started frobbing rcalc-0.1.2 [INFO] finished frobbing rcalc-0.1.2 [INFO] frobbed toml for rcalc-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcalc/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rcalc-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rcalc/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 612b7805130bfeb6ed83688e0ce99db4d8db7a54ae7db93b01aaaccfc36442d3 [INFO] running `"docker" "start" "-a" "612b7805130bfeb6ed83688e0ce99db4d8db7a54ae7db93b01aaaccfc36442d3"` [INFO] [stderr] warning: `panic` setting is ignored for `test` profile [INFO] [stderr] warning: profile `doc` is deprecated and has no effect [INFO] [stderr] warning: `panic` setting is ignored for `bench` profile [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking rcalc v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/ast.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/ast.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/parser/parser.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/ast.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/ast.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/parser/parser.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/ast.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/ast.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcalc/parser/parser.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/rcalc/interpreter/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod interpreter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/interpreter/interpreter.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return match self.visit(&tree) { [INFO] [stderr] 25 | | Ok(n) => Ok(n), [INFO] [stderr] 26 | | Err(e) => Err(e), [INFO] [stderr] 27 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | match self.visit(&tree) { [INFO] [stderr] 25 | Ok(n) => Ok(n), [INFO] [stderr] 26 | Err(e) => Err(e), [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/rcalc/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | Token::NUMBER(_) => return Ok(ASTNode::from(token, vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | Ok(_) => return node, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | / return Err(ProgramError::of( [INFO] [stderr] 83 | | "UnknownToken", [INFO] [stderr] 84 | | "High-level Token cannot be parsed.", [INFO] [stderr] 85 | | )) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | Err(ProgramError::of( [INFO] [stderr] 83 | "UnknownToken", [INFO] [stderr] 84 | "High-level Token cannot be parsed.", [INFO] [stderr] 85 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/rcalc/interpreter/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod interpreter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/interpreter/interpreter.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return match self.visit(&tree) { [INFO] [stderr] 25 | | Ok(n) => Ok(n), [INFO] [stderr] 26 | | Err(e) => Err(e), [INFO] [stderr] 27 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | match self.visit(&tree) { [INFO] [stderr] 25 | Ok(n) => Ok(n), [INFO] [stderr] 26 | Err(e) => Err(e), [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/rcalc/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | Token::NUMBER(_) => return Ok(ASTNode::from(token, vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | Ok(_) => return node, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | / return Err(ProgramError::of( [INFO] [stderr] 83 | | "UnknownToken", [INFO] [stderr] 84 | | "High-level Token cannot be parsed.", [INFO] [stderr] 85 | | )) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | Err(ProgramError::of( [INFO] [stderr] 83 | "UnknownToken", [INFO] [stderr] 84 | "High-level Token cannot be parsed.", [INFO] [stderr] 85 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match node.token() { [INFO] [stderr] 15 | | &Token::NUMBER(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 16 | | &Token::MULTIPLY | [INFO] [stderr] 17 | | &Token::DIVIDE | [INFO] [stderr] ... | [INFO] [stderr] 32 | | )), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *node.token() { [INFO] [stderr] 15 | Token::NUMBER(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 16 | Token::MULTIPLY | [INFO] [stderr] 17 | Token::DIVIDE | [INFO] [stderr] 18 | Token::DIVIDEINT | [INFO] [stderr] 19 | Token::MODULO | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | if &node.children().len() == &2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 23 | if node.children().len() == 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match node.token() { [INFO] [stderr] 40 | | &Token::NUMBER(i) => Ok(i as f64), [INFO] [stderr] 41 | | _ => Err(ProgramError::of( [INFO] [stderr] 42 | | "NotANumber", [INFO] [stderr] 43 | | "Expected Token of type Number; got unexpected result.", [INFO] [stderr] 44 | | )), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *node.token() { [INFO] [stderr] 40 | Token::NUMBER(i) => Ok(i as f64), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match node.token() { [INFO] [stderr] 53 | | &Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 54 | | &Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 55 | | &Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] ... | [INFO] [stderr] 63 | | )), [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *node.token() { [INFO] [stderr] 53 | Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 54 | Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 55 | Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] 56 | Token::DIVIDE => Ok(left as f64 / right as f64), [INFO] [stderr] 57 | Token::DIVIDEINT => Ok((left as isize / right as isize) as f64), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match node.token() { [INFO] [stderr] 71 | | &Token::PLUS => Ok(expr as f64), [INFO] [stderr] 72 | | &Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 73 | | &Token::FACTORIAL => { [INFO] [stderr] ... | [INFO] [stderr] 91 | | )), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *node.token() { [INFO] [stderr] 71 | Token::PLUS => Ok(expr as f64), [INFO] [stderr] 72 | Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 73 | Token::FACTORIAL => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rcalc/lexer.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | fn peek_ahead(&self, amt: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match node.token() { [INFO] [stderr] 15 | | &Token::NUMBER(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 16 | | &Token::MULTIPLY | [INFO] [stderr] 17 | | &Token::DIVIDE | [INFO] [stderr] ... | [INFO] [stderr] 32 | | )), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *node.token() { [INFO] [stderr] 15 | Token::NUMBER(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 16 | Token::MULTIPLY | [INFO] [stderr] 17 | Token::DIVIDE | [INFO] [stderr] 18 | Token::DIVIDEINT | [INFO] [stderr] 19 | Token::MODULO | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | if &node.children().len() == &2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 23 | if node.children().len() == 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match node.token() { [INFO] [stderr] 40 | | &Token::NUMBER(i) => Ok(i as f64), [INFO] [stderr] 41 | | _ => Err(ProgramError::of( [INFO] [stderr] 42 | | "NotANumber", [INFO] [stderr] 43 | | "Expected Token of type Number; got unexpected result.", [INFO] [stderr] 44 | | )), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/rcalc/interpreter/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod interpreter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/interpreter/interpreter.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return match self.visit(&tree) { [INFO] [stderr] 25 | | Ok(n) => Ok(n), [INFO] [stderr] 26 | | Err(e) => Err(e), [INFO] [stderr] 27 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | match self.visit(&tree) { [INFO] [stderr] 25 | Ok(n) => Ok(n), [INFO] [stderr] 26 | Err(e) => Err(e), [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/rcalc/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | Token::NUMBER(_) => return Ok(ASTNode::from(token, vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![]))` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *node.token() { [INFO] [stderr] 40 | Token::NUMBER(i) => Ok(i as f64), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match node.token() { [INFO] [stderr] 53 | | &Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 54 | | &Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 55 | | &Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] ... | [INFO] [stderr] 63 | | )), [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *node.token() { [INFO] [stderr] 53 | Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 54 | Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 55 | Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] 56 | Token::DIVIDE => Ok(left as f64 / right as f64), [INFO] [stderr] 57 | Token::DIVIDEINT => Ok((left as isize / right as isize) as f64), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match node.token() { [INFO] [stderr] 71 | | &Token::PLUS => Ok(expr as f64), [INFO] [stderr] 72 | | &Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 73 | | &Token::FACTORIAL => { [INFO] [stderr] ... | [INFO] [stderr] 91 | | )), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *node.token() { [INFO] [stderr] 71 | Token::PLUS => Ok(expr as f64), [INFO] [stderr] 72 | Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 73 | Token::FACTORIAL => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | Ok(_) => return node, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rcalc/parser/builder.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | / return Err(ProgramError::of( [INFO] [stderr] 83 | | "UnknownToken", [INFO] [stderr] 84 | | "High-level Token cannot be parsed.", [INFO] [stderr] 85 | | )) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | Err(ProgramError::of( [INFO] [stderr] 83 | "UnknownToken", [INFO] [stderr] 84 | "High-level Token cannot be parsed.", [INFO] [stderr] 85 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rcalc/lexer.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | fn peek_ahead(&self, amt: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match node.token() { [INFO] [stderr] 15 | | &Token::NUMBER(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 16 | | &Token::MULTIPLY | [INFO] [stderr] 17 | | &Token::DIVIDE | [INFO] [stderr] ... | [INFO] [stderr] 32 | | )), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *node.token() { [INFO] [stderr] 15 | Token::NUMBER(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 16 | Token::MULTIPLY | [INFO] [stderr] 17 | Token::DIVIDE | [INFO] [stderr] 18 | Token::DIVIDEINT | [INFO] [stderr] 19 | Token::MODULO | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | if &node.children().len() == &2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 23 | if node.children().len() == 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match node.token() { [INFO] [stderr] 40 | | &Token::NUMBER(i) => Ok(i as f64), [INFO] [stderr] 41 | | _ => Err(ProgramError::of( [INFO] [stderr] 42 | | "NotANumber", [INFO] [stderr] 43 | | "Expected Token of type Number; got unexpected result.", [INFO] [stderr] 44 | | )), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *node.token() { [INFO] [stderr] 40 | Token::NUMBER(i) => Ok(i as f64), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match node.token() { [INFO] [stderr] 53 | | &Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 54 | | &Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 55 | | &Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] ... | [INFO] [stderr] 63 | | )), [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *node.token() { [INFO] [stderr] 53 | Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 54 | Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 55 | Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] 56 | Token::DIVIDE => Ok(left as f64 / right as f64), [INFO] [stderr] 57 | Token::DIVIDEINT => Ok((left as isize / right as isize) as f64), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match node.token() { [INFO] [stderr] 71 | | &Token::PLUS => Ok(expr as f64), [INFO] [stderr] 72 | | &Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 73 | | &Token::FACTORIAL => { [INFO] [stderr] ... | [INFO] [stderr] 91 | | )), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *node.token() { [INFO] [stderr] 71 | Token::PLUS => Ok(expr as f64), [INFO] [stderr] 72 | Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 73 | Token::FACTORIAL => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rcalc/interpreter/visitor.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rcalc/lexer.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | fn peek_ahead(&self, amt: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/precedence.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(Interpreter::process("7 + 3 * 2 - 4 / 2").unwrap(), 11.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/precedence.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(Interpreter::process("7 + 3 * 2 - 4 / 2").unwrap(), 11.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/precedence.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(Interpreter::process("6 ^ 2 / 6").unwrap(), 6.) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/precedence.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(Interpreter::process("6 ^ 2 / 6").unwrap(), 6.) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/precedence.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(Interpreter::process("6 ^ 9 / 3! ^ 3").unwrap(), 46656.) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/precedence.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(Interpreter::process("6 ^ 9 / 3! ^ 3").unwrap(), 46656.) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/precedence.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / assert_eq!( [INFO] [stderr] 25 | | Interpreter::process("7 + 3 * (10 / (12 / (3 + 1) - 1)) / (2 + 3) - 5 - 3 + (8)") [INFO] [stderr] 26 | | .unwrap(), [INFO] [stderr] 27 | | 10. [INFO] [stderr] 28 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/precedence.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / assert_eq!( [INFO] [stderr] 25 | | Interpreter::process("7 + 3 * (10 / (12 / (3 + 1) - 1)) / (2 + 3) - 5 - 3 + (8)") [INFO] [stderr] 26 | | .unwrap(), [INFO] [stderr] 27 | | 10. [INFO] [stderr] 28 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rcalc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(Interpreter::process("3+4").unwrap(), 7.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(Interpreter::process("3+4").unwrap(), 7.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(Interpreter::process("3-4").unwrap(), -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(Interpreter::process("3-4").unwrap(), -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] --> tests/gen.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(Interpreter::process("3 - 4").unwrap(), -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/gen.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(Interpreter::process("3 - 4").unwrap(), -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(Interpreter::process("3*4").unwrap(), 12.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(Interpreter::process("3*4").unwrap(), 12.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/gen.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(Interpreter::process("22 * 55").unwrap(), 1210.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/gen.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(Interpreter::process("22 * 55").unwrap(), 1210.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(Interpreter::process("3/4").unwrap(), 0.75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(Interpreter::process("3/4").unwrap(), 0.75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/gen.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(Interpreter::process("3 + 4 - 5 + 7").unwrap(), 9.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/gen.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(Interpreter::process("3 + 4 - 5 + 7").unwrap(), 9.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(Interpreter::process("3./4").unwrap(), 0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(Interpreter::process("3./4").unwrap(), 0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!(Interpreter::process("10%3").unwrap(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!(Interpreter::process("10%3").unwrap(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | assert_eq!(Interpreter::process("5!").unwrap(), 120.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | assert_eq!(Interpreter::process("5!").unwrap(), 120.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: Could not compile `rcalc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(Interpreter::process("-2!").unwrap(), f64::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(Interpreter::process("-2!").unwrap(), f64::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(Interpreter::process("-3!").unwrap(), -f64::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(Interpreter::process("-3!").unwrap(), -f64::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/operators.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(Interpreter::process("-5 - + - 7").unwrap(), 2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/operators.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(Interpreter::process("-5 - + - 7").unwrap(), 2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rcalc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | if line.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | if line.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "612b7805130bfeb6ed83688e0ce99db4d8db7a54ae7db93b01aaaccfc36442d3"` [INFO] running `"docker" "rm" "-f" "612b7805130bfeb6ed83688e0ce99db4d8db7a54ae7db93b01aaaccfc36442d3"` [INFO] [stdout] 612b7805130bfeb6ed83688e0ce99db4d8db7a54ae7db93b01aaaccfc36442d3