[INFO] crate rbtables 0.1.4 is already in cache
[INFO] extracting crate rbtables 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/rbtables/0.1.4
[INFO] extracting crate rbtables 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rbtables/0.1.4
[INFO] validating manifest of rbtables-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rbtables-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rbtables-0.1.4
[INFO] finished frobbing rbtables-0.1.4
[INFO] frobbed toml for rbtables-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/rbtables/0.1.4/Cargo.toml
[INFO] started frobbing rbtables-0.1.4
[INFO] finished frobbing rbtables-0.1.4
[INFO] frobbed toml for rbtables-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rbtables/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rbtables-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rbtables/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c624dad0eac938544f7d70b19149ac51c4209d72078f7f21d263943b7e0fa848
[INFO] running `"docker" "start" "-a" "c624dad0eac938544f7d70b19149ac51c4209d72078f7f21d263943b7e0fa848"`
[INFO] [stderr]     Checking rbtables v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/prelude.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             hasher: hasher,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `hasher`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/prelude.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             reducers: reducers
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `reducers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/prelude.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             hasher: hasher,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `hasher`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/prelude.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             reducers: reducers
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `reducers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prelude.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.chains.clone(); 
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chains.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/prelude.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn from_chains(&mut self, old_chains : &HashMap<String, String>) -> &mut RainbowTable<H, R> {
[INFO] [stderr]    |                        ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/prelude.rs:71:58
[INFO] [stderr]    |
[INFO] [stderr] 71 |                 let mut target_plaintext = String::from(&self.chains.get(&reduced_plaintext).unwrap()[..]);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.chains[&reduced_plaintext]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/prelude.rs:104:41
[INFO] [stderr]     |
[INFO] [stderr] 104 |             let halt_counter = Arc::new(Mutex::new(false));
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/prelude.rs:134:70
[INFO] [stderr]     |
[INFO] [stderr] 134 |                             let mut target_plaintext = String::from(&self.chains.get(&reduced_plaintext).unwrap()[..]);
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.chains[&reduced_plaintext]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/prelude.rs:169:17
[INFO] [stderr]     |
[INFO] [stderr] 169 | /                 match rx.recv() {
[INFO] [stderr] 170 | |                     Ok(thread_result) => {
[INFO] [stderr] 171 | |                         // One thread was successful
[INFO] [stderr] 172 | |                         if thread_result.is_some() {
[INFO] [stderr] ...   |
[INFO] [stderr] 181 | |                     _ => ()
[INFO] [stderr] 182 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 if let Ok(thread_result) = rx.recv() {
[INFO] [stderr] 170 |     // One thread was successful
[INFO] [stderr] 171 |     if thread_result.is_some() {
[INFO] [stderr] 172 |         // Set global result 
[INFO] [stderr] 173 |         result = thread_result; 
[INFO] [stderr] 174 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prelude.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.chains.clone(); 
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chains.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/prelude.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn from_chains(&mut self, old_chains : &HashMap<String, String>) -> &mut RainbowTable<H, R> {
[INFO] [stderr]    |                        ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/prelude.rs:71:58
[INFO] [stderr]    |
[INFO] [stderr] 71 |                 let mut target_plaintext = String::from(&self.chains.get(&reduced_plaintext).unwrap()[..]);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.chains[&reduced_plaintext]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/prelude.rs:104:41
[INFO] [stderr]     |
[INFO] [stderr] 104 |             let halt_counter = Arc::new(Mutex::new(false));
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/prelude.rs:134:70
[INFO] [stderr]     |
[INFO] [stderr] 134 |                             let mut target_plaintext = String::from(&self.chains.get(&reduced_plaintext).unwrap()[..]);
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.chains[&reduced_plaintext]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/prelude.rs:169:17
[INFO] [stderr]     |
[INFO] [stderr] 169 | /                 match rx.recv() {
[INFO] [stderr] 170 | |                     Ok(thread_result) => {
[INFO] [stderr] 171 | |                         // One thread was successful
[INFO] [stderr] 172 | |                         if thread_result.is_some() {
[INFO] [stderr] ...   |
[INFO] [stderr] 181 | |                     _ => ()
[INFO] [stderr] 182 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 if let Ok(thread_result) = rx.recv() {
[INFO] [stderr] 170 |     // One thread was successful
[INFO] [stderr] 171 |     if thread_result.is_some() {
[INFO] [stderr] 172 |         // Set global result 
[INFO] [stderr] 173 |         result = thread_result; 
[INFO] [stderr] 174 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `rfs`.
[INFO] [stderr]   --> src/lib.rs:81:22
[INFO] [stderr]    |
[INFO] [stderr] 81 |             for i in 0..reductions {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 81 |             for <item> in rfs.iter().take(reductions) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.06s
[INFO] running `"docker" "inspect" "c624dad0eac938544f7d70b19149ac51c4209d72078f7f21d263943b7e0fa848"`
[INFO] running `"docker" "rm" "-f" "c624dad0eac938544f7d70b19149ac51c4209d72078f7f21d263943b7e0fa848"`
[INFO] [stdout] c624dad0eac938544f7d70b19149ac51c4209d72078f7f21d263943b7e0fa848