[INFO] crate raze 0.1.11 is already in cache [INFO] extracting crate raze 0.1.11 into work/ex/clippy-test-run/sources/stable/reg/raze/0.1.11 [INFO] extracting crate raze 0.1.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/raze/0.1.11 [INFO] validating manifest of raze-0.1.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of raze-0.1.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing raze-0.1.11 [INFO] finished frobbing raze-0.1.11 [INFO] frobbed toml for raze-0.1.11 written to work/ex/clippy-test-run/sources/stable/reg/raze/0.1.11/Cargo.toml [INFO] started frobbing raze-0.1.11 [INFO] finished frobbing raze-0.1.11 [INFO] frobbed toml for raze-0.1.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/raze/0.1.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting raze-0.1.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/raze/0.1.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fd34037e3d77bc2a8b429d466944c8f7807eba4dc876b403a31f625a8947f90 [INFO] running `"docker" "start" "-a" "3fd34037e3d77bc2a8b429d466944c8f7807eba4dc876b403a31f625a8947f90"` [INFO] [stderr] Checking raze v0.1.11 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/buckets.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | bucket_type: bucket_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bucket_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/buckets.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | bucket_type: bucket_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bucket_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/engine/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub mod engine; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/engine/engine.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | .timeout(std::time::Duration::new(100000000,0)) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine/engine.rs:156:23 [INFO] [stderr] | [INFO] [stderr] 156 | Err(e) => return Some(e), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine/engine.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | Err(e) => return Some(e), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine/engine.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | Err(e) => return Err(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/files/upload.rs:274:47 [INFO] [stderr] | [INFO] [stderr] 274 | .timeout(std::time::Duration::new(100000000,0)) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/files/upload.rs:285:115 [INFO] [stderr] | [INFO] [stderr] 285 | let time_elapsed = dur.elapsed().unwrap().as_secs() as f64 + dur.elapsed().unwrap().subsec_nanos() as f64/1000000000.; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1_000_000_000.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/engine/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub mod engine; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/engine/engine.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | .timeout(std::time::Duration::new(100000000,0)) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine/engine.rs:156:23 [INFO] [stderr] | [INFO] [stderr] 156 | Err(e) => return Some(e), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine/engine.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | Err(e) => return Some(e), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine/engine.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | Err(e) => return Err(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api/auth.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / match read.read_to_string(&mut contents) { [INFO] [stderr] 59 | | Err(e) => return Err(B2Error::IOError(e)), [INFO] [stderr] 60 | | _ => () [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = read.read_to_string(&mut contents) { return Err(B2Error::IOError(e)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/api/files/structs.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / let len; [INFO] [stderr] 167 | | if buf.len() >= 2048 { [INFO] [stderr] 168 | | len = self.file.read(&mut buf[0..2048])?; [INFO] [stderr] 169 | | }else { [INFO] [stderr] 170 | | len = self.file.read(buf)?; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let len = if buf.len() >= 2048 { self.file.read(&mut buf[0..2048])? } else { self.file.read(buf)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `engine::engine::Raze` [INFO] [stderr] --> src/engine/engine.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Raze { [INFO] [stderr] 24 | | let c = reqwest::Client::builder() [INFO] [stderr] 25 | | // The timeout is set arbitrarily high to prevent slow uploads from timing out [INFO] [stderr] 26 | | // The BackBlaze backend can still timeout requests for other reasons [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for engine::engine::Raze { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 81 | | &Some(ref a) => a, [INFO] [stderr] 82 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | let auth = match self.b2auth { [INFO] [stderr] 81 | Some(ref a) => a, [INFO] [stderr] 82 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | let bucket = match &self.active_bucket { [INFO] [stderr] | ______________________^ [INFO] [stderr] 85 | | &Some(ref a) => a, [INFO] [stderr] 86 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | let bucket = match self.active_bucket { [INFO] [stderr] 85 | Some(ref a) => a, [INFO] [stderr] 86 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | &Some(ref a) => a, [INFO] [stderr] 149 | | &None => return Some(B2Error::B2EngineError), [INFO] [stderr] 150 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 147 | let auth = match self.b2auth { [INFO] [stderr] 148 | Some(ref a) => a, [INFO] [stderr] 149 | None => return Some(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | let bucket = match &self.active_bucket { [INFO] [stderr] | ______________________^ [INFO] [stderr] 152 | | &Some(ref a) => a, [INFO] [stderr] 153 | | &None => return Some(B2Error::B2EngineError), [INFO] [stderr] 154 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | let bucket = match self.active_bucket { [INFO] [stderr] 152 | Some(ref a) => a, [INFO] [stderr] 153 | None => return Some(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:165:20 [INFO] [stderr] | [INFO] [stderr] 165 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 166 | | &Some(ref a) => a, [INFO] [stderr] 167 | | &None => return Some(B2Error::B2EngineError), [INFO] [stderr] 168 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 165 | let auth = match self.b2auth { [INFO] [stderr] 166 | Some(ref a) => a, [INFO] [stderr] 167 | None => return Some(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 180 | | &Some(ref a) => a, [INFO] [stderr] 181 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 182 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | let auth = match self.b2auth { [INFO] [stderr] 180 | Some(ref a) => a, [INFO] [stderr] 181 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:194:20 [INFO] [stderr] | [INFO] [stderr] 194 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 195 | | &Some(ref a) => a, [INFO] [stderr] 196 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 197 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | let auth = match self.b2auth { [INFO] [stderr] 195 | Some(ref a) => a, [INFO] [stderr] 196 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match resp.read_to_string(&mut res) { [INFO] [stderr] 62 | | Err(e) => return B2Error::IOError(e), [INFO] [stderr] 63 | | _ => () [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = resp.read_to_string(&mut res) { return B2Error::IOError(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api/auth.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / match read.read_to_string(&mut contents) { [INFO] [stderr] 59 | | Err(e) => return Err(B2Error::IOError(e)), [INFO] [stderr] 60 | | _ => () [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = read.read_to_string(&mut contents) { return Err(B2Error::IOError(e)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/api/files/upload.rs:285:70 [INFO] [stderr] | [INFO] [stderr] 285 | let time_elapsed = dur.elapsed().unwrap().as_secs() as f64 + dur.elapsed().unwrap().subsec_nanos() as f64/1000000000.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.elapsed().unwrap().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/api/files/structs.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / let len; [INFO] [stderr] 167 | | if buf.len() >= 2048 { [INFO] [stderr] 168 | | len = self.file.read(&mut buf[0..2048])?; [INFO] [stderr] 169 | | }else { [INFO] [stderr] 170 | | len = self.file.read(buf)?; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let len = if buf.len() >= 2048 { self.file.read(&mut buf[0..2048])? } else { self.file.read(buf)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `engine::engine::Raze` [INFO] [stderr] --> src/engine/engine.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Raze { [INFO] [stderr] 24 | | let c = reqwest::Client::builder() [INFO] [stderr] 25 | | // The timeout is set arbitrarily high to prevent slow uploads from timing out [INFO] [stderr] 26 | | // The BackBlaze backend can still timeout requests for other reasons [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for engine::engine::Raze { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 81 | | &Some(ref a) => a, [INFO] [stderr] 82 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | let auth = match self.b2auth { [INFO] [stderr] 81 | Some(ref a) => a, [INFO] [stderr] 82 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | let bucket = match &self.active_bucket { [INFO] [stderr] | ______________________^ [INFO] [stderr] 85 | | &Some(ref a) => a, [INFO] [stderr] 86 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | let bucket = match self.active_bucket { [INFO] [stderr] 85 | Some(ref a) => a, [INFO] [stderr] 86 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | &Some(ref a) => a, [INFO] [stderr] 149 | | &None => return Some(B2Error::B2EngineError), [INFO] [stderr] 150 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 147 | let auth = match self.b2auth { [INFO] [stderr] 148 | Some(ref a) => a, [INFO] [stderr] 149 | None => return Some(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | let bucket = match &self.active_bucket { [INFO] [stderr] | ______________________^ [INFO] [stderr] 152 | | &Some(ref a) => a, [INFO] [stderr] 153 | | &None => return Some(B2Error::B2EngineError), [INFO] [stderr] 154 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | let bucket = match self.active_bucket { [INFO] [stderr] 152 | Some(ref a) => a, [INFO] [stderr] 153 | None => return Some(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:165:20 [INFO] [stderr] | [INFO] [stderr] 165 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 166 | | &Some(ref a) => a, [INFO] [stderr] 167 | | &None => return Some(B2Error::B2EngineError), [INFO] [stderr] 168 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 165 | let auth = match self.b2auth { [INFO] [stderr] 166 | Some(ref a) => a, [INFO] [stderr] 167 | None => return Some(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 180 | | &Some(ref a) => a, [INFO] [stderr] 181 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 182 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | let auth = match self.b2auth { [INFO] [stderr] 180 | Some(ref a) => a, [INFO] [stderr] 181 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine/engine.rs:194:20 [INFO] [stderr] | [INFO] [stderr] 194 | let auth = match &self.b2auth { [INFO] [stderr] | ____________________^ [INFO] [stderr] 195 | | &Some(ref a) => a, [INFO] [stderr] 196 | | &None => return Err(B2Error::B2EngineError), [INFO] [stderr] 197 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | let auth = match self.b2auth { [INFO] [stderr] 195 | Some(ref a) => a, [INFO] [stderr] 196 | None => return Err(B2Error::B2EngineError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match resp.read_to_string(&mut res) { [INFO] [stderr] 62 | | Err(e) => return B2Error::IOError(e), [INFO] [stderr] 63 | | _ => () [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = resp.read_to_string(&mut res) { return B2Error::IOError(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.02s [INFO] running `"docker" "inspect" "3fd34037e3d77bc2a8b429d466944c8f7807eba4dc876b403a31f625a8947f90"` [INFO] running `"docker" "rm" "-f" "3fd34037e3d77bc2a8b429d466944c8f7807eba4dc876b403a31f625a8947f90"` [INFO] [stdout] 3fd34037e3d77bc2a8b429d466944c8f7807eba4dc876b403a31f625a8947f90