[INFO] crate razberry 0.3.0 is already in cache [INFO] extracting crate razberry 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/razberry/0.3.0 [INFO] extracting crate razberry 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/razberry/0.3.0 [INFO] validating manifest of razberry-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of razberry-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing razberry-0.3.0 [INFO] finished frobbing razberry-0.3.0 [INFO] frobbed toml for razberry-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/razberry/0.3.0/Cargo.toml [INFO] started frobbing razberry-0.3.0 [INFO] finished frobbing razberry-0.3.0 [INFO] frobbed toml for razberry-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/razberry/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting razberry-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/razberry/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79e4c29d454a19352ae349adf91a40a70c3fd30f0d846496581157f71963cd58 [INFO] running `"docker" "start" "-a" "79e4c29d454a19352ae349adf91a40a70c3fd30f0d846496581157f71963cd58"` [INFO] [stderr] Checking url v1.4.1 [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Checking razberry v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | last_contacted: last_contacted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_contacted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | command_classes: command_classes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_classes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device_update.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_class/sensor_binary.rs:43:7 [INFO] [stderr] | [INFO] [stderr] 43 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:223:7 [INFO] [stderr] | [INFO] [stderr] 223 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | DataResponse { json: json } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | last_contacted: last_contacted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_contacted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | command_classes: command_classes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_classes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device_update.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_class/sensor_binary.rs:43:7 [INFO] [stderr] | [INFO] [stderr] 43 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:223:7 [INFO] [stderr] | [INFO] [stderr] 223 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | DataResponse { json: json } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | const SESSION_COOKIE_NAME : &'static str = "ZWAYSession"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client.rs:424:26 [INFO] [stderr] | [INFO] [stderr] 424 | self.fetch_data(Some(20000000000)) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `20_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return Some(object); // Our search is done, pop off the stack. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(object)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:247:3 [INFO] [stderr] | [INFO] [stderr] 247 | return Json::from_str(raw_string).map_err(|_| ResponseError::ParseError) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Json::from_str(raw_string).map_err(|_| ResponseError::ParseError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::RazberryClient::fetch_data' [INFO] [stderr] --> src/client.rs:402:10 [INFO] [stderr] | [INFO] [stderr] 402 | self.fetch_data(None) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::RazberryClient::fetch_data' [INFO] [stderr] --> src/client.rs:414:10 [INFO] [stderr] | [INFO] [stderr] 414 | self.fetch_data(Some(timestamp)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::RazberryClient::fetch_data' [INFO] [stderr] --> src/client.rs:424:10 [INFO] [stderr] | [INFO] [stderr] 424 | self.fetch_data(Some(20000000000)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | const SESSION_COOKIE_NAME : &'static str = "ZWAYSession"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client.rs:424:26 [INFO] [stderr] | [INFO] [stderr] 424 | self.fetch_data(Some(20000000000)) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `20_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client.rs:509:34 [INFO] [stderr] | [INFO] [stderr] 509 | let expected = make_datetime(1492409124); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_492_409_124` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return Some(object); // Our search is done, pop off the stack. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(object)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:247:3 [INFO] [stderr] | [INFO] [stderr] 247 | return Json::from_str(raw_string).map_err(|_| ResponseError::ParseError) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Json::from_str(raw_string).map_err(|_| ResponseError::ParseError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response.rs:337:16 [INFO] [stderr] | [INFO] [stderr] 337 | assert_eq!(1456036584i64, response.get_timestamp().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_456_036_584i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/response.rs:362:22 [INFO] [stderr] | [INFO] [stderr] 362 | const FULL_JSON : &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response.rs:490:16 [INFO] [stderr] | [INFO] [stderr] 490 | assert_eq!(1456036584i64, response.get_timestamp().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_456_036_584i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/response.rs:494:25 [INFO] [stderr] | [INFO] [stderr] 494 | const PARTIAL_JSON : &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response.rs:589:16 [INFO] [stderr] | [INFO] [stderr] 589 | assert_eq!(1456036584i64, response.get_timestamp().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_456_036_584i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sensors.rs:213:45 [INFO] [stderr] | [INFO] [stderr] 213 | .get_event_updated(), Some(1457816333i64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_457_816_333i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/response.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | let mut subtree = match maybe_subtree { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client.rs:176:36 [INFO] [stderr] | [INFO] [stderr] 176 | let split = name_value.split("=").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/client.rs:276:11 [INFO] [stderr] | [INFO] [stderr] 276 | let _r = device.process_updates(updates)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::RazberryClient::fetch_data' [INFO] [stderr] --> src/client.rs:402:10 [INFO] [stderr] | [INFO] [stderr] 402 | self.fetch_data(None) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::RazberryClient::fetch_data' [INFO] [stderr] --> src/client.rs:414:10 [INFO] [stderr] | [INFO] [stderr] 414 | self.fetch_data(Some(timestamp)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::RazberryClient::fetch_data' [INFO] [stderr] --> src/client.rs:424:10 [INFO] [stderr] | [INFO] [stderr] 424 | self.fetch_data(Some(20000000000)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/command_classes.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn from_str(command_class_id: &str) -> Option { [INFO] [stderr] 68 | | command_class_id.parse::() [INFO] [stderr] 69 | | .ok() // Discard parse errors. [INFO] [stderr] 70 | | .and_then(|cc| Self::from_byte(cc)) [INFO] [stderr] 71 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command_classes.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | .and_then(|cc| Self::from_byte(cc)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::from_byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/device.rs:64:7 [INFO] [stderr] | [INFO] [stderr] 64 | / match cc_instance { [INFO] [stderr] 65 | | CommandClass::Unsupported => continue, // No support for this type yet. [INFO] [stderr] 66 | | _ => {}, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_______^ help: try this: `if let CommandClass::Unsupported = cc_instance { continue }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/device.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | self.process_command_class_update(&update); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/device_update.rs:41:40 [INFO] [stderr] | [INFO] [stderr] 41 | let mut split = update_key.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/device_update.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | .or_insert_with(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_class/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &mut CommandClass::SensorBinary { ref mut inner } => { [INFO] [stderr] 48 | | inner.process_update(update) [INFO] [stderr] 49 | | }, [INFO] [stderr] 50 | | _ => Ok(()), // Unsupported [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | CommandClass::SensorBinary { ref mut inner } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_class/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match self { [INFO] [stderr] 58 | | &CommandClass::SensorBinary { ref inner } => inner.fmt(f), [INFO] [stderr] 59 | | _ => write!(f, "CommandClass (no fmt::Display impl)"), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *self { [INFO] [stderr] 58 | CommandClass::SensorBinary { ref inner } => inner.fmt(f), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/response.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | let split = device_key.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:265:3 [INFO] [stderr] | [INFO] [stderr] 265 | / pub fn from_str(raw_response: &str) -> Result { [INFO] [stderr] 266 | | let json = try!(Json::from_str(raw_response)); [INFO] [stderr] 267 | | Ok(DataResponse::new(json)) [INFO] [stderr] 268 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/response.rs:325:17 [INFO] [stderr] | [INFO] [stderr] 325 | query.split(".").collect() [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/response.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | let mut subtree = match maybe_subtree { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client.rs:176:36 [INFO] [stderr] | [INFO] [stderr] 176 | let split = name_value.split("=").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/client.rs:276:11 [INFO] [stderr] | [INFO] [stderr] 276 | let _r = device.process_updates(updates)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/command_classes.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn from_str(command_class_id: &str) -> Option { [INFO] [stderr] 68 | | command_class_id.parse::() [INFO] [stderr] 69 | | .ok() // Discard parse errors. [INFO] [stderr] 70 | | .and_then(|cc| Self::from_byte(cc)) [INFO] [stderr] 71 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command_classes.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | .and_then(|cc| Self::from_byte(cc)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::from_byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/device.rs:64:7 [INFO] [stderr] | [INFO] [stderr] 64 | / match cc_instance { [INFO] [stderr] 65 | | CommandClass::Unsupported => continue, // No support for this type yet. [INFO] [stderr] 66 | | _ => {}, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_______^ help: try this: `if let CommandClass::Unsupported = cc_instance { continue }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/device.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | self.process_command_class_update(&update); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/device_update.rs:41:40 [INFO] [stderr] | [INFO] [stderr] 41 | let mut split = update_key.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/device_update.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | .or_insert_with(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/device_update.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(3, updates.get("1").unwrap().len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&updates["1"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/device_update.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | updates.get("1").unwrap().get(0).unwrap().path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&updates["1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/device_update.rs:128:19 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(2, updates.get("9").unwrap().len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&updates["9"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/device_update.rs:131:7 [INFO] [stderr] | [INFO] [stderr] 131 | updates.get("9").unwrap().get(0).unwrap().path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&updates["9"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/device_update.rs:134:7 [INFO] [stderr] | [INFO] [stderr] 134 | updates.get("9").unwrap().get(1).unwrap().path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&updates["9"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/command_class/sensor_binary.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | sensor.process_update(&update); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_class/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &mut CommandClass::SensorBinary { ref mut inner } => { [INFO] [stderr] 48 | | inner.process_update(update) [INFO] [stderr] 49 | | }, [INFO] [stderr] 50 | | _ => Ok(()), // Unsupported [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | CommandClass::SensorBinary { ref mut inner } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_class/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match self { [INFO] [stderr] 58 | | &CommandClass::SensorBinary { ref inner } => inner.fmt(f), [INFO] [stderr] 59 | | _ => write!(f, "CommandClass (no fmt::Display impl)"), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *self { [INFO] [stderr] 58 | CommandClass::SensorBinary { ref inner } => inner.fmt(f), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/response.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | let split = device_key.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:265:3 [INFO] [stderr] | [INFO] [stderr] 265 | / pub fn from_str(raw_response: &str) -> Result { [INFO] [stderr] 266 | | let json = try!(Json::from_str(raw_response)); [INFO] [stderr] 267 | | Ok(DataResponse::new(json)) [INFO] [stderr] 268 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/response.rs:325:17 [INFO] [stderr] | [INFO] [stderr] 325 | query.split(".").collect() [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command_class_id` [INFO] [stderr] --> examples/poll.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | for (command_class_id, command_class) in &device.command_classes { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_command_class_id` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/poll.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | let hostname = args.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] warning: use of deprecated item 'razberry::RazberryClient::get_server_timestamp' [INFO] [stderr] --> examples/old_login_and_query.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | let timestamp = client.get_server_timestamp().unwrap().get_timestamp(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'razberry::RazberryClient::get_data' [INFO] [stderr] --> examples/old_login_and_query.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let data = client.get_data().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/poll.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | let username = args.get(2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/poll.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | let password = args.get(3).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> examples/poll.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | let _r = client.load_devices().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> examples/poll.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | let _r = client.poll_updates().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/old_login_and_query.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | let hostname = args.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/old_login_and_query.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | let username = args.get(2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/old_login_and_query.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | let password = args.get(3).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'razberry::RazberryClient::fetch_gateway_state' [INFO] [stderr] --> examples/old_poll.rs:32:34 [INFO] [stderr] | [INFO] [stderr] 32 | let mut gateway_state = client.fetch_gateway_state().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'razberry::RazberryClient::update_gateway_state' [INFO] [stderr] --> examples/old_poll.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | match client.update_gateway_state(&mut gateway_state) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/old_poll.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | let hostname = args.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/old_poll.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | let username = args.get(2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/old_poll.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | let password = args.get(3).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.16s [INFO] running `"docker" "inspect" "79e4c29d454a19352ae349adf91a40a70c3fd30f0d846496581157f71963cd58"` [INFO] running `"docker" "rm" "-f" "79e4c29d454a19352ae349adf91a40a70c3fd30f0d846496581157f71963cd58"` [INFO] [stdout] 79e4c29d454a19352ae349adf91a40a70c3fd30f0d846496581157f71963cd58