[INFO] crate rayon-hash 0.4.1 is already in cache [INFO] extracting crate rayon-hash 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/rayon-hash/0.4.1 [INFO] extracting crate rayon-hash 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rayon-hash/0.4.1 [INFO] validating manifest of rayon-hash-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rayon-hash-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rayon-hash-0.4.1 [INFO] finished frobbing rayon-hash-0.4.1 [INFO] frobbed toml for rayon-hash-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/rayon-hash/0.4.1/Cargo.toml [INFO] started frobbing rayon-hash-0.4.1 [INFO] finished frobbing rayon-hash-0.4.1 [INFO] frobbed toml for rayon-hash-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rayon-hash/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rayon-hash-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rayon-hash/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9576cf2640f68c01ad94fa193018ce238855237edb883ce2c6105762a91f5582 [INFO] running `"docker" "start" "-a" "9576cf2640f68c01ad94fa193018ce238855237edb883ce2c6105762a91f5582"` [INFO] [stderr] Checking rayon-hash v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/par/map.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/par/map.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | counter: counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/par/map.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/par/map.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | counter: counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:151:14 [INFO] [stderr] | [INFO] [stderr] 151 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:183:14 [INFO] [stderr] | [INFO] [stderr] 183 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/std_hash/table.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn inspect(&self) -> HashUint { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut usize`) [INFO] [stderr] --> src/std_hash/table.rs:745:29 [INFO] [stderr] | [INFO] [stderr] 745 | hash_start: buffer as *mut HashUint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rayon-hash`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:151:14 [INFO] [stderr] | [INFO] [stderr] 151 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/alloc.rs:183:14 [INFO] [stderr] | [INFO] [stderr] 183 | .ok_or(layout_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(layout_err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/par/map.rs:293:47 [INFO] [stderr] | [INFO] [stderr] 293 | map.par_values_mut().for_each(|value| *value = (*value) * 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/std_hash/table.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn inspect(&self) -> HashUint { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut usize`) [INFO] [stderr] --> src/std_hash/table.rs:745:29 [INFO] [stderr] | [INFO] [stderr] 745 | hash_start: buffer as *mut HashUint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/std_hash/map.rs:3464:5 [INFO] [stderr] | [INFO] [stderr] 3464 | / fn test_lots_of_insertions() { [INFO] [stderr] 3465 | | let mut m = HashMap::new(); [INFO] [stderr] 3466 | | [INFO] [stderr] 3467 | | // Try this a few times to make sure we never screw up the hashmap's [INFO] [stderr] ... | [INFO] [stderr] 3523 | | } [INFO] [stderr] 3524 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/std_hash/map.rs:3475:26 [INFO] [stderr] | [INFO] [stderr] 3475 | for j in 1..i + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/std_hash/map.rs:3494:26 [INFO] [stderr] | [INFO] [stderr] 3494 | for j in 1..i + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/std_hash/map.rs:3647:13 [INFO] [stderr] | [INFO] [stderr] 3647 | *value = (*value) * 2 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/std_hash/map.rs:3894:9 [INFO] [stderr] | [INFO] [stderr] 3894 | map[&4]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/std_hash/map.rs:4028:18 [INFO] [stderr] | [INFO] [stderr] 4028 | a.insert(key.clone(), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 4028 | a.insert(&(*key).clone(), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 4028 | a.insert(&str::clone(key), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/std_hash/map.rs:4028:31 [INFO] [stderr] | [INFO] [stderr] 4028 | a.insert(key.clone(), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 4028 | a.insert(key.clone(), &(*value).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 4028 | a.insert(key.clone(), &str::clone(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/std_hash/map.rs:4032:23 [INFO] [stderr] | [INFO] [stderr] 4032 | match a.entry(key.clone()) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 4032 | match a.entry(&(*key).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 4032 | match a.entry(&str::clone(key)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/std_hash/map.rs:4047:23 [INFO] [stderr] | [INFO] [stderr] 4047 | match a.entry(key.clone()) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 4047 | match a.entry(&(*key).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 4047 | match a.entry(&str::clone(key)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/std_hash/map.rs:4051:26 [INFO] [stderr] | [INFO] [stderr] 4051 | e.insert(value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 4051 | e.insert(&(*value).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 4051 | e.insert(&str::clone(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rayon-hash`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9576cf2640f68c01ad94fa193018ce238855237edb883ce2c6105762a91f5582"` [INFO] running `"docker" "rm" "-f" "9576cf2640f68c01ad94fa193018ce238855237edb883ce2c6105762a91f5582"` [INFO] [stdout] 9576cf2640f68c01ad94fa193018ce238855237edb883ce2c6105762a91f5582