[INFO] crate rayon-core 1.4.1 is already in cache [INFO] extracting crate rayon-core 1.4.1 into work/ex/clippy-test-run/sources/stable/reg/rayon-core/1.4.1 [INFO] extracting crate rayon-core 1.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rayon-core/1.4.1 [INFO] validating manifest of rayon-core-1.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rayon-core-1.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rayon-core-1.4.1 [INFO] removed 0 missing tests [INFO] finished frobbing rayon-core-1.4.1 [INFO] frobbed toml for rayon-core-1.4.1 written to work/ex/clippy-test-run/sources/stable/reg/rayon-core/1.4.1/Cargo.toml [INFO] started frobbing rayon-core-1.4.1 [INFO] removed 0 missing tests [INFO] finished frobbing rayon-core-1.4.1 [INFO] frobbed toml for rayon-core-1.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rayon-core/1.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rayon-core-1.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rayon-core/1.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6586c2e1ae34891b810bd8210a0f64ff188452a30817bee6209f501cf958344e [INFO] running `"docker" "start" "-a" "6586c2e1ae34891b810bd8210a0f64ff188452a30817bee6209f501cf958344e"` [INFO] [stderr] Compiling rayon-core v1.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/latch.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | sleep: sleep, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sleep` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | latch: latch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `latch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | job_injector: job_injector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_injector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | stealer: stealer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `stealer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:638:9 [INFO] [stderr] | [INFO] [stderr] 638 | worker: worker, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `worker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:639:9 [INFO] [stderr] | [INFO] [stderr] 639 | breadth_first: breadth_first, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `breadth_first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:640:9 [INFO] [stderr] | [INFO] [stderr] 640 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scope/internal.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | LocalScopeHandle { scope: scope } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread_pool/internal.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | ThreadPoolScopeHandle { registry: registry } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread_pool/mod.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(ThreadPool { registry: registry }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:443:32 [INFO] [stderr] | [INFO] [stderr] 443 | ThreadPoolBuildError { kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/latch.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | sleep: sleep, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sleep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | migrated: migrated, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `migrated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | latch: latch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `latch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | job_injector: job_injector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_injector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | stealer: stealer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `stealer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:638:9 [INFO] [stderr] | [INFO] [stderr] 638 | worker: worker, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `worker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:639:9 [INFO] [stderr] | [INFO] [stderr] 639 | breadth_first: breadth_first, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `breadth_first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:640:9 [INFO] [stderr] | [INFO] [stderr] 640 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scope/test.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scope/internal.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | LocalScopeHandle { scope: scope } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread_pool/internal.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | ThreadPoolScopeHandle { registry: registry } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread_pool/mod.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(ThreadPool { registry: registry }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:443:32 [INFO] [stderr] | [INFO] [stderr] 443 | ThreadPoolBuildError { kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | migrated: migrated, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `migrated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/join/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return (result_a, job_b.into_result()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result_a, job_b.into_result())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/join/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return (result_a, job_b.into_result()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result_a, job_b.into_result())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | m: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | let mut guard = self.m.lock().unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | let guard = self.m.lock().unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | let mut guard = self.m.lock().unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/job.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | pub unsafe fn as_job_ref(self: Box) -> JobRef { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/registry.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | .map(|s| ThreadInfo::new(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ThreadInfo::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/registry.rs:476:19 [INFO] [stderr] | [INFO] [stderr] 476 | Cell::new(0 as *const WorkerThread) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/registry.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | self.worker.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.worker.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/thread_pool/mod.rs:169:69 [INFO] [stderr] | [INFO] [stderr] 169 | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 170 | | None [INFO] [stderr] 171 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/thread_pool/mod.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | if curr.is_null() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 168 | | None [INFO] [stderr] 169 | | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/thread_pool/mod.rs:204:69 [INFO] [stderr] | [INFO] [stderr] 204 | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 205 | | None [INFO] [stderr] 206 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/thread_pool/mod.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | if curr.is_null() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 203 | | None [INFO] [stderr] 204 | | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rayon-core`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | m: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | let mut guard = self.m.lock().unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | let guard = self.m.lock().unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/latch.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | let mut guard = self.m.lock().unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/job.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | pub unsafe fn as_job_ref(self: Box) -> JobRef { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/registry.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | .map(|s| ThreadInfo::new(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ThreadInfo::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/registry.rs:476:19 [INFO] [stderr] | [INFO] [stderr] 476 | Cell::new(0 as *const WorkerThread) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/registry.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | self.worker.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.worker.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scope/test.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | let mut max_diff = Mutex::new(0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scope/test.rs:152:61 [INFO] [stderr] | [INFO] [stderr] 152 | scope(|s| the_final_countdown(s, &bottom_of_stack, &max_diff, 5)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scope/test.rs:153:28 [INFO] [stderr] | [INFO] [stderr] 153 | let diff_when_5 = *max_diff.get_mut().unwrap() as f64; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scope/test.rs:155:61 [INFO] [stderr] | [INFO] [stderr] 155 | scope(|s| the_final_countdown(s, &bottom_of_stack, &max_diff, 500)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scope/test.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | let diff_when_500 = *max_diff.get_mut().unwrap() as f64; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scope/test.rs:166:49 [INFO] [stderr] | [INFO] [stderr] 166 | bottom_of_stack: &'scope i32, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/thread_pool/test.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | .exit_handler(move |i| exit_handler(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `exit_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/thread_pool/test.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | .start_handler(move |i| start_handler(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `start_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/thread_pool/test.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | .exit_handler(move |i| exit_handler(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `exit_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/thread_pool/test.rs:125:24 [INFO] [stderr] | [INFO] [stderr] 125 | .start_handler(move |i| start_handler(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `start_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/thread_pool/mod.rs:169:69 [INFO] [stderr] | [INFO] [stderr] 169 | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 170 | | None [INFO] [stderr] 171 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/thread_pool/mod.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | if curr.is_null() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 168 | | None [INFO] [stderr] 169 | | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/thread_pool/mod.rs:204:69 [INFO] [stderr] | [INFO] [stderr] 204 | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 205 | | None [INFO] [stderr] 206 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/thread_pool/mod.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | if curr.is_null() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 203 | | None [INFO] [stderr] 204 | | } else if (*curr).registry().id() != self.registry.id() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rayon-core`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6586c2e1ae34891b810bd8210a0f64ff188452a30817bee6209f501cf958344e"` [INFO] running `"docker" "rm" "-f" "6586c2e1ae34891b810bd8210a0f64ff188452a30817bee6209f501cf958344e"` [INFO] [stdout] 6586c2e1ae34891b810bd8210a0f64ff188452a30817bee6209f501cf958344e